[PATCH v5 0/3] MR5584: mf: Fixes the missing MESessionClosed event in various scenarios.

List overview All Threads

newer

older

[PATCH v5 0/3] MR4826: Mach vm...

[PATCH v15 0/4] MR4551:...

Brendan McGrath (＠redmcg)

18 Jun 2024 18 Jun '24

10:55 p.m.

Killsquad sends a MESessionClose at various times depending on user input. It always expects a MESessionClosed event and will wait indefinitely if not received. There are currently a number of scenarios where we don't report the MESessionClose event. This MR attempts to fix that.

-- v5: mf: Handle an error during Media Session Close. mf: Handle MediaSession Close when state is SESSION_STATE_RESTARTING_SOURCES. mf/tests: Add additional tests for MESessionClosed event.

https://gitlab.winehq.org/wine/wine/-/merge_requests/5584

Show replies by date

Brendan McGrath

18 Jun 18 Jun

10:55 p.m.

New subject: [PATCH v5 1/3] mf/tests: Add additional tests for MESessionClosed event.

From: Brendan McGrath bmcgrath@codeweavers.com

--- dlls/mf/tests/mf.c | 89 ++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 89 insertions(+)

diff --git a/dlls/mf/tests/mf.c b/dlls/mf/tests/mf.c index a2f183e5cc4..4773f202ccc 100644 --- a/dlls/mf/tests/mf.c +++ b/dlls/mf/tests/mf.c @@ -6249,6 +6249,8 @@ static void test_media_session_Start(void) ok(hr == S_OK, "Unexpected hr %#lx.\n", hr); hr = IMFMediaSession_Close(session); ok(hr == S_OK, "Unexpected hr %#lx.\n", hr); + hr = wait_media_event(session, callback, MESessionClosed, 1000, &propvar); + ok(hr == S_OK, "Unexpected hr %#lx.\n", hr);

/* Media session is shut down */ hr = IMFMediaSource_Shutdown(source); @@ -6331,6 +6333,9 @@ static void test_media_session_Start(void) ok(hr == S_OK, "Unexpected hr %#lx.\n", hr); hr = IMFMediaSession_Close(session); ok(hr == S_OK, "Unexpected hr %#lx.\n", hr); + hr = wait_media_event(session, callback, MESessionClosed, 1000, &propvar); + todo_wine + ok(hr == S_OK, "Unexpected hr %#lx.\n", hr); hr = IMFMediaSession_Shutdown(session); ok(hr == S_OK, "Unexpected hr %#lx.\n", hr); hr = IMFMediaSource_Shutdown(source); @@ -6534,6 +6539,89 @@ static void test_MFEnumDeviceSources(void) CoUninitialize(); }

+static void test_media_session_Close(void) +{ + media_type_desc video_rgb32_desc = + { + ATTR_GUID(MF_MT_MAJOR_TYPE, MFMediaType_Video), + ATTR_GUID(MF_MT_SUBTYPE, MFVideoFormat_RGB32), + }; + struct test_grabber_callback *grabber_callback; + IMFPresentationClock *presentation_clock; + IMFActivate *sink_activate; + IMFAsyncCallback *callback; + IMFMediaType *output_type; + IMFMediaSession *session; + IMFMediaSource *source; + IMFTopology *topology; + PROPVARIANT propvar; + IMFClock *clock; + UINT64 duration; + HRESULT hr; + + hr = MFStartup(MF_VERSION, MFSTARTUP_FULL); + ok(hr == S_OK, "Failed to start up, hr %#lx.\n", hr); + + if (!(source = create_media_source(L"test.mp4", L"video/mp4"))) + { + todo_wine /* Gitlab CI Debian runner */ + win_skip("MP4 media source is not supported, skipping tests.\n"); + MFShutdown(); + return; + } + + grabber_callback = impl_from_IMFSampleGrabberSinkCallback(create_test_grabber_callback()); + hr = MFCreateMediaType(&output_type); + ok(hr == S_OK, "Unexpected hr %#lx.\n", hr); + init_media_type(output_type, video_rgb32_desc, -1); + hr = MFCreateSampleGrabberSinkActivate(output_type, &grabber_callback->IMFSampleGrabberSinkCallback_iface, &sink_activate); + ok(hr == S_OK, "Failed to create grabber sink, hr %#lx.\n", hr); + IMFMediaType_Release(output_type); + + hr = MFCreateMediaSession(NULL, &session); + ok(hr == S_OK, "Unexpected hr %#lx.\n", hr); + + topology = create_test_topology(source, sink_activate, &duration); + hr = IMFMediaSession_SetTopology(session, 0, topology); + ok(hr == S_OK, "Unexpected hr %#lx.\n", hr); + IMFTopology_Release(topology); + + hr = IMFMediaSession_GetClock(session, &clock); + ok(hr == S_OK, "Unexpected hr %#lx.\n", hr); + hr = IMFClock_QueryInterface(clock, &IID_IMFPresentationClock, (void **)&presentation_clock); + ok(hr == S_OK, "Unexpected hr %#lx.\n", hr); + IMFClock_Release(clock); + + propvar.vt = VT_EMPTY; + hr = IMFMediaSession_Start(session, &GUID_NULL, &propvar); + ok(hr == S_OK, "Unexpected hr %#lx.\n", hr); + callback = create_test_callback(TRUE); + hr = wait_media_event(session, callback, MESessionStarted, 5000, &propvar); + ok(hr == S_OK, "Unexpected hr %#lx.\n", hr); + + hr = IMFMediaSession_Close(session); + ok(hr == S_OK, "Unexpected hr %#lx.\n", hr); + hr = IMFMediaSource_Shutdown(source); + ok(hr == S_OK, "Unexpected hr %#lx.\n", hr); + hr = wait_media_event_until_blocking(session, callback, MESessionClosed, 5000, &propvar); + todo_wine + ok(hr == MF_E_SHUTDOWN, "Unexpected hr %#lx.\n", hr); + + hr = IMFMediaSession_Shutdown(session); + ok(hr == S_OK, "Unexpected hr %#lx.\n", hr); + + IMFPresentationClock_Release(presentation_clock); + IMFAsyncCallback_Release(callback); + IMFMediaSession_Release(session); + IMFActivate_ShutdownObject(sink_activate); + IMFActivate_Release(sink_activate); + IMFSampleGrabberSinkCallback_Release(&grabber_callback->IMFSampleGrabberSinkCallback_iface); + IMFMediaSource_Release(source); + + hr = MFShutdown(); + ok(hr == S_OK, "Unexpected hr %#lx.\n", hr); +} + START_TEST(mf) { init_functions(); @@ -6568,4 +6656,5 @@ START_TEST(mf) test_MFCreateSequencerSegmentOffset(); test_media_session_Start(); test_MFEnumDeviceSources(); + test_media_session_Close(); }

-- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/5584

Brendan McGrath

10:55 p.m.

New subject: [PATCH v5 2/3] mf: Handle MediaSession Close when state is SESSION_STATE_RESTARTING_SOURCES.

From: Brendan McGrath bmcgrath@codeweavers.com

Fixes the missing MESessionClosed event in this scenario. --- dlls/mf/session.c | 1 + dlls/mf/tests/mf.c | 1 - 2 files changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/mf/session.c b/dlls/mf/session.c index 865399488ae..99e7b0872fb 100644 --- a/dlls/mf/session.c +++ b/dlls/mf/session.c @@ -1274,6 +1274,7 @@ static void session_close(struct media_session *session) switch (session->state) { case SESSION_STATE_STOPPED: + case SESSION_STATE_RESTARTING_SOURCES: hr = session_finalize_sinks(session); break; case SESSION_STATE_STARTED: diff --git a/dlls/mf/tests/mf.c b/dlls/mf/tests/mf.c index 4773f202ccc..483a8753f85 100644 --- a/dlls/mf/tests/mf.c +++ b/dlls/mf/tests/mf.c @@ -6334,7 +6334,6 @@ static void test_media_session_Start(void) hr = IMFMediaSession_Close(session); ok(hr == S_OK, "Unexpected hr %#lx.\n", hr); hr = wait_media_event(session, callback, MESessionClosed, 1000, &propvar); - todo_wine ok(hr == S_OK, "Unexpected hr %#lx.\n", hr); hr = IMFMediaSession_Shutdown(session); ok(hr == S_OK, "Unexpected hr %#lx.\n", hr);

-- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/5584

Brendan McGrath

10:55 p.m.

New subject: [PATCH v5 3/3] mf: Handle an error during Media Session Close.

From: Brendan McGrath bmcgrath@codeweavers.com

Fixes the missing MESessionClosed event in this scenario. --- dlls/mf/session.c | 9 ++++++++- dlls/mf/tests/mf.c | 1 - 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/dlls/mf/session.c b/dlls/mf/session.c index 99e7b0872fb..dc9578ce86b 100644 --- a/dlls/mf/session.c +++ b/dlls/mf/session.c @@ -3193,8 +3193,15 @@ static void session_set_sink_stream_state(struct media_session *session, IMFStre break; }

- if (session->presentation.flags & SESSION_FLAG_END_OF_PRESENTATION || FAILED(hr)) + if (session->presentation.flags & SESSION_FLAG_END_OF_PRESENTATION) session_set_stopped(session, hr); + else if (FAILED(hr)) + { + if (session->presentation.flags & SESSION_FLAG_FINALIZE_SINKS) + session_set_closed(session, hr); + else + session_set_stopped(session, hr); + }

break; default: diff --git a/dlls/mf/tests/mf.c b/dlls/mf/tests/mf.c index 483a8753f85..c42676b38d9 100644 --- a/dlls/mf/tests/mf.c +++ b/dlls/mf/tests/mf.c @@ -6603,7 +6603,6 @@ static void test_media_session_Close(void) hr = IMFMediaSource_Shutdown(source); ok(hr == S_OK, "Unexpected hr %#lx.\n", hr); hr = wait_media_event_until_blocking(session, callback, MESessionClosed, 5000, &propvar); - todo_wine ok(hr == MF_E_SHUTDOWN, "Unexpected hr %#lx.\n", hr);

hr = IMFMediaSession_Shutdown(session);

-- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/5584

Marvin

11:55 p.m.

New subject: [PATCH v5 3/3] mf: Handle an error during Media Session Close.

Hi,

It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=146387

Your paranoid android.

=== w7u_2qxl (32 bit report) ===

mf: mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf.c:6336: Test failed: WaitForSingleObject returned 258 mf.c:6336: Test failed: Unexpected hr 0xd36d8. mf: Timeout

=== w7u_adm (32 bit report) ===

=== w7u_el (32 bit report) ===

Report validation errors: mf:mf has unaccounted for failure messages The report seems to have been truncated

=== w7pro64 (64 bit report) ===

Brendan McGrath (＠redmcg)

11:18 p.m.

On Tue Jun 18 23:18:08 2024 +0000, Nikolay Sivov wrote:

...

Could you please split up first 3 commits that improve MESessionClosed to another MR? We'll get them in first, and I'm going to see what could be done for events queue shutdown.

I've just removed that last commit and re-based on master; so only the first 3 commits remain in this one.

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5584#note_73657

Nikolay Sivov (＠nsivov)

19 Jun 19 Jun

1:59 p.m.

I do get one refcount test failing in test_sar() with just first tests commit. I don't know if it's related, or is happening more often. It doesn't fail CI, so I'm going to ignore that.

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5584#note_73730

Nikolay Sivov (＠nsivov)

1:59 p.m.

New subject: [PATCH v5 0/3] MR5584: mf: Fixes the missing MESessionClosed event in various scenarios. - approved

This merge request was approved by Nikolay Sivov.

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5584

231

Age (days ago)

232

Last active (days ago)

wine-gitlab@winehq.org

7 comments

4 participants

tags (0)

participants (4)

Brendan McGrath
Brendan McGrath (＠redmcg)
Marvin
Nikolay Sivov (＠nsivov)