On Fri May 2 16:52:15 2025 +0000, Rémi Bernon wrote:
This broke comctl32:status dwrite:font (win32/wow64) gdi32:font user32:sysparams usp10:usp10 tests.
I apologize for the stupid mistake. !7956 will fix it. Literally two minutes after I sent it, Bernhard sent an alternative fix in !7957 which would also be fine.
I recognize that this happened primarily due to human error on my part. Nevertheless, another part of the problem is that the 32-bit tests always fail, and somehow this mistake did not cause the 64-bit tests to fail. That means that I need to spend some time helping with the intermittent test failures because they're making it too easy for me to overlook test failures that actually matter. Until the tests can be expected to pass, I will have to remember to read through the entire list of failures whenever I send a patch.
-
Alex Henrie (＠alexhenrie)