[PATCH 0/1] MR2156: winebus: Avoid calling RtlInitUnicodeString on a static constant.

[PATCH 1/1] winebus: Avoid calling RtlInitUnicodeString on a static constant.

[Alex Henrie]

From: Alex Henrie

---
 dlls/winebus.sys/main.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/dlls/winebus.sys/main.c b/dlls/winebus.sys/main.c
index c02f786a11f..a002e974fea 100644
--- a/dlls/winebus.sys/main.c
+++ b/dlls/winebus.sys/main.c
@@ -648,14 +648,13 @@ static void sdl_bus_load_mappings(struct sdl_bus_options *options)
     KEY_VALUE_FULL_INFORMATION *info;
     OBJECT_ATTRIBUTES attr = {0};
     char **mappings = NULL;
-    UNICODE_STRING path;
+    UNICODE_STRING path = RTL_CONSTANT_STRING(L"map");
     NTSTATUS status;
     HANDLE key;

options->mappings_count = 0;
     options->mappings = NULL;

-    RtlInitUnicodeString(&path, L"map");
     InitializeObjectAttributes(&attr, &path, OBJ_CASE_INSENSITIVE | OBJ_KERNEL_HANDLE, driver_key, NULL);
     status = NtOpenKey(&key, KEY_ALL_ACCESS, &attr);
     if (status) return;

[Rémi Bernon (＠rbernon)]

Rémi Bernon (@rbernon) commented about dlls/winebus.sys/main.c:
>  KEY_VALUE_FULL_INFORMATION *info;
>  OBJECT_ATTRIBUTES attr = {0};
>  char **mappings = NULL;
> - UNICODE_STRING path;
> - UNICODE_STRING path = RTL_CONSTANT_STRING(L"map");
> NTSTATUS status;
> HANDLE key;

```suggestion:-6+0
    ULONG idx = 0, len, count = 0, capacity, info_size, info_max_size;
    UNICODE_STRING path = RTL_CONSTANT_STRING(L"map");
    KEY_VALUE_FULL_INFORMATION *info;
    OBJECT_ATTRIBUTES attr = {0};
    char **mappings = NULL;
    NTSTATUS status;
    HANDLE key;
```