[PATCH 0/1] MR6601: advapi32: Use CreateProcessAsUser to implement CreateProcessWithToken.

[Tim Clem (＠tclem)]

MSDN is pretty quiet on the difference between these two functions, which is why I've left CreateProcessWithToken marked as a semi-stub. Using CreateProcessAsUser at least means that the token will be applied to the new process.

[PATCH 1/1] advapi32: Use CreateProcessAsUser to implement CreateProcessWithToken.

[Tim Clem]

From: Tim Clem

---
 dlls/advapi32/security.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/dlls/advapi32/security.c b/dlls/advapi32/security.c
index 0f36cc4d536..8e8de46eadb 100644
--- a/dlls/advapi32/security.c
+++ b/dlls/advapi32/security.c
@@ -2695,8 +2695,8 @@ BOOL WINAPI CreateProcessWithTokenW(HANDLE token, DWORD logon_flags, LPCWSTR app
           startup_info, process_information);

/* FIXME: check if handles should be inherited */
-    return CreateProcessW( application_name, command_line, NULL, NULL, FALSE, creation_flags, environment,
-                           current_directory, startup_info, process_information );
+    return CreateProcessAsUserW( token, application_name, command_line, NULL, NULL, FALSE, creation_flags,
+                                 environment, current_directory, startup_info, process_information );
 }

/******************************************************************************

[PATCH 1/1] advapi32: Use CreateProcessAsUser to implement CreateProcessWithToken.

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=148806

Your paranoid android.

=== debian11b (64 bit WoW report) ===

d3d9:
d3d9ex.c:3230: Test failed: Expected message 0x18 for window 0, but didn't receive it, i=0.