[PATCH v3 0/1] MR7781: combase: Add stub for RoOriginateErrorW.

[Louis Lenders (＠xe)]

This is called by UniGetUi (https://github.com/marticliment/UniGetUI/releases/tag/3.1.8).

(After choosing 'Install for all users' --> 'perform portable installation' otherwise the installer runs into other (shellfolder) related bugs)

--
  v3: combase: Add stub for RoOriginateErrorW.

https://gitlab.winehq.org/wine/wine/-/merge_requests/7781

[PATCH v3 1/1] combase: Add stub for RoOriginateErrorW.

[Louis Lenders]

From: Louis Lenders

v2: Improve FIXME.
---
 dlls/combase/combase.spec | 2 +-
 dlls/combase/roapi.c      | 9 +++++++++
 include/roerrorapi.h      | 1 +
 3 files changed, 11 insertions(+), 1 deletion(-)

diff --git a/dlls/combase/combase.spec b/dlls/combase/combase.spec
index 4bdc14334e2..dd28feb06d4 100644
--- a/dlls/combase/combase.spec
+++ b/dlls/combase/combase.spec
@@ -302,7 +302,7 @@
 @ stub RoInspectCapturedStackBackTrace
 @ stub RoInspectThreadErrorInfo
 @ stdcall RoOriginateError(long ptr)
-@ stub RoOriginateErrorW
+@ stdcall RoOriginateErrorW(long long wstr)
 @ stdcall RoOriginateLanguageException(long ptr ptr)
 @ stub RoParameterizedTypeExtraGetTypeSignature
 @ stdcall RoRegisterActivationFactories(ptr ptr long ptr)
diff --git a/dlls/combase/roapi.c b/dlls/combase/roapi.c
index 0f8a9438821..8ffdf908e69 100644
--- a/dlls/combase/roapi.c
+++ b/dlls/combase/roapi.c
@@ -498,6 +498,15 @@ BOOL WINAPI RoOriginateError(HRESULT error, HSTRING message)
     return FALSE;
 }

+/***********************************************************************
+ *      RoOriginateErrorW (combase.@)
+ */
+BOOL WINAPI RoOriginateErrorW(HRESULT error, UINT max_len, const WCHAR *message)
+{
+    FIXME("%#lx, %u, %s: stub\n", error, max_len, debugstr_wn(message, max_len ? max_len : -1));
+    return FALSE;
+}
+
 /***********************************************************************
  *      RoSetErrorReportingFlags (combase.@)
  */
diff --git a/include/roerrorapi.h b/include/roerrorapi.h
index 741347455b1..45d7b298b3f 100644
--- a/include/roerrorapi.h
+++ b/include/roerrorapi.h
@@ -34,6 +34,7 @@ typedef enum

HRESULT WINAPI GetRestrictedErrorInfo(IRestrictedErrorInfo **info);
 BOOL    WINAPI RoOriginateError(HRESULT error, HSTRING message);
+BOOL    WINAPI RoOriginateErrorW(HRESULT error, UINT max_len, const WCHAR *message);
 BOOL    WINAPI RoOriginateLanguageException(HRESULT error, HSTRING message, IUnknown *language_exception);
 HRESULT WINAPI RoSetErrorReportingFlags(UINT32 flags);

[Elizabeth Figura (＠zfigura)]

On Wed Apr 23 18:28:13 2025 +0000, Louis Lenders wrote:
> changed this line in [version 3 of the diff](/wine/wine/-/merge_requests/7781/diffs?diff_id=173093&start_sha=9f6a55b444bd46ea4143102197ba65727291debd#fe8d5f421f0a0f2eef3bb27caead7c50645a5dea_515_506)

That doesn't seem quite right either though, since debugstr_wn() will read past a terminating null.

[Huw Davies (＠huw)]

On Wed Apr 23 18:39:06 2025 +0000, Elizabeth Figura wrote:
> That doesn't seem quite right either though, since debugstr_wn() will
> read past a terminating null.

Right.  `wcsnlen()` may be helpful here.  Alternatively, we could simply print the ptr itself and leave it to the eventual implementer to get right.

We should also switch the `wstr` to `ptr` in the spec file.