[PATCH 0/1] MR6718: d3dx9/tests: Disable test sometimes crashing on Windows.

[PATCH 1/1] d3dx9/tests: Disable test sometimes crashing on Windows.

[Matteo Bruni]

From: Matteo Bruni

---
 dlls/d3dx9_36/tests/effect.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/dlls/d3dx9_36/tests/effect.c b/dlls/d3dx9_36/tests/effect.c
index fc1e161d5c9..6ca7a8d8d35 100644
--- a/dlls/d3dx9_36/tests/effect.c
+++ b/dlls/d3dx9_36/tests/effect.c
@@ -7156,11 +7156,17 @@ static void test_effect_get_pass_desc(IDirect3DDevice9 *device)
     pass = effect->lpVtbl->GetPass(effect, "tech0", 1);
     ok(!!pass, "GetPass() failed.\n");

+    /* Calling GetPassDesc() on a D3DXFX_NOT_CLONEABLE effect is apparently
+     * not safe on Windows: the following Release() would crash with a
+     * STATUS_ACCESS_VIOLATION exception on the GitLab CI instance. */
+    if (0)
+    {
     hr = effect->lpVtbl->GetPassDesc(effect, pass, &desc);
     ok(hr == D3D_OK, "Got result %#lx.\n", hr);

ok(!desc.pVertexShaderFunction, "Unexpected non null desc.pVertexShaderFunction.\n");
     ok(!desc.pPixelShaderFunction, "Unexpected non null desc.pPixelShaderFunction.\n");
+    }

effect->lpVtbl->Release(effect);
 }