Re: [PATCH v4 0/3] MR3870: mspatcha: Add support for 32-bit file patching and normalization

[Zebediah Figura (＠zfigura)]

Zebediah Figura (@zfigura) commented about dlls/mspatcha/mspatcha_main.c:
> {
> - FIXME("stub - %p, %lu, %lx, %p, %lu, %lu, %lu, %p, %lu, %p\n", file_buffer, file_size, flags, options, new_coff_base,
> -
>    new_coff_time, ignore_range_count, ignore_range, retain_range_count, retain_range);
> - SetLastError(ERROR_CALL_NOT_IMPLEMENTED);
> - return 0;
> - int result;
> -
> - result = normalize_old_file_image(
> -
>    file_buffer, file_size,
> -
>    option_flags, option_data,
> -
>    new_coff_base, new_coff_time,
> -
>    ignore_range_array, ignore_range_count,
> -
>    retain_range_array, retain_range_count);
> -
> - return result;
>
> }

The column limit is larger than 50 characters. No need to reflow to make it shorter.

I'd advocate for keeping a trace in any API entry point.

The 'result' variable is useless.