Re: [PATCH v2 0/1] MR9234: ntdll: Call cache_inproc_sync() inside the lock.

[Rémi Bernon (＠rbernon)]

On Mon Oct 20 21:05:58 2025 +0000, Elizabeth Figura wrote:
> > Nvm, I guess the entire sync retrieval and caching needs to be atomic.
>
> Does it? I'm not sure I see how; I think you're right that the mmap
> doesn't need to be in the lock. I don't know that it's really important,
> given how rare it'll be in practice, but theoretically it could be
> outside the lock.

Hmm... If the cache update is outside of the lock, more than one thread might have retrieved the sync and try to update the cache concurrently.

I think in the current state this will break as multiple thread may pass the `if (InterlockedCompareExchange( &cache->refcount, 0, 0 ))` check successfully.