Re: [PATCH v25 0/7] MR2786: Add support for AF_UNIX sockets

[Zebediah Figura (＠zfigura)]

Zebediah Figura (@zfigura) commented about dlls/ws2_32/socket.c:
>      .dwMessageSize = UINT_MAX,
>      .szProtocol = L"SPX II",
>  },
> - {
> -
>    .dwServiceFlags1 = XP1_GUARANTEED_DELIVERY | XP1_GUARANTEED_ORDER | XP1_IFS_HANDLES,
> -
>    .dwProviderFlags = PFL_MATCHES_PROTOCOL_ZERO,
> -
>    .ProviderId = {0xa00943d9, 0x9c2e, 0x4633, {0x9b, 0x59, 0x00, 0x57, 0xa3, 0x16, 0x09, 0x94}},
> -
>    .dwCatalogEntryId = 1007,
> -
>    .ProtocolChain.ChainLen = 1,
> -
>    .iVersion = 2,
> -
>    .iAddressFamily = AF_UNIX,
> -
>    .iMaxSockAddr = sizeof(struct sockaddr_un),
> -
>    .iMinSockAddr = sizeof(struct sockaddr_un) - sizeof((struct sockaddr_un){}.sun_path),

I don't think the {} construction is portable. We have offsetof() for this anyway.