On Wed Aug 14 17:21:18 2024 +0000, Alfred Agrell wrote:
I can't see anything obviously wrong in v8 3/3(*). Do you want 3/3 merged into 1/3? And yeah, that looks strange. Not exactly wrong - S_OK means it fetched as many items as it asked for, so that'll just write the value that's already there (unless the Next impl is buggy or something) - but certainly strange. Yeah, better remove it until and unless proven necessary. (*) actually 3/4, but that last one's a merge commit so let's pretend it doesn't exist. Rebase and remove it.
Oh, right, I misremember, S_FALSE is returned if the count isn't equal. So this isn't really that important to fix.