[PATCH v5 0/4] MR5759: comctl32 & user32: Mark radio buttons at selected when focused

[Fabian Maurer (＠DarkShadow44)]

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56109

--
  v5: user32: Send parent BN_CLICKED notification when a radio button get focused
      comctl32: Send parent BN_CLICKED notification when a radio button get focused
      user32/tests: Add tests for radio button WM_SETFOCUS
      comctl32/tests: Add tests for radio button WM_SETFOCUS

https://gitlab.winehq.org/wine/wine/-/merge_requests/5759

[PATCH v5 1/4] comctl32/tests: Add tests for radio button WM_SETFOCUS

[Fabian Maurer]

From: Fabian Maurer

---
 dlls/comctl32/tests/button.c | 50 ++++++++++++++++++++++++++++++++++++
 1 file changed, 50 insertions(+)

diff --git a/dlls/comctl32/tests/button.c b/dlls/comctl32/tests/button.c
index 7c171af8af1..69ee873969f 100644
--- a/dlls/comctl32/tests/button.c
+++ b/dlls/comctl32/tests/button.c
@@ -2462,6 +2462,55 @@ static void test_getobject(void)
     DestroyWindow(hwnd);
 }

+static void test_radiobutton_focus(void)
+{
+    HWND hwnd, button;
+    MSG msg;
+    int i;
+    DWORD types[] = { BS_RADIOBUTTON, BS_AUTORADIOBUTTON };
+
+    static const struct message set_focus1[] =
+    {
+        { WM_SETFOCUS, sent },
+        { WM_COMMAND, sent|parent|wparam, MAKEWPARAM(ID_BUTTON, BN_SETFOCUS) },
+        { WM_COMMAND, sent|parent|wparam, MAKEWPARAM(ID_BUTTON, BN_CLICKED) },
+        { WM_PAINT, sent },
+        { 0 }
+    };
+
+    static const struct message set_focus2[] =
+    {
+        { WM_SETFOCUS, sent },
+        { WM_COMMAND, sent|parent|wparam, MAKEWPARAM(ID_BUTTON, BN_SETFOCUS) },
+        { WM_PAINT, sent },
+        { WM_NCPAINT, sent|defwinproc|optional }, /* FIXME: Wine sends it */
+        { 0 }
+    };
+
+    hwnd = CreateWindowExA(0, "TestParentClass", "Test parent", WS_OVERLAPPEDWINDOW | WS_VISIBLE,
+                               100, 100, 200, 200, 0, 0, 0, NULL);
+    ok(hwnd != 0, "Failed to create parent window\n");
+
+    for (i = 0; i < ARRAY_SIZE(types); i++)
+    {
+        button = create_button(types[i] | WS_VISIBLE, hwnd);
+        while (PeekMessageA(&msg, 0, 0, 0, PM_REMOVE)) DispatchMessageA(&msg);
+        flush_sequences(sequences, NUM_MSG_SEQUENCES);
+        SendMessageA(button, WM_SETFOCUS, 0, 0);
+        while (PeekMessageA(&msg, 0, 0, 0, PM_REMOVE)) DispatchMessageA(&msg);
+        ok_sequence(sequences, COMBINED_SEQ_INDEX, set_focus1, "WM_SETFOCUS on a radiobutton 1", TRUE);
+
+        SendMessageA(button, BM_SETCHECK, BST_CHECKED, 0);
+        flush_sequences(sequences, NUM_MSG_SEQUENCES);
+        SendMessageA(button, WM_SETFOCUS, 0, 0);
+        while (PeekMessageA(&msg, 0, 0, 0, PM_REMOVE)) DispatchMessageA(&msg);
+        ok_sequence(sequences, COMBINED_SEQ_INDEX, set_focus2, "WM_SETFOCUS on a radiobutton 2", FALSE);
+        DestroyWindow(button);
+    }
+
+    DestroyWindow(hwnd);
+}
+
 START_TEST(button)
 {
     BOOL (WINAPI * pIsThemeActive)(VOID);
@@ -2500,6 +2549,7 @@ START_TEST(button)
     test_style();
     test_visual();
     test_getobject();
+    test_radiobutton_focus();

uninit_winevent_hook();

[PATCH v5 2/4] user32/tests: Add tests for radio button WM_SETFOCUS

[Fabian Maurer]

From: Fabian Maurer

---
 dlls/user32/tests/msg.c | 49 +++++++++++++++++++++++++++++++++++++++++
 1 file changed, 49 insertions(+)

diff --git a/dlls/user32/tests/msg.c b/dlls/user32/tests/msg.c
index 0347f0d73b0..fee63308782 100644
--- a/dlls/user32/tests/msg.c
+++ b/dlls/user32/tests/msg.c
@@ -20477,6 +20477,54 @@ static void test_hook_changing_window_proc(void)
     DestroyWindow( hwnd );
 }

+static void test_radiobutton_focus(void)
+{
+    HWND hwnd, button;
+    DWORD style;
+    MSG msg;
+    int i;
+    DWORD types[] = { BS_RADIOBUTTON, BS_AUTORADIOBUTTON };
+
+    static const struct message set_focus1[] =
+    {
+        { WM_COMMAND, sent|parent|wparam, MAKEWPARAM(ID_BUTTON, BN_SETFOCUS) },
+        { WM_COMMAND, sent|parent|wparam, MAKEWPARAM(ID_BUTTON, BN_CLICKED) },
+        { 0 }
+    };
+
+    static const struct message set_focus2[] =
+    {
+        { WM_COMMAND, sent|parent|wparam, MAKEWPARAM(ID_BUTTON, BN_SETFOCUS) },
+        { 0 }
+    };
+
+    hwnd = CreateWindowExA(0, "TestParentClass", "Test parent", WS_OVERLAPPEDWINDOW | WS_VISIBLE,
+                               100, 100, 200, 200, 0, 0, 0, NULL);
+    ok(hwnd != 0, "Failed to create parent window\n");
+
+    for (i = 0; i < ARRAY_SIZE(types); i++)
+    {
+        style = types[i] | WS_CHILD | WS_VISIBLE | BS_NOTIFY;
+        button = CreateWindowExA(0, WC_BUTTONA, "test", style, 0, 0, 50, 14, hwnd, (HMENU)ID_BUTTON, 0, NULL);
+        ok(button != NULL, "failed to create a button, 0x%08lx, %p\n", style, hwnd);
+
+        while (PeekMessageA(&msg, 0, 0, 0, PM_REMOVE)) DispatchMessageA(&msg);
+        flush_sequence();
+        SendMessageA(button, WM_SETFOCUS, 0, 0);
+        while (PeekMessageA(&msg, 0, 0, 0, PM_REMOVE)) DispatchMessageA(&msg);
+        ok_sequence(set_focus1, "WM_SETFOCUS on a radiobutton 1", TRUE);
+
+        SendMessageA(button, BM_SETCHECK, BST_CHECKED, 0);
+        flush_sequence();
+        SendMessageA(button, WM_SETFOCUS, 0, 0);
+        while (PeekMessageA(&msg, 0, 0, 0, PM_REMOVE)) DispatchMessageA(&msg);
+        ok_sequence(set_focus2, "WM_SETFOCUS on a radiobutton 2", FALSE);
+        DestroyWindow(button);
+    }
+
+    DestroyWindow(hwnd);
+}
+
 START_TEST(msg)
 {
     char **test_argv;
@@ -20524,6 +20572,7 @@ START_TEST(msg)
     test_setparent_status();
     test_InSendMessage();
     test_SetFocus();
+    test_radiobutton_focus();
     test_SetParent();
     test_PostMessage();
     test_broadcast();

[PATCH v5 3/4] comctl32: Send parent BN_CLICKED notification when a radio button get focused

[Fabian Maurer]

From: Fabian Maurer

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56109
---
 dlls/comctl32/button.c       | 6 ++++++
 dlls/comctl32/tests/button.c | 2 +-
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/dlls/comctl32/button.c b/dlls/comctl32/button.c
index 11a9760e3e2..073c71a54eb 100644
--- a/dlls/comctl32/button.c
+++ b/dlls/comctl32/button.c
@@ -867,6 +867,12 @@ static LRESULT CALLBACK BUTTON_WindowProc(HWND hWnd, UINT uMsg, WPARAM wParam, L

if (style & BS_NOTIFY)
             BUTTON_NOTIFY_PARENT(hWnd, BN_SETFOCUS);
+
+        if (((btn_type == BS_RADIOBUTTON) || (btn_type == BS_AUTORADIOBUTTON)) &&
+            !(infoPtr->state & BST_CHECKED))
+        {
+            BUTTON_NOTIFY_PARENT(hWnd, BN_CLICKED);
+        }
         break;

case WM_KILLFOCUS:
diff --git a/dlls/comctl32/tests/button.c b/dlls/comctl32/tests/button.c
index 69ee873969f..df38588c1b2 100644
--- a/dlls/comctl32/tests/button.c
+++ b/dlls/comctl32/tests/button.c
@@ -2498,7 +2498,7 @@ static void test_radiobutton_focus(void)
         flush_sequences(sequences, NUM_MSG_SEQUENCES);
         SendMessageA(button, WM_SETFOCUS, 0, 0);
         while (PeekMessageA(&msg, 0, 0, 0, PM_REMOVE)) DispatchMessageA(&msg);
-        ok_sequence(sequences, COMBINED_SEQ_INDEX, set_focus1, "WM_SETFOCUS on a radiobutton 1", TRUE);
+        ok_sequence(sequences, COMBINED_SEQ_INDEX, set_focus1, "WM_SETFOCUS on a radiobutton 1", FALSE);

SendMessageA(button, BM_SETCHECK, BST_CHECKED, 0);
         flush_sequences(sequences, NUM_MSG_SEQUENCES);

[PATCH v5 4/4] user32: Send parent BN_CLICKED notification when a radio button get focused

[Fabian Maurer]

From: Fabian Maurer

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56109
---
 dlls/user32/button.c    | 6 ++++++
 dlls/user32/tests/msg.c | 2 +-
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/dlls/user32/button.c b/dlls/user32/button.c
index 61e34f99246..bbda202314f 100644
--- a/dlls/user32/button.c
+++ b/dlls/user32/button.c
@@ -381,6 +381,12 @@ LRESULT ButtonWndProc_common(HWND hWnd, UINT uMsg, WPARAM wParam, LPARAM lParam,
         paint_button( hWnd, btn_type, ODA_FOCUS );
         if (style & BS_NOTIFY)
             BUTTON_NOTIFY_PARENT(hWnd, BN_SETFOCUS);
+
+        if (((btn_type == BS_RADIOBUTTON) || (btn_type == BS_AUTORADIOBUTTON)) &&
+            !(get_button_state(hWnd) & BST_CHECKED))
+        {
+            BUTTON_NOTIFY_PARENT(hWnd, BN_CLICKED);
+        }
         break;

case WM_KILLFOCUS:
diff --git a/dlls/user32/tests/msg.c b/dlls/user32/tests/msg.c
index fee63308782..9668d29e3e9 100644
--- a/dlls/user32/tests/msg.c
+++ b/dlls/user32/tests/msg.c
@@ -20512,7 +20512,7 @@ static void test_radiobutton_focus(void)
         flush_sequence();
         SendMessageA(button, WM_SETFOCUS, 0, 0);
         while (PeekMessageA(&msg, 0, 0, 0, PM_REMOVE)) DispatchMessageA(&msg);
-        ok_sequence(set_focus1, "WM_SETFOCUS on a radiobutton 1", TRUE);
+        ok_sequence(set_focus1, "WM_SETFOCUS on a radiobutton 1", FALSE);

SendMessageA(button, BM_SETCHECK, BST_CHECKED, 0);
         flush_sequence();

[PATCH v5 4/4] user32: Send parent BN_CLICKED notification when a radio button get focused

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=149138

Your paranoid android.

=== w10pro64_ja (64 bit report) ===

user32:
msg.c:8522: Test failed: Update region shouldn't be empty
msg.c:8523: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected msg 0085 - actual msg 0000
msg.c:8525: Test failed: Paint: 0: the msg sequence is not complete: expected msg 000f - actual msg 0000
msg.c:8547: Test failed: Update region shouldn't be empty
msg.c:8548: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected msg 0085 - actual msg 0000
msg.c:8550: Test failed: Paint: 0: the msg sequence is not complete: expected msg 000f - actual msg 0000
msg.c:8577: Test failed: Update region shouldn't be empty
msg.c:8578: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected msg 0085 - actual msg 0000
msg.c:8580: Test failed: Paint: 0: the msg sequence is not complete: expected msg 000f - actual msg 0000
msg.c:8590: Test failed: Update region shouldn't be empty
msg.c:8591: Test failed: InvalidateErase: 0: the msg sequence is not complete: expected msg 0085 - actual msg 0000
msg.c:8593: Test failed: Paint: 0: the msg sequence is not complete: expected msg 000f - actual msg 0000
msg.c:8966: Test failed: SetWindowPos:FrameChanged_clip: 2: the msg 0x0085 was expected in parent
msg.c:8966: Test failed: SetWindowPos:FrameChanged_clip: 4: the msg 0x0014 was expected in parent
msg.c:8966: Test failed: SetWindowPos:FrameChanged_clip: 5: the msg 0x0085 was expected, but got msg 0x0047 instead
msg.c:8966: Test failed: SetWindowPos:FrameChanged_clip: 6: the msg 0x0014 was expected, but got msg 0x0047 instead
msg.c:8976: Test failed: SetWindowPos:FrameChangedDeferErase: 4: the msg 0x000f was expected in parent
msg.c:8976: Test failed: SetWindowPos:FrameChangedDeferErase: 5: the msg 0x0085 was expected in parent
msg.c:8976: Test failed: SetWindowPos:FrameChangedDeferErase: 6: the msg sequence is not complete: expected msg 000f - actual msg 0000
msg.c:9004: Test failed: SetWindowPos:FrameChangedDeferErase: 4: the msg 0x000f was expected in parent
msg.c:9004: Test failed: SetWindowPos:FrameChangedDeferErase: 5: the msg 0x0085 was expected in parent
msg.c:9004: Test failed: SetWindowPos:FrameChangedDeferErase: 6: the msg sequence is not complete: expected msg 000f - actual msg 0000
msg.c:9358: Test failed: 9466: SetWindowPos redraw #0 (ex_style = 0, style = 0x2000000, shuffle_zorder = 0): delta = -20: Parent update region shall match expected region
msg.c:9358: Test failed: 9466: SetWindowPos redraw #1 (ex_style = 0, style = 0, shuffle_zorder = 0): delta = -20: Parent update region shall match expected region
msg.c:9358: Test failed: 9466: SetWindowPos redraw #2 (ex_style = 0x2000000, style = 0x2000000, shuffle_zorder = 1): delta = -20: Parent update region shall match expected region
msg.c:9419: Test failed: 9466: SetWindowPos redraw #2 (ex_style = 0x2000000, style = 0x2000000, shuffle_zorder = 1): delta = -20: Child update region shall match expected region
msg.c:9358: Test failed: 9466: SetWindowPos redraw #2 (ex_style = 0x2000000, style = 0x2000000, shuffle_zorder = 1): delta = +0: Parent update region shall match expected region
msg.c:9419: Test failed: 9466: SetWindowPos redraw #2 (ex_style = 0x2000000, style = 0x2000000, shuffle_zorder = 1): delta = +0: Child update region shall match expected region
msg.c:9358: Test failed: 9466: SetWindowPos redraw #3 (ex_style = 0x2000000, style = 0, shuffle_zorder = 0): delta = -20: Parent update region shall match expected region
msg.c:9419: Test failed: 9466: SetWindowPos redraw #3 (ex_style = 0x2000000, style = 0, shuffle_zorder = 0): delta = -20: Child update region shall match expected region
msg.c:9358: Test failed: 9466: SetWindowPos redraw #4 (ex_style = 0x2000000, style = 0, shuffle_zorder = 1): delta = -20: Parent update region shall match expected region
msg.c:9419: Test failed: 9466: SetWindowPos redraw #4 (ex_style = 0x2000000, style = 0, shuffle_zorder = 1): delta = -20: Child update region shall match expected region
msg.c:9358: Test failed: 9466: SetWindowPos redraw #4 (ex_style = 0x2000000, style = 0, shuffle_zorder = 1): delta = +0: Parent update region shall match expected region
msg.c:9419: Test failed: 9466: SetWindowPos redraw #4 (ex_style = 0x2000000, style = 0, shuffle_zorder = 1): delta = +0: Child update region shall match expected region
msg.c:9358: Test failed: 9467: SetWindowPos redraw #0 (ex_style = 0, style = 0x2000000, shuffle_zorder = 0): delta = -20: Parent update region shall match expected region
msg.c:9358: Test failed: 9467: SetWindowPos redraw #1 (ex_style = 0, style = 0, shuffle_zorder = 0): delta = -20: Parent update region shall match expected region
msg.c:9358: Test failed: 9468: SetWindowPos redraw #0 (ex_style = 0, style = 0x2000000, shuffle_zorder = 0): delta = -20: Parent update region shall match expected region
msg.c:9358: Test failed: 9468: SetWindowPos redraw #1 (ex_style = 0, style = 0, shuffle_zorder = 0): delta = -20: Parent update region shall match expected region
msg.c:9358: Test failed: 9469: SetWindowPos redraw #0 (ex_style = 0, style = 0x2000000, shuffle_zorder = 0): delta = -20: Parent update region shall match expected region
msg.c:9358: Test failed: 9469: SetWindowPos redraw #1 (ex_style = 0, style = 0, shuffle_zorder = 0): delta = -20: Parent update region shall match expected region
msg.c:9509: Test failed: GetRgnBox (on parent) returned 1
msg.c:9513: Test failed: parent update region: got (0,0)-(0,0), expected (10,10)-(100,100)
msg.c:9517: Test failed: GetRgnBox (on child) returned 1
msg.c:9521: Test failed: child update region: got (0,0)-(0,0), expected (0,0)-(88,88)
msg.c:9546: Test failed: GetRgnBox (on parent) returned 1
msg.c:9550: Test failed: parent update region: got (0,0)-(0,0), expected (20,20)-(120,120)
msg.c:9554: Test failed: GetRgnBox (on child) returned 1
msg.c:9558: Test failed: child update region: got (0,0)-(0,0), expected (0,0)-(98,98)
msg.c:9603: Test failed: GetRgnBox (on parent) returned 1
msg.c:9607: Test failed: parent update region: got (0,0)-(0,0), expected (10,10)-(100,100)
msg.c:9611: Test failed: GetRgnBox (on child) returned 1
msg.c:9615: Test failed: child update region: got (0,0)-(0,0), expected (0,0)-(90,90)
msg.c:9690: Test failed: 2 00cf0000 SetWindowPos redraw #0 (0, 0, 0, 5): Update region shall match expected region
msg.c:9690: Test failed: 2 00cf0000 SetWindowPos redraw #1 (0, 0, 5, 0): Update region shall match expected region
msg.c:9690: Test failed: 2 00cf0000 SetWindowPos redraw #2 (0, 0, 5, 5): Update region shall match expected region
msg.c:9690: Test failed: 2 00cf0000 SetWindowPos redraw #3 (0, 0, -5, -5): Update region shall match expected region
msg.c:9690: Test failed: 2 00cf0000 SetWindowPos redraw #4 (-5, -5, 0, 5): Update region shall match expected region
msg.c:9690: Test failed: 2 00cf0000 SetWindowPos redraw #5 (-5, -5, 5, 0): Update region shall match expected region
msg.c:9690: Test failed: 2 00cf0000 SetWindowPos redraw #6 (-5, -5, 5, 5): Update region shall match expected region
msg.c:9690: Test failed: 1 00cf0000 SetWindowPos redraw #0 (0, 0, 0, 5): Update region shall match expected region
msg.c:9690: Test failed: 1 00cf0000 SetWindowPos redraw #1 (0, 0, 5, 0): Update region shall match expected region
msg.c:9690: Test failed: 1 00cf0000 SetWindowPos redraw #2 (0, 0, 5, 5): Update region shall match expected region
msg.c:9690: Test failed: 1 00cf0000 SetWindowPos redraw #3 (0, 0, -5, -5): Update region shall match expected region
msg.c:9690: Test failed: 1 00cf0000 SetWindowPos redraw #4 (-5, -5, 0, 5): Update region shall match expected region
msg.c:9690: Test failed: 1 00cf0000 SetWindowPos redraw #5 (-5, -5, 5, 0): Update region shall match expected region
msg.c:9690: Test failed: 1 00cf0000 SetWindowPos redraw #6 (-5, -5, 5, 5): Update region shall match expected region
msg.c:9690: Test failed: 3 00cf0000 SetWindowPos redraw #0 (0, 0, 0, 5): Update region shall match expected region
msg.c:9690: Test failed: 3 00cf0000 SetWindowPos redraw #1 (0, 0, 5, 0): Update region shall match expected region
msg.c:9690: Test failed: 3 00cf0000 SetWindowPos redraw #2 (0, 0, 5, 5): Update region shall match expected region
msg.c:9690: Test failed: 3 00cf0000 SetWindowPos redraw #3 (0, 0, -5, -5): Update region shall match expected region
msg.c:9690: Test failed: 3 00cf0000 SetWindowPos redraw #4 (-5, -5, 0, 5): Update region shall match expected region
msg.c:9690: Test failed: 3 00cf0000 SetWindowPos redraw #5 (-5, -5, 5, 0): Update region shall match expected region
msg.c:9690: Test failed: 3 00cf0000 SetWindowPos redraw #6 (-5, -5, 5, 5): Update region shall match expected region
msg.c:9690: Test failed: 2 40800000 SetWindowPos redraw #0 (0, 0, 0, 5): Update region shall match expected region
msg.c:9690: Test failed: 2 40800000 SetWindowPos redraw #1 (0, 0, 5, 0): Update region shall match expected region
msg.c:9690: Test failed: 2 40800000 SetWindowPos redraw #2 (0, 0, 5, 5): Update region shall match expected region
msg.c:9690: Test failed: 2 40800000 SetWindowPos redraw #3 (0, 0, -5, -5): Update region shall match expected region
msg.c:9690: Test failed: 2 40800000 SetWindowPos redraw #4 (-5, -5, 0, 5): Update region shall match expected region
msg.c:9690: Test failed: 2 40800000 SetWindowPos redraw #5 (-5, -5, 5, 0): Update region shall match expected region
msg.c:9690: Test failed: 2 40800000 SetWindowPos redraw #6 (-5, -5, 5, 5): Update region shall match expected region
msg.c:9690: Test failed: 1 40800000 SetWindowPos redraw #0 (0, 0, 0, 5): Update region shall match expected region
msg.c:9690: Test failed: 1 40800000 SetWindowPos redraw #1 (0, 0, 5, 0): Update region shall match expected region
msg.c:9690: Test failed: 1 40800000 SetWindowPos redraw #2 (0, 0, 5, 5): Update region shall match expected region
msg.c:9690: Test failed: 1 40800000 SetWindowPos redraw #3 (0, 0, -5, -5): Update region shall match expected region
msg.c:9690: Test failed: 1 40800000 SetWindowPos redraw #4 (-5, -5, 0, 5): Update region shall match expected region
msg.c:9690: Test failed: 1 40800000 SetWindowPos redraw #5 (-5, -5, 5, 0): Update region shall match expected region
msg.c:9690: Test failed: 1 40800000 SetWindowPos redraw #6 (-5, -5, 5, 5): Update region shall match expected region
msg.c:9690: Test failed: 3 40800000 SetWindowPos redraw #0 (0, 0, 0, 5): Update region shall match expected region
msg.c:9690: Test failed: 3 40800000 SetWindowPos redraw #1 (0, 0, 5, 0): Update region shall match expected region
msg.c:9690: Test failed: 3 40800000 SetWindowPos redraw #2 (0, 0, 5, 5): Update region shall match expected region
msg.c:9690: Test failed: 3 40800000 SetWindowPos redraw #3 (0, 0, -5, -5): Update region shall match expected region
msg.c:9690: Test failed: 3 40800000 SetWindowPos redraw #4 (-5, -5, 0, 5): Update region shall match expected region
msg.c:9690: Test failed: 3 40800000 SetWindowPos redraw #5 (-5, -5, 5, 0): Update region shall match expected region
msg.c:9690: Test failed: 3 40800000 SetWindowPos redraw #6 (-5, -5, 5, 5): Update region shall match expected region
msg.c:10126: Test failed: destroy child on thread exit: 1: the msg sequence is not complete: expected msg 000f - actual msg 0000
msg.c:12708: Test failed: Got expected 0.
msg.c:13009: Test failed: WmDispatchPaint: 3: the msg sequence is not complete: expected msg 0014 - actual msg 0000
msg: Timeout

Report validation errors:
user32:msg prints too much data (48165 bytes)

=== debian11 (32 bit report) ===

comctl32:
taskdialog.c:597: Test failed: default radio button: radio button after clicking: in msg 0x8000 expecting wParam 0x1 got 0x28
taskdialog.c:597: Test failed: default radio button: radio button after clicking: in msg 0x8000 expecting id 2 got 6
taskdialog.c:597: Test failed: default radio button: radio button after clicking: in msg 0x8000 expecting wParam 0x0 got 0x1
taskdialog.c:597: Test failed: default radio button: radio button after clicking: in msg 0x8000 expecting id 5 got 2
taskdialog.c:597: Test failed: default radio button: radio button after clicking: the msg sequence is not complete: expected 0000 - actual 8000
taskdialog.c:627: Test failed: radio button: manually click radio button with negative id: in msg 0x8000 expecting wParam 0x1 got 0xfffffffe
taskdialog.c:627: Test failed: radio button: manually click radio button with negative id: in msg 0x8000 expecting id 2 got 6
taskdialog.c:627: Test failed: radio button: manually click radio button with negative id: in msg 0x8000 expecting wParam 0x0 got 0x1
taskdialog.c:627: Test failed: radio button: manually click radio button with negative id: in msg 0x8000 expecting id 5 got 2
taskdialog.c:627: Test failed: radio button: manually click radio button with negative id: the msg sequence is not complete: expected 0000 - actual 8000

user32:
input.c:5855: Test failed: got pos (49,51)

=== debian11b (64 bit WoW report) ===

comctl32:
taskdialog.c:597: Test failed: default radio button: radio button after clicking: in msg 0x8000 expecting wParam 0x1 got 0x28
taskdialog.c:597: Test failed: default radio button: radio button after clicking: in msg 0x8000 expecting id 2 got 6
taskdialog.c:597: Test failed: default radio button: radio button after clicking: in msg 0x8000 expecting wParam 0x0 got 0x1
taskdialog.c:597: Test failed: default radio button: radio button after clicking: in msg 0x8000 expecting id 5 got 2
taskdialog.c:597: Test failed: default radio button: radio button after clicking: the msg sequence is not complete: expected 0000 - actual 8000
taskdialog.c:627: Test failed: radio button: manually click radio button with negative id: in msg 0x8000 expecting wParam 0x1 got 0xfffffffffffffffe
taskdialog.c:627: Test failed: radio button: manually click radio button with negative id: in msg 0x8000 expecting id 2 got 6
taskdialog.c:627: Test failed: radio button: manually click radio button with negative id: in msg 0x8000 expecting wParam 0x0 got 0x1
taskdialog.c:627: Test failed: radio button: manually click radio button with negative id: in msg 0x8000 expecting id 5 got 2
taskdialog.c:627: Test failed: radio button: manually click radio button with negative id: the msg sequence is not complete: expected 0000 - actual 8000

[Fabian Maurer (＠DarkShadow44)]

Any news?

[Zhiyi Zhang (＠zhiyi)]

On Tue Nov 12 00:48:23 2024 +0000, Fabian Maurer wrote:
> Any news?

The CI test stage has some radio button failures that seem related.

[Fabian Maurer (＠DarkShadow44)]

On Tue Nov 12 00:48:23 2024 +0000, Zhiyi Zhang wrote:
> The CI test stage has some radio button failures that seem related.

Thanks, I must have missed that - I'm on it but it's not ready yet.