Re: [PATCH v2 0/6] MR1682: d3dx9: Partially implement texture filling using texture shaders.

[Matteo Bruni (＠Mystral)]

Matteo Bruni (@Mystral) commented about dlls/d3dx9_36/shader.c:
> - *(inputs++) = 0.0f;
> - *(inputs++) = 0.0f;
> -
> - param.type = D3DXPT_FLOAT;
> - param.bytes = 4 * sizeof(float);
> - d3dx_evaluate_parameter(shader->eval, &param, out);
>
> +}
> -
>
> +HRESULT WINAPI D3DXFillTextureTX(struct IDirect3DTexture9 *texture, ID3DXTextureShader *texture_shader)
> +{
> - struct d3dx9_texture_shader *shader = unsafe_impl_from_ID3DXTextureShader(texture_shader);
> -
> - TRACE("texture %p, texture_shader %p.\n", texture, texture_shader);
> -
> - return D3DXFillTexture(texture, texture_shader_fill_2d, shader);
>
> +}

This doesn't look too great at the first sight but, thinking about it, I don't really see any clearly nicer alternative.

Which is to say, this is probably fine :D