Re: [PATCH v2 0/1] MR4043: uxtheme: add some ordinals to spec file needed by Captvty

[Gabriel Ivăncescu (＠insn)]

On Tue Oct 10 14:26:32 2023 +0000, Louis Lenders wrote:
> Well, I don't know about coders etiquette but at the organization I work
> it's not rude to ask an expert to fix a problem...  Anyway I fixed up a
> test, and Ill reopen the bug. @zhiyi, could you have a look at patch
> below? I'm attaching it as a patch for now as I don't want to go through
> gitlab horror again.
> diff --git a/dlls/uxtheme/tests/system.c b/dlls/uxtheme/tests/system.c
> index 2e769625dab..0c1a1b28fee 100644
> --- a/dlls/uxtheme/tests/system.c
> +++ b/dlls/uxtheme/tests/system.c
> @@ -285,6 +285,31 @@ static LRESULT WINAPI
> TestSetWindowThemeChildProcA(HWND hwnd, UINT message, WPAR
>      return ret;
>  }
>
> +static void test_ordinals(void)
> +{
> - void *proc;
> - int i;
> - HMODULE uxtheme = GetModuleHandleA("uxtheme.dll");
> - static const struct
> - {
> -
>    const char *name;
> -
>    int ordinal;
> - }
> - func[] =
> - {
> -
>    {"DrawThemeBackgroundEx", 47},
> -
>    {"IsThemeDialogTextureEnabled", 132},
> -
>    {"IsThemePartDefined", 133},
> -
>    {"SetThemeAppProperties", 135}
> - };
> -
> - for (i = 0; i < ARRAY_SIZE(func); i++)
> - {
> -
>    proc = GetProcAddress(uxtheme, MAKEINTRESOURCEA(func->ordinal));
> -
>    ok(proc == GetProcAddress(uxtheme, func->name), "Expected %s at
>
> ordinal %u\n", func->name, func->ordinal);
> - }
>
> +}
> -
>
> static void test_IsThemed(void)
>  {
>      BOOL bThemeActive;
> @@ -2605,6 +2630,7 @@ START_TEST(system)
>      init_funcs();
>      init_msg_sequences(sequences, NUM_MSG_SEQUENCES);
> - test_ordinals();
> test_IsThemed();
> test_IsThemePartDefined();
> test_GetWindowTheme();

You don't have to go through gitlab horror again, just force push to
your branch with git with updated local branch.