[PATCH v2 0/1] MR6087: iphlpapi: Add stub for SetCurrentThreadCompartmentId.

[Fabian Maurer (＠DarkShadow44)]

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56494

--
  v2: iphlpapi: Add stub for SetCurrentThreadCompartmentId.

https://gitlab.winehq.org/wine/wine/-/merge_requests/6087

[PATCH v2 1/1] iphlpapi: Add stub for SetCurrentThreadCompartmentId.

[Fabian Maurer]

From: Fabian Maurer

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56494
---
 dlls/iphlpapi/iphlpapi.spec   | 2 +-
 dlls/iphlpapi/iphlpapi_main.c | 9 +++++++++
 include/netioapi.h            | 1 +
 3 files changed, 11 insertions(+), 1 deletion(-)

diff --git a/dlls/iphlpapi/iphlpapi.spec b/dlls/iphlpapi/iphlpapi.spec
index dcc15a2753e..facb52e0448 100644
--- a/dlls/iphlpapi/iphlpapi.spec
+++ b/dlls/iphlpapi/iphlpapi.spec
@@ -268,7 +268,7 @@
 @ stdcall SendARP( long long ptr ptr )
 @ stub SetAdapterIpAddress
 @ stub SetBlockRoutes
-#@ stub SetCurrentThreadCompartmentId
+@ stdcall SetCurrentThreadCompartmentId( long )
 @ stdcall SetIfEntry( ptr )
 @ stub SetIfEntryToStack
 #@ stub SetIpForwardEntry2
diff --git a/dlls/iphlpapi/iphlpapi_main.c b/dlls/iphlpapi/iphlpapi_main.c
index 85048f7a026..f5f2ed4b423 100644
--- a/dlls/iphlpapi/iphlpapi_main.c
+++ b/dlls/iphlpapi/iphlpapi_main.c
@@ -4824,3 +4824,12 @@ NET_IF_COMPARTMENT_ID WINAPI GetCurrentThreadCompartmentId( void )
     FIXME( "stub\n" );
     return NET_IF_COMPARTMENT_ID_PRIMARY;
 }
+
+/***********************************************************************
+ *    SetCurrentThreadCompartmentId (IPHLPAPI.@)
+ */
+DWORD WINAPI SetCurrentThreadCompartmentId( NET_IF_COMPARTMENT_ID reserved )
+{
+    FIXME( "stub\n" );
+    return 0;
+}
diff --git a/include/netioapi.h b/include/netioapi.h
index f49c670dac6..4e8a3f4eca0 100644
--- a/include/netioapi.h
+++ b/include/netioapi.h
@@ -270,6 +270,7 @@ IPHLPAPI_DLL_LINKAGE DWORD WINAPI ConvertLengthToIpv4Mask(ULONG,ULONG*);
 IPHLPAPI_DLL_LINKAGE void WINAPI FreeMibTable(void*);
 IPHLPAPI_DLL_LINKAGE DWORD WINAPI GetAnycastIpAddressTable(ADDRESS_FAMILY,MIB_ANYCASTIPADDRESS_TABLE**);
 IPHLPAPI_DLL_LINKAGE NET_IF_COMPARTMENT_ID WINAPI GetCurrentThreadCompartmentId(void);
+IPHLPAPI_DLL_LINKAGE DWORD WINAPI SetCurrentThreadCompartmentId(NET_IF_COMPARTMENT_ID);
 IPHLPAPI_DLL_LINKAGE DWORD WINAPI GetIfEntry2(MIB_IF_ROW2*);
 IPHLPAPI_DLL_LINKAGE DWORD WINAPI GetIfEntry2Ex(MIB_IF_TABLE_LEVEL,MIB_IF_ROW2*);
 IPHLPAPI_DLL_LINKAGE DWORD WINAPI GetIfTable2(MIB_IF_TABLE2**);

[PATCH v2 1/1] iphlpapi: Add stub for SetCurrentThreadCompartmentId.

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=147488

Your paranoid android.

=== debian11b (64 bit WoW report) ===

Report validation errors:
mshtml:script crashed (c0000005)

[Fabian Maurer (＠DarkShadow44)]

On Thu Aug  1 16:12:20 2024 +0000, Huw Davies wrote:
> Could we add the prototype to `netioapi.h` please?

Thanks for the review, I pushed an update.