Re: [PATCH v20 0/14] MR3938: winegstreamer: Implement CLSID_CMpegVideoCodec

[Zebediah Figura (＠zfigura)]

Zebediah Figura (@zfigura) commented about dlls/winegstreamer/quartz_parser.c:
> {
> - FIXME("iface %p, index %ld, mt %p, flags %p, lcid %p, group %p, name %p, object %p, unknown %p, stub!\n",
> -
>        iface, index, mt, flags, lcid, group, name, object, unknown);
> - return E_NOTIMPL;
> - struct parser *filter = impl_from_IAMStreamSelect(iface);
> - wg_parser_stream_t stream = wg_parser_get_stream(filter->wg_parser, index);
> - HRESULT hr = S_OK;
> -
> - FIXME("filter %p, index %ld, mt %p, flags %p, lcid %p, group %p, name %p, object %p, unknown %p, semi-stub!\n",
> -
>        filter, index, mt, flags, lcid, group, name, object, unknown);
> - EnterCriticalSection(&filter->filter.filter_cs);
> -
> - if (!filter->sink.pin.peer)
> -
>    return VFW_E_NOT_CONNECTED;
> - if (index < 0 || index >= wg_parser_get_stream_count(filter->wg_parser))
> -
>    return S_FALSE;

We need to leave the CS on these return paths.