[PATCH v2 0/1] MR7158: wine.inf.in: Add UBR key

[Etaash Mathamsetty (＠etaash.mathamsetty)]

Required by Logitech G Hub

--
  v2: wine.inf.in: Add UBR key.

https://gitlab.winehq.org/wine/wine/-/merge_requests/7158

[PATCH v2 1/1] wine.inf.in: Add UBR key.

[Etaash Mathamsetty]

From: Etaash Mathamsetty

---
 loader/wine.inf.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/loader/wine.inf.in b/loader/wine.inf.in
index e3426b7ec95..cd007fc45a3 100644
--- a/loader/wine.inf.in
+++ b/loader/wine.inf.in
@@ -2529,6 +2529,7 @@ HKLM,%CurrentVersionNT%,"CurrentMajorVersionNumber",0x10003,10
 HKLM,%CurrentVersionNT%,"CurrentMinorVersionNumber",0x10003,0
 HKLM,%CurrentVersionNT%,"CurrentBuild",2,"19043"
 HKLM,%CurrentVersionNT%,"CurrentBuildNumber",2,"19043"
+HKLM,%CurrentVersionNT%,"UBR",0x10003,1165
 HKLM,%CurrentVersionNT%,"CurrentType",2,"Multiprocessor Free"
 HKLM,%CurrentVersionNT%,"DigitalProductId",1,00,00,00,00,00,00,00,00,00,00,00,\
 00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,\

[Paul Gofman (＠gofman)]

Paul Gofman (@gofman) commented about loader/wine.inf.in:
> HKLM,%CurrentVersionNT%,"CurrentMinorVersionNumber",0x10003,0
>  HKLM,%CurrentVersionNT%,"CurrentBuild",2,"19043"
>  HKLM,%CurrentVersionNT%,"CurrentBuildNumber",2,"19043"
> +HKLM,%CurrentVersionNT%,"UBR",0x10003,1165

Do we need FLG_ADDREG_NOCLOBBER here (0x2 in 0x10003)? Doesn't really matter on first addition of the value, but then when the value is bumped this flag is going to keep the value first time set up in Wine prefix.

Here in Proton (https://github.com/ValveSoftware/wine/commit/4b426217e7eae17388b44027dd21a74...) I recently added the same field without FWIW.

[Etaash Mathamsetty (＠etaash.mathamsetty)]

On Mon Jan 20 21:24:30 2025 +0000, Paul Gofman wrote:
> Do we need FLG_ADDREG_NOCLOBBER here (0x2 in 0x10003)? Doesn't really
> matter on first addition of the value, but then when the value is bumped
> this flag is going to keep the value first time set up in Wine prefix.
> Here in Proton
> (https://github.com/ValveSoftware/wine/commit/4b426217e7eae17388b44027dd21a74...)
> I recently added the same field without FWIW.

I added it because I didn't want the value to be overwritten from whatever the user set, but I might have misinterpreted what the flag does.

[Paul Gofman (＠gofman)]

On Mon Jan 20 22:30:23 2025 +0000, Etaash Mathamsetty wrote:
> I added it because I didn't want the value to be overwritten from
> whatever the user set, but maybe I have misinterpreted what the flag does.

User can always set this over, the flag only affects what happens during prefix upgrade (the related code is in setupapi/install.c:do_reg_operation()).