On Fri Jan 19 22:20:33 2024 +0000, Krzysztof Bogacki wrote:
While two separate Windows machines on which I queried the size of array to allocate did return 32, this number isn't something that's documented anywhere and probably shouldn't be relied on directly. I can add a test that checks that `NumAdapters` is always set to `32` if `pAdapters` is `NULL` and it might even pass on most if not all Windows versions currently out there but Microsoft could one day decide that in such cases `64` should now be returned and there would be nothing wrong with that… or so I believe. Otherwise, this is already tested by first `ok(enum_adapters_2_desc.NumAdapters, "Expect not zero.\n");`, although not very strictly. I'm also not sure what would Windows return on systems with more than 32 adapters. Can Windows even support that many GPUs at the same time?
Let's make the test stricter by comparing it to 32. If the test fails one day, we can enlarge the number.
-
Zhiyi Zhang (＠zhiyi)