[PATCH 0/2] MR2791: imm32: Move ImeSetCompositionString from the drivers.

[PATCH 1/2] winex11: Use the default IME implementation for ImeSetCompositionString.

[Rémi Bernon]

From: Rémi Bernon

---
 dlls/imm32/ime.c                  | 64 ++++++++++++++++++++++++++--
 dlls/winex11.drv/ime.c            | 70 +------------------------------
 dlls/winex11.drv/winex11.drv.spec |  1 -
 3 files changed, 61 insertions(+), 74 deletions(-)

diff --git a/dlls/imm32/ime.c b/dlls/imm32/ime.c
index 44b1173b1db..b31f46ed9f6 100644
--- a/dlls/imm32/ime.c
+++ b/dlls/imm32/ime.c
@@ -97,6 +97,42 @@ static void input_context_reset_comp_str( INPUTCONTEXT *ctx )
     }
 }

+static void input_context_set_comp_str( INPUTCONTEXT *ctx, const WCHAR *str, UINT len )
+{
+    COMPOSITIONSTRING *compstr;
+    BYTE *dst;
+
+    if (!(compstr = ImmLockIMCC( ctx->hCompStr )))
+        WARN( "Failed to lock input context composition string\n" );
+    else
+    {
+        memset( compstr, 0, sizeof(*compstr) );
+        compstr->dwSize = sizeof(*compstr);
+        compstr->dwCursorPos = len;
+
+        compstr->dwCompStrLen = len;
+        compstr->dwCompStrOffset = compstr->dwSize;
+        dst = (BYTE *)compstr + compstr->dwCompStrOffset;
+        memcpy( dst, str, compstr->dwCompStrLen * sizeof(WCHAR) );
+        compstr->dwSize += compstr->dwCompStrLen * sizeof(WCHAR);
+
+        compstr->dwCompClauseLen = 2 * sizeof(DWORD);
+        compstr->dwCompClauseOffset = compstr->dwSize;
+        dst = (BYTE *)compstr + compstr->dwCompClauseOffset;
+        *((DWORD *)dst + 0) = 0;
+        *((DWORD *)dst + 1) = compstr->dwCompStrLen;
+        compstr->dwSize += compstr->dwCompClauseLen;
+
+        compstr->dwCompAttrLen = compstr->dwCompStrLen;
+        compstr->dwCompAttrOffset = compstr->dwSize;
+        dst = (BYTE *)compstr + compstr->dwCompAttrOffset;
+        memset( dst, ATTR_INPUT, compstr->dwCompAttrLen );
+        compstr->dwSize += compstr->dwCompAttrLen;
+
+        ImmUnlockIMCC( ctx->hCompStr );
+    }
+}
+
 static HFONT input_context_select_ui_font( INPUTCONTEXT *ctx, HDC hdc )
 {
     struct ime_private *priv;
@@ -437,10 +473,30 @@ DWORD WINAPI ImeConversionList( HIMC himc, const WCHAR *source, CANDIDATELIST *d
 BOOL WINAPI ImeSetCompositionString( HIMC himc, DWORD index, const void *comp, DWORD comp_len,
                                      const void *read, DWORD read_len )
 {
-    FIXME( "himc %p, index %lu, comp %p, comp_len %lu, read %p, read_len %lu stub!\n",
-           himc, index, comp, comp_len, read, read_len );
-    SetLastError( ERROR_CALL_NOT_IMPLEMENTED );
-    return FALSE;
+    INPUTCONTEXT *ctx;
+
+    FIXME( "himc %p, index %lu, comp %p, comp_len %lu, read %p, read_len %lu semi-stub!\n",
+            himc, index, comp, comp_len, read, read_len );
+    if (read && read_len) FIXME( "Read string unimplemented\n" );
+    if (index != SCS_SETSTR && index != SCS_CHANGECLAUSE && index != SCS_CHANGEATTR) return FALSE;
+
+    if (!(ctx = ImmLockIMC( himc ))) return FALSE;
+
+    if (index != SCS_SETSTR)
+        FIXME( "index %#lx not implemented\n", index );
+    else
+    {
+        UINT flags = GCS_COMPSTR | GCS_COMPCLAUSE | GCS_COMPATTR | GCS_DELTASTART | GCS_CURSORPOS;
+        const WCHAR *str = comp;
+
+        input_context_set_comp_str( ctx, comp, comp_len / sizeof(WCHAR) );
+        ime_set_composition_status( himc, TRUE );
+        ime_send_message( himc, WM_IME_COMPOSITION, str ? str[0] : 0, flags );
+    }
+
+    ImmUnlockIMC( himc );
+
+    return TRUE;
 }

BOOL WINAPI NotifyIME( HIMC himc, DWORD action, DWORD index, DWORD value )
diff --git a/dlls/winex11.drv/ime.c b/dlls/winex11.drv/ime.c
index 3cc73c3974c..b46c2d86892 100644
--- a/dlls/winex11.drv/ime.c
+++ b/dlls/winex11.drv/ime.c
@@ -529,74 +529,6 @@ UINT WINAPI ImeToAsciiEx (UINT uVKey, UINT uScanCode, const LPBYTE lpbKeyState,
     return 0;
 }

-BOOL WINAPI ImeSetCompositionString(HIMC hIMC, DWORD dwIndex, LPCVOID lpComp,
-                                    DWORD dwCompLen, LPCVOID lpRead,
-                                    DWORD dwReadLen)
-{
-    LPINPUTCONTEXT lpIMC;
-    DWORD flags = 0;
-    WCHAR wParam  = 0;
-
-    TRACE("(%p, %ld, %p, %ld, %p, %ld):\n",
-         hIMC, dwIndex, lpComp, dwCompLen, lpRead, dwReadLen);
-
-
-    if (hIMC != FROM_X11)
-        FIXME("PROBLEM: This only sets the wine level string\n");
-
-    /*
-    * Explanation:
-    *  this sets the composition string in the imm32.dll level
-    *  of the composition buffer. we cannot manipulate the xim level
-    *  buffer, which means that once the xim level buffer changes again
-    *  any call to this function from the application will be lost
-    */
-
-    if (lpRead && dwReadLen)
-        FIXME("Reading string unimplemented\n");
-
-    lpIMC = LockRealIMC(hIMC);
-
-    if (lpIMC == NULL)
-        return FALSE;
-
-    if (dwIndex == SCS_SETSTR)
-    {
-        HIMCC newCompStr;
-
-        ime_set_composition_status( hIMC, TRUE );
-
-        /* clear existing result */
-        newCompStr = updateResultStr(lpIMC->hCompStr, NULL, 0);
-        ImmDestroyIMCC(lpIMC->hCompStr);
-        lpIMC->hCompStr = newCompStr;
-
-        flags = GCS_COMPSTR;
-
-        if (dwCompLen && lpComp)
-        {
-            newCompStr = updateCompStr(lpIMC->hCompStr, (LPCWSTR)lpComp, dwCompLen / sizeof(WCHAR));
-            ImmDestroyIMCC(lpIMC->hCompStr);
-            lpIMC->hCompStr = newCompStr;
-
-             wParam = ((const WCHAR*)lpComp)[0];
-             flags |= GCS_COMPCLAUSE | GCS_COMPATTR | GCS_DELTASTART;
-        }
-        else
-        {
-            newCompStr = updateCompStr(lpIMC->hCompStr, NULL, 0);
-            ImmDestroyIMCC(lpIMC->hCompStr);
-            lpIMC->hCompStr = newCompStr;
-        }
-    }
-
-    GenerateIMEMessage(hIMC, WM_IME_COMPOSITION, wParam, flags);
-    ImmUnlockIMCC(lpIMC->hPrivate);
-    UnlockRealIMC(hIMC);
-
-    return TRUE;
-}
-
 /* Interfaces to XIM and other parts of winex11drv */

NTSTATUS x11drv_ime_set_open_status( UINT open )
@@ -693,7 +625,7 @@ NTSTATUS x11drv_ime_update_association( UINT arg )

NTSTATUS WINAPI x11drv_ime_set_composition_string( void *param, ULONG size )
 {
-    return ImeSetCompositionString(FROM_X11, SCS_SETSTR, param, size, NULL, 0);
+    return ImmSetCompositionStringW( RealIMC(FROM_X11), SCS_SETSTR, param, size, NULL, 0 );
 }

NTSTATUS WINAPI x11drv_ime_set_result( void *params, ULONG len )
diff --git a/dlls/winex11.drv/winex11.drv.spec b/dlls/winex11.drv/winex11.drv.spec
index da502c4832e..64154d709a2 100644
--- a/dlls/winex11.drv/winex11.drv.spec
+++ b/dlls/winex11.drv/winex11.drv.spec
@@ -13,5 +13,4 @@
 #IME Interface
 @ stdcall ImeSelect(long long)
 @ stdcall ImeToAsciiEx(long long ptr ptr long long)
-@ stdcall ImeSetCompositionString(long long ptr long ptr long)
 @ stdcall ImeProcessKey(long long long ptr)

[PATCH 2/2] winemac: Use the default IME implementation for ImeSetCompositionString.

[Rémi Bernon]

From: Rémi Bernon

---
 dlls/winemac.drv/ime.c            | 11 -----------
 dlls/winemac.drv/winemac.drv.spec |  1 -
 2 files changed, 12 deletions(-)

diff --git a/dlls/winemac.drv/ime.c b/dlls/winemac.drv/ime.c
index 668a0ecd6ac..681d93d1e43 100644
--- a/dlls/winemac.drv/ime.c
+++ b/dlls/winemac.drv/ime.c
@@ -727,17 +727,6 @@ static BOOL IME_SetCompositionString(void* hIMC, DWORD dwIndex, LPCVOID lpComp,
     return TRUE;
 }

-BOOL WINAPI ImeSetCompositionString(HIMC hIMC, DWORD dwIndex, LPCVOID lpComp, DWORD dwCompLen,
-                                    LPCVOID lpRead, DWORD dwReadLen)
-{
-    TRACE("(%p, %ld, %p, %ld, %p, %ld):\n", hIMC, dwIndex, lpComp, dwCompLen, lpRead, dwReadLen);
-
-    if (lpRead && dwReadLen)
-        FIXME("Reading string unimplemented\n");
-
-    return IME_SetCompositionString(hIMC, dwIndex, lpComp, dwCompLen, 0, FALSE);
-}
-
 static void IME_NotifyComplete(void* hIMC)
 {
     ImmNotifyIME(hIMC, NI_COMPOSITIONSTR, CPS_COMPLETE, 0);
diff --git a/dlls/winemac.drv/winemac.drv.spec b/dlls/winemac.drv/winemac.drv.spec
index 5a9403c3cf5..aca1c58cf13 100644
--- a/dlls/winemac.drv/winemac.drv.spec
+++ b/dlls/winemac.drv/winemac.drv.spec
@@ -4,5 +4,4 @@
 # IME
 @ stdcall ImeProcessKey(long long long ptr)
 @ stdcall ImeSelect(long long)
-@ stdcall ImeSetCompositionString(long long ptr long ptr long)
 @ stdcall ImeToAsciiEx(long long ptr ptr long long)

[PATCH 2/2] winemac: Use the default IME implementation for ImeSetCompositionString.

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=132585

Your paranoid android.

=== debian11 (32 bit report) ===

imm32:
Unhandled exception: page fault on read access to 0x00000000 in 32-bit code (0x67503515).

user32:
Unhandled exception: page fault on write access to 0x00882358 in 32-bit code (0x7bc4d497).

=== debian11 (32 bit zh:CN report) ===

imm32:
Unhandled exception: page fault on read access to 0x00000000 in 32-bit code (0x67503515).

=== debian11b (64 bit WoW report) ===

imm32:
Unhandled exception: page fault on read access to 0x0000000000000000 in 64-bit code (0x00000064a034e7).