Re: [PATCH v4 0/6] MR2275: winewayland.drv: part 1: Introduce the Wayland driver

[Jacek Caban (＠jacek)]

Jacek Caban (@jacek) commented about dlls/winewayland.drv/wayland.c:
> +{
> - struct wl_display *wl_display_wrapper;
> -
> - TRACE("wayland=%p wl_display=%p\n", wayland, process_wl_display);
> -
> - wl_list_init(&wayland->thread_link);
> -
> - wayland->process_id = GetCurrentProcessId();
> - wayland->thread_id = GetCurrentThreadId();
> - wayland->wl_display = process_wl_display;
> -
> - if (!wayland->wl_display)
> - {
> -
>    ERR("Failed to connect to wayland compositor\n");
> -
>    return FALSE;
> - }

I think that this error condition can never happen, we fail to load the driver if process_wl_display is NULL. Also, if wl_display is always equal to process_wl_display, why do we need to store it in wayland struct?