In cases where MF is already shut down, simply forwarding MFShutdown() to RtwqShutdown() will corrupt the Rtwq lock count if async result objects still exist, because they hold a lock. JR East Train Simulator does this.
-- v2: mf: Release the sample if stream sink processing fails.
From: Conor McCarthy cmccarthy@codeweavers.com
--- dlls/mf/session.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/dlls/mf/session.c b/dlls/mf/session.c index 483ea6f904f..658c50c1d9b 100644 --- a/dlls/mf/session.c +++ b/dlls/mf/session.c @@ -3893,6 +3893,7 @@ static void session_deliver_sample_to_node(struct media_session *session, struct { WARN("Stream sink failed to process sample, hr %#lx.\n", hr); IMFMediaEventQueue_QueueEventParamVar(session->event_queue, MEError, &GUID_NULL, hr, NULL); + IMFSample_Release(sample); } } else if (FAILED(hr = IMFStreamSink_PlaceMarker(topo_node->object.sink_stream, MFSTREAMSINK_MARKER_ENDOFSEGMENT,
Hi,
It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated.
The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details:
The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=151154
Your paranoid android.
=== debian11b (64 bit WoW report) ===
mf: mf.c:6785: Test failed: Unexpected hr 0.
user32: input.c:4306: Test succeeded inside todo block: button_down_hwnd_todo 1: got MSG_TEST_WIN hwnd 00000000010000FC, msg WM_LBUTTONDOWN, wparam 0x1, lparam 0x320032
-
Conor McCarthy -
Conor McCarthy (＠cmccarthy)
-
Marvin