[PATCH v2 0/1] MR5568: windowscodecs: Avoid implicit cast changing value.

[Alistair Leslie-Hughes (＠alesliehughes)]

This appear to be introduced with commit 12f73ed9d851.

When This->stride is negative (bottom up image) it converts the multiplication to an UINT.
Thus causing the pointer to be incorrect when y > 0.

--
  v2: windowscodecs: Avoid implicit cast changing value.

https://gitlab.winehq.org/wine/wine/-/merge_requests/5568

[PATCH v2 1/1] windowscodecs: Avoid implicit cast changing value.

[Alistair Leslie-Hughes]

From: Alistair Leslie-Hughes

This appear to be introduced with commit 12f73ed9d851.

When This->stride is negative (bottom up image) it converts the multiplication to an UINT.
Thus causing the pointer to be incorrect when y > 0.
---
 dlls/windowscodecs/bmpdecode.c        | 2 +-
 dlls/windowscodecs/wincodecs_common.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/dlls/windowscodecs/bmpdecode.c b/dlls/windowscodecs/bmpdecode.c
index 9d4867447f0..ae6feda5b50 100644
--- a/dlls/windowscodecs/bmpdecode.c
+++ b/dlls/windowscodecs/bmpdecode.c
@@ -432,7 +432,7 @@ static HRESULT BmpFrameDecode_ReadABGRasBGR(BmpDecoder* This)
     {
         for (y = 0; y < height; y++)
         {
-            pixel = This->imagedatastart + This->stride * y;
+            pixel = This->imagedatastart + This->stride * (INT)y;

for (x = 0; x < width; x++)
             {
diff --git a/dlls/windowscodecs/wincodecs_common.h b/dlls/windowscodecs/wincodecs_common.h
index f56e91e1f54..dcccdc2e5f1 100644
--- a/dlls/windowscodecs/wincodecs_common.h
+++ b/dlls/windowscodecs/wincodecs_common.h
@@ -201,7 +201,7 @@ void reverse_bgr8(UINT bytesperpixel, LPBYTE bits, UINT width, UINT height, INT

for (y=0; y<height; y++)
     {
-        pixel = bits + stride * y;
+        pixel = bits + stride * (INT)y;

for (x=0; x<width; x++)
         {

[PATCH v2 1/1] windowscodecs: Avoid implicit cast changing value.

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=145347

Your paranoid android.

=== debian11b (64 bit WoW report) ===

wsdapi:
discovery.c:1078: Test failed: EndpointReference not received
discovery.c:1079: Test failed: AppSequence not received
discovery.c:1080: Test failed: MetadataVersion not received
discovery.c:1081: Test failed: Hello message metadata not received
discovery.c:1082: Test failed: Custom header not received
discovery.c:1083: Test failed: Wine namespace not received
discovery.c:1085: Test failed: Custom body element not received
discovery.c:1086: Test failed: Types not received
discovery.c:1087: Test failed: XML namespaces not received
discovery.c:1088: Test failed: Scopes not received
discovery.c:1089: Test failed: XAddrs not received

[PATCH v2 0/1] MR5568: windowscodecs: Avoid implicit cast changing value. - approved

[Esme Povirk (＠madewokherd)]

This merge request was approved by Esme Povirk.

[PATCH v2 0/1] MR5568: windowscodecs: Avoid implicit cast changing value. - approved

[Piotr Caban (＠piotr)]

This merge request was approved by Piotr Caban.