This is wine-7.0.1-rc1, so not ready yet to merge.
This merge request was approved by Michael Stefaniuc.
This merge request was approved by Piotr Caban.
This merge request was approved by Zhiyi Zhang.
I don't know how to make GitLab show me all the patches so I can review this properly.
@madewokherd indeed, the Commits tab is limiting to 100 patches and I didn't find a way to show the remaining 9. But you can click on the link from "Michael Stefaniuc requested to merge mstefani/wine:stable" and you can go to commits there. Or you can click on the blue "Code" button at the top and select "Check out branch".
This merge request was approved by Jacek Caban.
This merge request was approved by Esme Povirk.
Should I be reviewing this even though it's marked as a draft?
This merge request was approved by Nikolay Sivov.
This merge request was approved by Rémi Bernon.
On Tue Oct 11 23:00:00 2022 +0000, **** wrote:
Zebediah Figura replied on the mailing list:
Should I be reviewing this even though it's marked as a draft?
Yes please. Draft is only there to give people time to test and comment on -rc1. Based on the feedback there might be a -rc2 or -rc1 might become final.
This merge request was approved by Huw Davies.
This merge request was approved by Hans Leidekker.
This merge request was approved by Jan Sikorski.
This merge request was approved by Matteo Bruni.
I rebased Deere's wine builds onto 7.0.1-rc1 and the it looks good to me! Only thing missing was that `wine --version` still called itself 7.0, not 7.0.1-rc1, because PACKAGE_VERSION in configure wasn't changed. But that seems consistent with how older tags (like 6.0.1-rc1) were made; only the actually-final tags changed configure. So I assume that's intentional.
I did hit a very weird double-free crash on aarch64 (somehow involving CoUnintialize, but I didn't get a very usable backtrace). But after some digging it seems to be a rare threading race in our app code, not wine's fault. I was eventually able to provoke the same crash running on 7.0 as well, so it hasn't got anything to do with 7.0.1-rc1, we just have a bug in our app and it picked the run where I was testing 7.0.1 to finally show itself...
This merge request was approved by Zebediah Figura.
Just wondering why this isn't marked as ready yet? This leaves the repository for Ubuntu Jammy (and dists like Mint based on it) without a wine-stable package. Jammy was released 6 months ago.