I created some new test failures yesterday, sorry for that.
From: Sven Baars sbaars@codeweavers.com
--- dlls/taskschd/tests/scheduler.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/dlls/taskschd/tests/scheduler.c b/dlls/taskschd/tests/scheduler.c index 4e156e7ef33..6a356b5f259 100644 --- a/dlls/taskschd/tests/scheduler.c +++ b/dlls/taskschd/tests/scheduler.c @@ -783,7 +783,7 @@ static void test_GetTask(void)
/* Delete the folder and recreate it to prevent a crash on w1064v1507 */ hr = ITaskFolder_DeleteFolder(root, Wine, 0); - ok(hr == S_OK, "DeleteTask error %#lx\n", hr); + ITaskFolder_Release(folder);
hr = ITaskFolder_CreateFolder(root, Wine, v_null, &folder); ok(hr == S_OK, "CreateFolder error %#lx\n", hr);
Hi,
It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated.
The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details:
The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=127398
Your paranoid android.
=== w7u_adm (32 bit report) ===
taskschd: scheduler.c:802: Test failed: DeleteTask error 0x80070005 scheduler.c:798: Test failed: 1: expected 0, got 0x800700b7 scheduler.c:798: Test failed: 2: expected 0x80070002, got 0 scheduler.c:802: Test failed: DeleteTask error 0x80070005 scheduler.c:802: Test failed: DeleteTask error 0x80070005 scheduler.c:814: Test failed: RegisterTask error 0x800700b7 scheduler.c:960: Test failed: DeleteTask error 0x80070005 scheduler.c:962: Test failed: DeleteTask error 0x80070005 scheduler.c:965: Test failed: expected ERROR_FILE_NOT_FOUND, got 0x80070005
On Thu Dec 8 09:10:08 2022 +0000, **** wrote:
Marvin replied on the mailing list:
Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=127398 Your paranoid android. === w7u_adm (32 bit report) === taskschd: scheduler.c:802: Test failed: DeleteTask error 0x80070005 scheduler.c:798: Test failed: 1: expected 0, got 0x800700b7 scheduler.c:798: Test failed: 2: expected 0x80070002, got 0 scheduler.c:802: Test failed: DeleteTask error 0x80070005 scheduler.c:802: Test failed: DeleteTask error 0x80070005 scheduler.c:814: Test failed: RegisterTask error 0x800700b7 scheduler.c:960: Test failed: DeleteTask error 0x80070005 scheduler.c:962: Test failed: DeleteTask error 0x80070005 scheduler.c:965: Test failed: expected ERROR_FILE_NOT_FOUND, got 0x80070005
This machine has preexisting failures, so these are not relevant for merging this patch.
Zhiyi Zhang (@zhiyi) commented about dlls/taskschd/tests/scheduler.c:
/* Delete the folder and recreate it to prevent a crash on w1064v1507 */ hr = ITaskFolder_DeleteFolder(root, Wine, 0);
Assignment to hr can be deleted. Or maybe we can allow hr to be HRESULT_FROM_WIN32(ERROR_FILE_NOT_FOUND).
On Thu Dec 8 11:36:37 2022 +0000, Zhiyi Zhang wrote:
Assignment to hr can be deleted. Or maybe we can allow hr to be HRESULT_FROM_WIN32(ERROR_FILE_NOT_FOUND).
Right. My neighbours have been drilling in my wall all week and I keep missing all these small things :(.
-
Marvin -
Sven Baars -
Sven Baars (＠sbaars)
-
Zhiyi Zhang (＠zhiyi)