August 2008 - Wine-devel - list.winehq.org

Using wine directdraw dll on windows?
by Joseph Garvin 25 Aug '08

25 Aug '08

Intel's windows vista graphics drivers are pretty terrible, and some older directdraw games won't run at all with them. I know that there was talk before about using wine's opengl-based direct3d implementation on windows, so I was curious if it was at all possible to do the same with directdraw. Ironically Worms Armageddon runs better on my laptop under wine than it does on my gf's under Vista. Thanks, Joe

3 3

New steam survey statistics?
by Scott Ritchie 25 Aug '08

25 Aug '08

When we last heard from Valve a year ago, Wine had about a .4% share of the steam user base. It would be interesting to see how this has changed since then - in that time, we've both released Wine 1.0 and likely seen Linux adoption increase a great deal. Linux had doubled its desktop marketshare the year preceding the last survey, I wouldn't be surprised to see Wine usage at around 1% on steam now. Thanks, Scott Ritchie

4 5

Re: cryptnet: Sign-compare warning fix (try 2)
by Juan Lang 25 Aug '08

25 Aug '08

Hi Andy, + LONG last_error; ret = CryptGetObjectUrl(URL_OID_CERTIFICATE_CRL_DIST_POINT, rgpvContext[i], 0, NULL, &cbUrlArray, NULL, NULL, NULL); - if (!ret && GetLastError() == CRYPT_E_NOT_FOUND) + last_error = GetLastError(); + if (!ret && last_error == CRYPT_E_NOT_FOUND) I don't get it. How does using a temporary LONG rather than GetLastError directly remove the warning? Either the compiler was wrong about the first warning, or it's wrong about not warning about this form. I don't see the utility of this patch. Furthermore, any patches that remove warnings due to sign mismatches between GetLastError and an error in winerror.h reflect an error on Microsoft's part, not on Wine's, so I don't see the point of removing them. --Juan

2 4

Re: [3/3] d3dx9: Begin Implementation of ID3DXEffect and D3DXCreateEffectEx
by tony.wasserka＠freenet.de 25 Aug '08

25 Aug '08

Hi, > +HRESULT WINAPI D3DXCreateEffectEx(LPDIRECT3DDEVICE9 pdevice, LPCVOID psrcdata, UINT srcdatalen, D3DXMACRO *pdefines, > + LPD3DXINCLUDE pinclude, LPCSTR pskipconstants, DWORD flags, LPD3DXEFFECTPOOL ppool, LPD3DXEFFECT * ppeffect, > + LPD3DXBUFFER * ppcompilationerrors) > +{ > + ID3DXEffectImpl *This; > + This=(ID3DXEffectImpl *)malloc(sizeof(ID3DXEffectImpl)); > + This->lpVtbl=&ID3DXEffect_Vtbl; > + This->device=pdevice; > + return D3D_OK; > +} > + Don't use malloc for windows functions, use HeapAlloc for that. Also, you should do some error checking to make sure that the memory was allocated successfully, or this code will segfault. You forgot to assign the ppeffect pointer to This, i.e. *ppeffect=This. you'll need to check that ppeffect isn't NULL first, of course. At least ID3DXBaseEffectImpl_AddRef/Release/QueryInterface (well, actually only Release) need to be implemented in the same patch as the interface leaks memory otherwise (one more unnecessary valgrind error). Last thing, you need to AddRef the device when creating another reference to it, and Release it on ID3DXBaseEffectImpl_Release. (Though a device pointer isn't even neccessary yet, so you could also leave it away) Best regards, Tony Heute schon ge"freeMail"t? Jetzt kostenlose E-Mail-Adresse sichern! http://email.freenet.de/dienste/emailoffice/produktuebersicht/basic/mail/in…

1 0

RE: [try 3][1/2]wined3d: Support clipplanes with GLSL shaders
by Stefan Dösinger 25 Aug '08

25 Aug '08

+ if(gl_info->max_glsl_varyings > 32) + gl_info->max_glsl_varyings -= 4; + if(!apple && gl_info->gl_vendor == VENDOR_ATI && gl_info->max_glsl_varyings == 40) { + WARN("Hardcoded 32 varyings instead of 44 to avoid crashing the ATI driver\n"); + gl_info->max_glsl_varyings -= 4; + } This will give you 36 varyings, not 32. Is this intentional? > -----Original Message----- > From: wine-patches-bounces(a)winehq.org [mailto:wine-patches- > bounces(a)winehq.org] On Behalf Of Fabian Bieler > Sent: Monday, August 25, 2008 6:25 AM > To: wine-patches(a)winehq.org > Subject: [try 3][1/2]wined3d: Support clipplanes with GLSL shaders >

1 0

Re: d3dx9: Add stubs for D3DXCreateEffectxx and D3DXCreateEffectFromFilexx
by tony.wasserka＠freenet.de 24 Aug '08

24 Aug '08

Hi, There were quite a number of minor issues in you code: In Makefile.in: > C_SRCS = \ > d3dx9_36_main.c \ >+ effect.c \ > font.c \ Use tabs here, please, as the intendation switches here on other computers. In effect.c: + * modify it under the terms of the GNU Lesser General Public + GetCurre* License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. I guess that was a paste at the wrong position ;-) > +HRESULT D3DXCreateEffectEx( You missed the WINAPI for that one. In d3dx9effect.h: I haven't looked too much into the whole effect stuff, but this thing looks like Unicode isn't supported here (only LPCSTRs are used). Are you sure about that? >+#endif //__D3DX9EFFECT_H__ This is C code, use /* */, please. As David already said, you should split the patch into smaller chunks. Also, you need to convert a D3DXCreateEffect call into a D3DXCreateEffectEx call, look at font.c to see how it's done for D3DXCreateFont. This applies to the D3DXCreateEffectFromFile calls, too. Best regards, Tony Unbegrenzter Speicher, Top-Spamschutz, 120 SMS und eigene E-MailDomain inkl. http://office.freenet.de/dienste/emailoffice/produktuebersicht/power/mail/i…

1 0

Re: d3dx9: Add stubs for D3DXCreateEffectxx and D3DXCreateEffectFromFilexx
by Henri Verbeet 24 Aug '08

24 Aug '08

2008/8/24 Busquets Pérez Luis C. <luiscar2001(a)yahoo.es>: > Why are you adding stubs for these? I don't think having a stub implementation is useful here.

1 0

Re: d3dx9: Add stubs for D3DXCreateEffectxx and D3DXCreateEffectFromFilexx
by David Adam 24 Aug '08

24 Aug '08

Hello, A few remarks: 1) this patch is too huge You need to split it in several patches. I advice you to do a patch for - d3dx9effect.h -an another one for d3dx9shader.h -an another one for D3DXCreateEffect -an another one for D3DXCreateEffectExW and D3DXCreateEffectExW 2) for the patch D3DXCreateEffect you need to stub not only this function but also, all the methods coming with this function David

1 0

Re: [10/10] WineD3D: Sort out some limit confusion
by Henri Verbeet 24 Aug '08

24 Aug '08

2008/8/22 Stefan Dösinger <stefan(a)codeweavers.com>: > + glGetIntegerv(GL_MAX_TEXTURE_COORDS, &gl_max); > + gl_info->max_texture_coords = min(MAX_TEXTURES, gl_max); > + TRACE_(d3d_caps)("Max texture coords: %d\n", gl_info->max_texture_coords); I don't know if this is intentional or not, but did you mean to use gl_info->max_textures here? > @@ -3172,7 +3172,7 @@ static void loadTexCoords(IWineD3DStateBlockImpl *stateblock, WineDirect3DVertex > return; > } > > - for (textureNo = 0; textureNo < GL_LIMITS(texture_stages); ++textureNo) { > + for (textureNo = 0; textureNo < GL_LIMITS(texture_coords); ++textureNo) { > int coordIdx = stateblock->textureState[textureNo][WINED3DTSS_TEXCOORDINDEX]; > > mapped_stage = stateblock->wineD3DDevice->texUnitMap[textureNo]; Shouldn't that be testing mapped_stage against GL_LIMITS(texture_coords) instead? > - if (GL_SUPPORT(NV_REGISTER_COMBINERS)) { > - /* The number of the mapped stages increases monotonically, so it's fine to use the last used one */ > - for (textureNo = mapped_stage + 1; textureNo < GL_LIMITS(textures); ++textureNo) { > - GL_EXTCALL(glMultiTexCoord4fARB(GL_TEXTURE0_ARB + textureNo, 0, 0, 0, 1)); > - } > - } I'm probably missing something here, but why is it safe to remove that? > @@ -420,7 +420,7 @@ static void drawStridedSlow(IWineD3DDevice *iface, WineDirect3DVertexStridedData > } > > /* Texture coords --------------------------- */ > - for (textureNo = 0; textureNo < GL_LIMITS(texture_stages); ++textureNo) { > + for (textureNo = 0; textureNo < GL_LIMITS(texture_coords); ++textureNo) { > > if (!GL_SUPPORT(ARB_MULTITEXTURE) && textureNo > 0) { > FIXME("Program using multiple concurrent textures which this opengl implementation doesn't support\n"); Similar to above, shouldn't this test texture_idx against GL_LIMITS(texture_coords) instead of textureNo? In the bigger picture, these various limits are pretty tricky to get right, I wonder if it might make more sense to handle most of this stuff in the tex unit map instead. That way we could be sure that if a stage is mapped to a sampler that sampler is safe to use.

3 7

d3dx9: Effects
by Busquets Pérez Luis C. 24 Aug '08

24 Aug '08

What is wrong with the attached patch? __________________________________________________ Correo Yahoo! Espacio para todos tus mensajes, antivirus y antispam ¡gratis! Regístrate ya - http://correo.yahoo.es

1 0