August 2008 - Wine-devel - list.winehq.org

Re: [try 2][2/2]wined3d: Support first clipplane with ARB shaders
by Henri Verbeet 24 Aug '08

24 Aug '08

2008/8/24 Fabian Bieler <der.fabe(a)gmx.net>: > + if (use_vs(stateblock->wineD3DDevice) && (enable ^ supported_by_shader_backend) & enable) { Did you mean to write if (use_vs(stateblock->wineD3DDevice) && (enable & ~supported_by_shader_backend)) { there?

1 0

ddraw_test crashes on windows xp sp3 (blue screen)
by Rico Schüller 24 Aug '08

24 Aug '08

Hi, the attached patch solves a hard crash on my ati mobility 9600/9700 card. The code behind the c style comments let the application crash. The code between /* */ crash the hole system. Probably there have to be another check for supported cards/extensions. Cheers Rico diff --git a/dlls/ddraw/tests/d3d.c b/dlls/ddraw/tests/d3d.c index 221a95b..436a49c 100644 --- a/dlls/ddraw/tests/d3d.c +++ b/dlls/ddraw/tests/d3d.c @@ -2089,9 +2089,9 @@ static void DeviceLoadTest() ddsd.ddsCaps.dwCaps2 = DDSCAPS2_CUBEMAP | DDSCAPS2_CUBEMAP_POSITIVEX; ddsd.dwWidth = 128; ddsd.dwHeight = 128; - hr = IDirectDraw7_CreateSurface(lpDD, &ddsd, &cube_face_levels[0][0][0], NULL); - ok(hr==DD_OK,"CreateSurface returned: %x\n",hr); - if (FAILED(hr)) goto out; +// hr = IDirectDraw7_CreateSurface(lpDD, &ddsd, &cube_face_levels[0][0][0], NULL); +// ok(hr==DD_OK,"CreateSurface returned: %x\n",hr); +// if (FAILED(hr)) goto out; memset(&ddsd, 0, sizeof(DDSURFACEDESC2)); ddsd.dwSize = sizeof(ddsd); @@ -2100,13 +2100,13 @@ static void DeviceLoadTest() ddsd.ddsCaps.dwCaps2 = DDSCAPS2_CUBEMAP | DDSCAPS2_CUBEMAP_POSITIVEX | DDSCAPS2_CUBEMAP_POSITIVEY; ddsd.dwWidth = 128; ddsd.dwHeight = 128; - hr = IDirectDraw7_CreateSurface(lpDD, &ddsd, &cube_face_levels[1][0][0], NULL); - ok(hr==DD_OK,"CreateSurface returned: %x\n",hr); - if (FAILED(hr)) goto out; +// hr = IDirectDraw7_CreateSurface(lpDD, &ddsd, &cube_face_levels[1][0][0], NULL); +// ok(hr==DD_OK,"CreateSurface returned: %x\n",hr); +// if (FAILED(hr)) goto out; /* INVALIDPARAMS tests currently would fail because wine doesn't support partial cube faces (the above created cubemaps will have all faces. */ - hr = IDirect3DDevice7_Load(lpD3DDevice, cube_face_levels[0][0][0], NULL, cube_face_levels[1][0][0], NULL, +/* hr = IDirect3DDevice7_Load(lpD3DDevice, cube_face_levels[0][0][0], NULL, cube_face_levels[1][0][0], NULL, DDSCAPS2_CUBEMAP_ALLFACES); todo_wine ok(hr==DDERR_INVALIDPARAMS, "IDirect3DDevice7_Load returned: %x\n",hr); @@ -2132,6 +2132,7 @@ static void DeviceLoadTest() IDirectDrawSurface7_Release(cube_face_levels[0][0][0]); IDirectDrawSurface7_Release(cube_face_levels[1][0][0]); +*/ memset(cube_face_levels, 0, sizeof(cube_face_levels)); }

2 1

Re: d3dx8: Implementation of D3DXGetFVFVertexSize with tests try 2
by David Adam 24 Aug '08

24 Aug '08

Hello, could you keep the style of the file, please? For instance for (.....) { xxxxxxxx } instead of for (.....) { xxxxxxxx } The same for the if condition and the switch condition? David

1 0

Re: Unbreak dlls/winhttp on FreeBSD (and likely other BSDs/Darwin)
by Hans Leidekker 24 Aug '08

24 Aug '08

On Wednesday 20 August 2008 20:34:43 Gerald Pfeifer wrote: > This minor change on top of Hans' contributions in the recent days > unbreaks the build on FreeBSD (and likely other BSDs and possibly > Darwin/MacOS). Thanks. I didn't want to copy all of the ifdef blocks from wininet because I can't verify which ones are actually needed. So I'm counting on people like you to fix this up, and I'm sure I'll need your help again :) -Hans

2 1

How should I name the Traditional Chinese resource file ?
by Hongbo Ni 24 Aug '08

24 Aug '08

Hi, For Chinese language, there are simplified Chinese (zh_CN) and traditional Chinese (zh_TW) sublanguage. Currently all the dlls have Chinese resource named with xxx_Cn.rc for simplified, and xxx_Zh.rc for traditional Chinese. For all the programs such as notepage, simplified Chinese resource is named Zh.rc (while it should be named Cn.rc inline with dlls), and there is no traditional Chinese resource. I want to add traditional Chinese resources for all programs. I have those options: 1. name it Zh_tw.rc, (but Alexandre seems not like it) 2. name it Tw.rc 3. rename all Zh.rc to Cn.rc, then name traditional as Zh.rc 4. just put both simplified and traditional Chinese in Zh.rc (not good as they are different encoding). My question is how should I name it ? Hongbo Ni

1 0

Re: kernel32/winerr: Add Russian translation
by Dmitry Timoshkov 24 Aug '08

24 Aug '08

"Vladimir Pankratov" <scriptkid(a)mail.ru> wrote: > Added Russian translation. > > Changed files: > dlls/kernel32/nls/winerr_rus.mc > dlls/kernel32/kernel.rc > dlls/kernel32/Makefile.in Is there a reason you've used cp866 encoding instead of cp1251? Also, this doesn't look like a translation, messages don't match their english counterparts, how did you do that? -- Dmitry.

1 0

About patchwatcher
by Nikolay Sivov 23 Aug '08

23 Aug '08

Dan, am I right that Patchwatcher now runs a whole test suite for every patch? I know that this situation is rather rare but still I think it make sense to run only tests changed by patch if this patch contains only test changes. I could save some time without any side effect. Since all test stored in 'tests' directory for each module it's very easy to determine that a patch brings changes only to this directory without affecting module itself. What you think about this?

2 1

Re: [1/2] wined3d: Support clipplanes with GLSL shaders
by Henri Verbeet 23 Aug '08

23 Aug '08

> @@ -248,11 +248,12 @@ typedef struct { > void (*shader_generate_vshader)(IWineD3DVertexShader *iface, SHADER_BUFFER *buffer); > void (*shader_get_caps)(WINED3DDEVTYPE devtype, WineD3D_GL_Info *gl_info, struct shader_caps *caps); > BOOL (*shader_conv_supported)(WINED3DFORMAT conv); > + DWORD shader_supported_clipplanes; /* bitmask of supported clipplanes */ > } shader_backend_t; You shouldn't abuse the call table like that, you should store that flag in the private data instead.

1 0

Fwd: Patchwatcher: failed regression tests: d3dx8: replace loops with explicit computations to make them faster [PATCH] d3dx8: replace loops by explicit computations
by Dan Kegel 23 Aug '08

23 Aug '08

Patchwatcher notes that the conformance test fails here: ../../../tools/runtest -q -P wine -M d3dx8.dll -T ../../.. -p d3dx8_test.exe.so math.c && touch math.ok math.c:442: Test failed: Expected matrix= (-0.214800,1.311600,0.475200,0.000000 0.950400,-0.883600,0.924400,0.000000 1.021200,0.193600,-1.358800,0.000000 18.298500,-29.624001,15.683499,1.000000 ) Got matrix= (-0.214800,1.311600,0.475200,0.000000 0.950401,-0.883601,0.924400,0.000000 1.021204,0.193593,-1.358803,0.000000 18.298538,-29.624159,15.683425,1.000000) Looks like rounding errors, but one way or another, you have to take care of that. Also: did you benchmark this change to verify it actually made things faster? Unrolling loops is no longer as sure-fire a win as it used to be. I'm inclined to prefer the more compact, clear loop unless there's hard evidence it's > 1% slower. - Dan ---------- Forwarded message ---------- From: <patchwatcher(a)kegel.com> Date: Fri, Aug 22, 2008 at 8:35 PM Subject: Patchwatcher: failed regression tests: d3dx8: replace loops with explicit computations to make them faster [PATCH] d3dx8: replace loops by explicit computations To: dank(a)kegel.com Hi! This is the experimental automated wine patchwatcher thingy. The latest git sources were built and tested with your patch "d3dx8: replace loops with explicit computations to make them faster [PATCH] d3dx8: replace loops by explicit computations" Result: the patch failed regression tests. You can retrieve the full build results at http://kegel.com/wine/patchwatcher/results/264.log and see the patch as parsed at http://kegel.com/wine/patchwatcher/results/264.txt See http://kegel.com/wine/patchwatcher/results for more info.

2 2

Re: wined3d/d3d9: Set the initial scissor rect to the window size
by H. Verbeet 23 Aug '08

23 Aug '08

2008/8/21 Rico Schüller <kgbricola(a)web.de>: > + /* Set the scissor rect values */ > + scissor.left=0; > + scissor.right=ThisDevice->ddraw_width; > + scissor.top=0; > + scissor.bottom=ThisDevice->ddraw_height; > + IWineD3DDevice_SetScissorRect(device, &scissor); > + Are you sure you shouldn't be using the primary swapchain's backbuffer dimensions?

4 8