August 2008 - Wine-devel - list.winehq.org

Header file locations
by chengas123 26 Aug '08

26 Aug '08

Hi, I'm new to WINE and a bit rusty with C, so forgive me if my questions are a bit basic. I'm having trouble finding header files. For example, take a look at http://source.winehq.org/source/dlls/secur32/schannel.c There's a line that says '#include "schannel.h"', but I'm not sure where that file is. Thanks, Ben -- View this message in context: http://www.nabble.com/Header-file-locations-tp19174580p19174580.html Sent from the Wine - Devel mailing list archive at Nabble.com.

2 1

Re: (resend)systray: keep systray hidden when requested by moving itoff screen
by Dmitry Timoshkov 26 Aug '08

26 Aug '08

"Aric Stewart" <aric(a)codeweavers.com> wrote: > diff --git a/programs/explorer/systray.c b/programs/explorer/systray.c > index 8b82d9a..4a7e57e 100644 > --- a/programs/explorer/systray.c > +++ b/programs/explorer/systray.c > @@ -437,6 +437,19 @@ static LRESULT WINAPI tray_wndproc( HWND hwnd, UINT msg, WPARAM wparam, LPARAM l > case WM_COPYDATA: > return handle_incoming((HWND)wparam, (COPYDATASTRUCT *)lparam); > > + case WM_DISPLAYCHANGE: > + if (hide_systray) > + { > + int offscreen; > + SIZE size; > + size = get_window_size(); > + offscreen = GetSystemMetrics(SM_XVIRTUALSCREEN); > + offscreen += GetSystemMetrics(SM_CXVIRTUALSCREEN); > + offscreen += 20; > + MoveWindow(tray_window, offscreen, -500, size.cx, size.cy, TRUE); > + } > + break; > + > case WM_TIMER: > cleanup_destroyed_windows(); > break; > @@ -568,5 +581,15 @@ void initialize_systray(void) > WINE_ERR("Could not create tray window\n"); > return; > } > + > + if (hide_systray) > + { > + int offscreen; > + offscreen = GetSystemMetrics(SM_XVIRTUALSCREEN); > + offscreen += GetSystemMetrics(SM_CXVIRTUALSCREEN); > + offscreen += 20; > + MoveWindow(tray_window, offscreen, -500, size.cx, size.cy, TRUE); > + } > + > SetTimer( tray_window, 1, 2000, NULL ); > } Why not add a function do_hide_systray() and call it unconditionally from both places? do_hide_systray() { if (!hide_systray) return; [hide systray] } That would help keeping the code coherent if somebody changes one of places later. -- Dmitry.

1 0

Re: kernel32/winerr: Add Russian translation
by Dmitry Timoshkov 26 Aug '08

26 Aug '08

"Vladimir Pankratov" <scriptkid(a)mail.ru> wrote: > Added Russian translation. > > Changed files: > dlls/kernel32/nls/winerr_rus.mc > dlls/kernel32/kernel.rc > dlls/kernel32/Makefile.in No one of my concerns have been addressed in this version of the patch. -- Dmitry.

1 0

WWN 351
by Zachary Goldberg 26 Aug '08

26 Aug '08

This one is pretty big so I wanted to send it to wine-devel first for some review. Usually I ask on IRC and give people a link but I am unable to provide such a link this time. Attached is both the patch for those who have a local copy of winehq and a tar file of the html for those who don't. If I don't get any comments by about this time tomorrow I'll send to wine-patches. --Zach

1 0

Re: [Take 2] winex11.drv: Fix buffer overflow bug in X11DRV_KeyEvent()and X11DRV_ToUnicodeEx()
by Dmitry Timoshkov 26 Aug '08

26 Aug '08

"Muneyuki Noguchi" <nogu.dev(a)gmail.com> wrote: > Changes from the previous patch: > - Add a new variable STRSIZE. A define would be better IMO, or just use 64 directly, 2 places don't justify the introduction of it. > - Use HeapAlloc() and HeapFree() instead of malloc() and free(). I'd suggest to have an initial buffer of 64 bytes allocated on the stack, and allocate a larger buffer only if required. That improves performance. > - Return from a function when (re)allocation failed. You have to call wine_tsx11_unlock() when needed on exit. -- Dmitry.

2 2

Re: Opengl32: add a WGL_ARB_create_context / OpenGL 3.0 test
by Chris Robinson 26 Aug '08

26 Aug '08

On Tuesday 26 August 2008 01:17:18 pm Roderick Colenbrander wrote: > + int attribs[] = {WGL_CONTEXT_MAJOR_VERSION_ARB, 3, > WGL_CONTEXT_MINOR_VERSION_ARB, 0, 0}; > + HGLRC gl3Ctx = > pwglCreateContextAttribsARB(hdc, 0, attribs); > + ok(gl3Ctx != NULL, > "Creation of an OpenGL 3.0 context failed!\n"); I'm not sure it should be considered a test failure if GL3 isn't supported..

1 0

Re: [10/10] WineX11: add a run-total fps counter to the fps debug channel
by Detlef Riekenberg 26 Aug '08

26 Aug '08

On Mo, 2008-08-25 at 09:32 -0500, Stefan Dösinger wrote: > @@ -3486,15 +3486,19 @@ BOOL X11DRV_SwapBuffers(X11DRV_PDEVICE > *physDev) > /* FPS support */ > if (TRACE_ON(fps)) > { > - static long prev_time, frames; > + static long prev_time, start_time; > + static unsigned long frames, frames_total; > > DWORD time = GetTickCount(); > frames++; > + frames_total++; > /* every 1.5 seconds */ > if (time - prev_time > 1500) { > - TRACE_(fps)("@ approx %.2ffps\n", 1000.0*frames/(time - > prev_time)); > + TRACE_(fps)("@ approx %.2ffps, total %.2ffps\n", > + 1000.0*frames/(time - prev_time), > 1000.0*frames_total/(time - start_time)); > prev_time = time; > frames = 0; > + if(start_time == 0) start_time = time; The first fps report is not correct (0 as prev_time is not the time, when the device was created) Much more Important is the last fps report. Thiat can be from the actual frame up to 1.5 seconds old. When a DirectX test run ~10 sec, the last fps line is one second old. Any change in the Driver, that increase or decrease the needed test-time between 9 sec and 10.5 sec is not detected. You need to make the counters globals (or move it in X11DRV_PDEVICE) and dump a last fps report, when the device is destroyed. I suggest to rename the variable "time", to make clear what it is and to avoid a mix-up with time(). Example: "last_swapbuffers_time" -- By by ... Detlef

2 1

Re: shlwapi/tests: test UrlUnEscape inplace behavior (1/2) (try 2)
by Alexandre Julliard 26 Aug '08

26 Aug '08

"Dan Kegel" <dank(a)kegel.com> writes: > Add test showing UrlUnEscape should convert the url in place > when URL_UNESCAPE_INPLACE is set, even if the output buffer is NULL. > Passes on XP. > > Changes since originally posted by Louis Lenders as > http://www.winehq.org/pipermail/wine-patches/2008-August/059567.html > 1) added todo_wine around parts that fail in Wine > 2) he has requested that somebody else take it over, > so I am raising my hand. If you are resending a patch written by someone else you need to include a From: line with the complete attribution. Alternatively if you have made significant changes you need to add a "Based on a patch by" note in the log message. -- Alexandre Julliard julliard(a)winehq.org

2 3

Re: imagehlp(1/2): Add tests for ImageGetDigestStream
by Detlef Riekenberg 26 Aug '08

26 Aug '08

On Mo, 2008-08-18 at 09:00 -0700, Juan Lang wrote: > dlls/imagehlp/tests/Makefile.in | 13 + > dlls/imagehlp/tests/main.c | 1222 > +++++++++++++++++++++++++++++++++++++++ > 2 files changed, 1235 insertions(+), 0 deletions(-) > +/* "Minimal" executable from compiling "int main(void) { return 0; }" > */ > +static const BYTE bin[] = { The Patch is really large. TCC creates smaller Images: http://bellard.org/tcc/ (But I did not test your Patch with that binary) -- By by ... Detlef

1 0

Re: Add TRACEs to NtCreateFile returns (second try)
by James Hawkins 26 Aug '08

26 Aug '08

2008/8/24 Markus Hitter <mah(a)jump-ing.de>: > + if (!attr || !attr->ObjectName) + { + TRACE("returning STATUS_INVALID_PARAMETER\n"); + return STATUS_INVALID_PARAMETER; + } These are all very useless TRACES, except for possibly the returned handle value. You should be able to look at the traced parameters and see if there is an invalid parameter. As a side note of something I just noticed, the check for NULL attr will never be true because we'll crash in the TRACE when we dereference attr. -- James Hawkins

4 8