August 2008 - Wine-devel - list.winehq.org

Re: winex11.drv: Hack to delete already-created destination context in wglShareLists()
by Roderick Colenbrander 28 Aug '08

28 Aug '08

The proper way to emulate wglShareLists is to recreate a context and to use glXCopyContext to restore all states. glXCopyContexts is not well known and for that reason very buggy (the nvidia drivers segfault) and dri drivers only offer it in case of indirect rendering. I hadn't encountered a case like this before and I fear we have to live with the fact that it can mess up the states. The code itself is ok but please look at the indentation as we use spaces in wine and your patch introduces tabs. Roderick > Homeworld 2 calls wglShareLists() to share two > contexts having already called wglMakeCurrent() on > both, thus forcing Wine to create both contexts. This > causes wglShareLists() to bomb with a "already > created" error. This patch instead deletes the > destination context, if it exists, before sharing. -- GMX Kostenlose Spiele: Einfach online spielen und Spaß haben mit Pastry Passion! http://games.entertainment.gmx.net/de/entertainment/games/free/puzzle/61691…

2 2

Re: shlwapi/tests: test UrlUnEscape inplace behavior (1/2) (try 4)
by Alexandre Julliard 28 Aug '08

28 Aug '08

"Dan Kegel" <dank(a)kegel.com> writes: > Add test showing UrlUnEscape should convert the url in place > when URL_UNESCAPE_INPLACE is set, even if the output buffer is NULL. > Passes on XP. > Needed by Lively, http://bugs.winehq.org/show_bug.cgi?id=14381 > > Changes since originally posted by Louis: > 1) added todo_wine around parts that fail in Wine > 2) added original From: line as requested by Alexandre > 3) unmunged From: line email address so Alexandre's script recognizes it > > From: "Louis. Lenders" <xerox_xerox2000(a)yahoo.co.uk> > Date: Tue, 26 Aug 2008 07:10:06 -0700 > Subject: test UrlUnEscape inplace behavior I put this in, but next time please make sure to include the complete git-format-patch output, including the initial "From sha1" signature line. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [1/2] kernel32: modify DeleteFile to fail on directories
by Paul Vriens 28 Aug '08

28 Aug '08

Jeff Zaroyko wrote: > Correcting the behaviour of DeleteFile also fixes Wine's > implementation of _unlink in msvcrt, test included. > > > ------------------------------------------------------------------------ > > If the msvcrt tests succeed now you should remove the todo_wine's in this patch. -- Cheers, Paul.

1 0

lsb package for wine thoughts
by Dan Kegel 28 Aug '08

28 Aug '08

One of my wild dreams is to create an LSB package for Wine. One of the many roadblocks is OpenSSL. OpenSSL is not standardized, has a very fragile interface, and the openssl devs say they have no time to fix the problem. This leaves an opening for alternative crypto implementations. The way to tell whether an alternative crypto implementation is series is whether they have a good OpenSSL compatibility wrapper. So far I know of two: nss (the ssl used by Firefox) has one, http://fedoraproject.org/wiki/Nss_compat_ossl and gnu tls has one. nss is part of the LSB, but gnu tls is not. Potentially one could link against nss and its wrapper instead of openssl when building an LSB package of wine. A few issues to consider: a) wrappers might need to be statically linked to avoid clashes with shared libraries built with the real openssl: http://www.linux-archive.org/fedora-development/148626-libgnutls-openssl-re… b) gnu tls is gpl... Does wine currently link against any GPL (as opposed to LGPL) libraries? OK, back to the real world. - Dan

6 10

Re: typelib (oleaut32): [PATCH 1/4] Implement LHASHVALOFNAMESYS
by Alexandre Julliard 28 Aug '08

28 Aug '08

Detlef Riekenberg <wine.dev(a)web.de> writes: > +ULONG WINAPI > +LHashValOfNameSys16(SYSKIND skind, LCID lcid, LPCSTR lpStr) > +{ > + TRACE("(%d, %d, %s) %s\n", skind, lcid, debugstr_a(lpStr), > + (skind == SYS_WIN16) ? "SYS_WIN16" : (skind == SYS_WIN32) ? "SYS_WIN32" : ""); > + return LHashValOfNameSysA(skind, lcid, lpStr); > +} You don't need to introduce a 16-bit function if all it does is forward to the 32-bit one. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: ntdll/file.c: Fix a possible NULL dereferencing.
by Nikolay Sivov 28 Aug '08

28 Aug '08

Markus Hitter wrote: > if (!attr || !attr->ObjectName) return STATUS_INVALID_PARAMETER; Shouldn't this be splitted? It isn't safe to rely on evaluation order. Or is it a default compiler setting for us?

4 5

Re: [Gdiplus try2 09/10] Implement GdipGetLogFontA
by Alexandre Julliard 28 Aug '08

28 Aug '08

Adam Petaccia <adam(a)tpetaccia.com> writes: > + lfw = font->lfw; > + memcpy(&lfw, lfa, FIELD_OFFSET(LOGFONTA,lfFaceName)); > + MultiByteToWideChar(CP_ACP, 0, lfa->lfFaceName, -1, lfw.lfFaceName, LF_FACESIZE); The conversion should be the other way around, lfa is the output, and you don't really need lfw. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [2/3] mshtml: Pass IID_IHTMLBodyElement to the IDispatchEx interface
by Jacek Caban 27 Aug '08

27 Aug '08

Hi Alistair, Alistair Leslie-Hughes wrote: > Hi, > > Changelog: > mshtml: Pass IID_IHTMLBodyElement to the IDispatchEx interface Look at other elements implementation how to do it properly. Your patch will break scripts that use body element. > +static const tid_t HTMLBodyElement_iface_tids[] = { > + IHTMLBodyElement_tid, > + 0 > +}; > + You should add IHTMLDOMNode_tid, IHTMLDOMNode2_tid, IHTMLElement_tid, IHTMLElement2_tid, here. > +static dispex_static_data_t HTMLBodyElement_dispex = { > + NULL, > + IHTMLBodyElement_tid, You should use DispHTMLBodyElement here. > @@ -601,6 +613,7 @@ HTMLElement *HTMLBodyElement_Create(nsIDOMHTMLElement *nselem) > HTMLTextContainer_Init(&ret->textcont); > > ret->lpHTMLBodyElementVtbl = &HTMLBodyElementVtbl; > + ret->textcont.element.node.dispex.data = &HTMLBodyElement_dispex; You should call init_dispex here. Jacek

2 2

Re: regedit 1/2: Use unicode strings when updating listview
by Alexander Nicolaysen Sørnes 27 Aug '08

27 Aug '08

På Torsdag 28 august 2008 , 00:29:03 skrev Alexander Nicolaysen Sørnes: > Should be applied after Juan's regedit patch > > > Alexander N. Sørnes Sorry, mean't Lei's. No offence intended. :D

1 0

Summer of code evaluations
by Maarten Lankhorst 27 Aug '08

27 Aug '08

Hi all, As you may know yesterday was the pens down for summer of code 2008 Students are still allowed to write code, but it won't count for the mentors evaluation any more. I would like to request from the mentors to fill in the final evaluation form and from the students to give a final write up: What went well? Did you meet the goals you set? Did you have fun? Is there anything we can do to make wines summer of code better and do you feel like you've become part of the wine community? I also believe that students will have to fill in a final evaluation form as well, so get writing. ;-) Cheers, Maarten.

8 7