November 2010 - Wine-devel - list.winehq.org

Re: dlls/oledb32: added conversions for I1, I8, UI2, DEC and GetConversionSize
by Dan Kegel 18 Nov '10

18 Nov '10

Hi Andreas, Thanks for helping Wine! A few administrivial issues: Please submit only one attachment per post. Also, please avoid sending HTML mail to wine-patches. See http://wiki.winehq.org/SubmittingPatches - Dan On Thu, Nov 18, 2010 at 4:05 AM, Andreas Pflug <pflug(a)pse-consulting.de> wrote: > > This complements my previous post, which is included for completeness' sake below (0001-OLEDB-xxx) > > convert_DataConvert is extended for the types DBTYPE_I1, DBTYPE_I8 ,DBTYPE_UI2, DBTYPE_DECIMAL. The conversions are performed using the OLEAUT32-Functions VarXXXFromYYY, as far as they exist which made this mostly a carefully handled copy/paste job. > > Conversion DBTYPE_TIMESTAMP<->DBTYPE_DATE have been successfully tested using a commercial app (HIW Rendite 10). > > GetConversionLength has been implemented trivially for fixed-length dstTypes, and partially for var-length types (as far as the app required it). > > > -------- Original-Nachricht -------- > Betreff: dlls/oledb32: added conversions for R8,BOOL,DATE,DBTIMESTAMP > Datum: Wed, 17 Nov 2010 13:45:25 +0100 > Von: Andreas Pflug <pflug(a)pse-consulting.de> > An: wine-patches(a)winehq.org > > convert_DataConvert now know the types DBTYPE_R8, DBTYPE_BOOL, > DBTYPE_DATE and will convert from all source types supported by > VarXXXFromYYY functions. > DBTYPE_TIMESTAMP is supported to convert from and to DBTYPE_DATE. > get_length is extended accordingly. > >

1 0

Re: [1/5] gdi32: Separate font loading from adding a font to global font list. Take 3.
by Alexandre Julliard 18 Nov '10

18 Nov '10

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: > --- > dlls/gdi32/freetype.c | 304 +++++++++++++++++++++++++++++++++---------------- > 1 files changed, 205 insertions(+), 99 deletions(-) It doesn't build on Mac: gcc -m32 -c -I. -I. -I../../include -I../../include -I/usr/local/include/freetype2 -I/usr/local/include -I/usr/X11/include -D__WINESRC__ -D_GDI32_ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wstrict-prototypes -Wwrite-strings -Wpointer-arith -g -O2 -o freetype.o freetype.c freetype.c: In function 'load_font': freetype.c:1418: error: 'fake_family' undeclared (first use in this function) freetype.c:1418: error: (Each undeclared identifier is reported only once freetype.c:1418: error: for each function it appears in.) make[1]: *** [freetype.o] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/4] wined3d: Disallow empty surfaces.
by Stefan Dösinger 18 Nov '10

18 Nov '10

Am Donnerstag 18 November 2010, 12:21:39 schrieb Henri Verbeet: > + if (!resource_size) return WINED3DERR_INVALIDCALL; Shouldn't we add a format flag that controls wether a format can be used to create a resource instead? I'm thinking about the NULL fourcc code that also has a resource size of zero but can be used to create a surface.

2 1

Re: Patch for bug 25063 - _pclose should wait for the command processor to terminate and return it's exit status
by Alexandre Julliard 18 Nov '10

18 Nov '10

Borut Razem <borut.razem(a)siol.net> writes: > +static void msvcrt_add_handle(MSVCRT_FILE *fp, HANDLE *hProcess) > +{ > + LOCK_POPEN; > + if (fp2handle == NULL) > + { > + /* array not allocated yet: allocate it */ > + if ((fp2handle = MSVCRT_malloc(sizeof (struct fp2handle_s) * 16)) != NULL) > + { > + /* write handles to the first slot */ > + fp2handle[0].fp = fp; > + fp2handle[0].hProcess = hProcess; > + > + /* zero the remaining space */ > + memset(&fp2handle[1], 0, sizeof (struct fp2handle_s) * (16 - 1)); > + > + /* update the number of slots */ > + fp2handle_entries = 16; > + } > + } > + else > + { > + int i; > + > + /* search for free or slot with the same fp */ > + for (i = 0; i < fp2handle_entries; ++i) > + { > + if (fp2handle[i].fp == NULL || fp2handle[i].fp == fp) > + { > + /* found: write handles to the slot */ > + fp2handle[i].fp = fp; > + fp2handle[i].hProcess = hProcess; > + break; > + } > + } > + if (i >= fp2handle_entries) > + { > + /* no space left: double the array size */ > + struct fp2handle_s *newFp2handle; > + > + if ((newFp2handle = MSVCRT_realloc(fp2handle, sizeof (struct fp2handle_s) * (fp2handle_entries * 2))) != NULL) > + { > + fp2handle = newFp2handle; > + > + /* write handles to the first exetended slot */ > + fp2handle[fp2handle_entries].fp = fp; > + fp2handle[fp2handle_entries].hProcess = hProcess; > + > + /* zero the remaining extended space */ > + memset(&fp2handle[fp2handle_entries + 1], 0, sizeof (struct fp2handle_s) * (fp2handle_entries - 1)); > + > + /* update the number of slots */ > + fp2handle_entries *= 2; > + } > + } > + } > + UNLOCK_POPEN; > +} That's an awful lot of code for such a simple thing. You probably want to use an array indexed by file descriptor or something like that. Also please don't add a comment before every line stating what the line does, that should be clear from the code itself. -- Alexandre Julliard julliard(a)winehq.org

2 4

Re: [3/5] gdi32: Add the ability to load a scalable font resource. Take 3.
by Alexandre Julliard 18 Nov '10

18 Nov '10

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: > + if (!ReadFile(hfile, &dos, sizeof(dos), NULL, NULL)) > + goto errexit; > + > + if (dos.e_magic != IMAGE_DOS_SIGNATURE) > + goto errexit; > + > + if (SetFilePointer(hfile, dos.e_lfanew, NULL, FILE_BEGIN) == INVALID_SET_FILE_POINTER) > + goto errexit; > + > + if (!ReadFile(hfile, &os2, sizeof(os2), NULL, NULL)) > + goto errexit; Again that's inefficient, you don't want to read it bit by bit. You should read the whole file in one go, or use a memory mapping. If using ReadFile you also have to check the returned size. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 4/4] ddraw: Return DDERR_INVALIDPARAMS for 0 width / height surface creation.
by Marvin 18 Nov '10

18 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7157 Your paranoid android. === W98SE (32 bit dsurface) === dsurface: unhandled exception c0000005 at 00415849

1 0

RFC: flipping more than one backbuffer on swapchain
by Pavel Procházka 18 Nov '10

18 Nov '10

I had patched IWineGDISwapChainImpl_Present, which can now fully support looping behavior on swapchain for more than one backbuffer. Patch 2/3 allows more backbuffers creation for GDI surfaces, and last patch is test to ddraw.

1 0

Re: mshtml: Removed tests failing on IE7.
by Marvin 18 Nov '10

18 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7145 Your paranoid android. === W98SE (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [1/3] d3dx9: Implement D3DXFillTexture function.
by Henri Verbeet 17 Nov '10

17 Nov '10

On 17 November 2010 17:23, Matteo Bruni <matteo.mystral(a)gmail.com> wrote: > +static BOOL color_match(DWORD *value, DWORD *expected) Those should probably be const.

1 0

wanted: test.avi resource
by Joerg-Cyril.Hoehle＠t-systems.com 17 Nov '10

17 Nov '10

Hi, Currently there are no tests in Wine of mciavi or mciqtz. The reason is incredibly trivial: I'd need a test.avi with defined properties that the tests check, and of course the file should be as small as possible to not weight too much in git. If you happen to know clock.avi (found in some versions of MS-Windows), this comes close. It displays an analog clock with a single clock hand plus numbers from 1 to 12. It ticks one frame per second, showing numbers from 1 to 12 in addition to moving the hand. What I think would be useful is a video with - frames: key - key - delta - key (if delta is possible) - displaying digits 1 - 2 - 3 - 4 - speed: one frame per second - sound would be very useful, but it might increase the file size a lot (3 seconds of sound...). Perhaps MS-ADPCM might well compress a sound file that beeps, then pauses for most of the rest of every second. Beeps at different frequencies would be best. - simplify graphics to minimize disk space. Actually, I don't know whether such an animation with 4 frames would play for 3 seconds (final frame displayed at the end) or 4 (final frame displayed for one second, like the others, then stop). Any volunteer? How would that be incorporated into winetest.exe? As a resource, copied at execution time to the current directory? Thank you for your help, Jörg Höhle

3 2