November 2010 - Wine-devel - list.winehq.org

mciavi should be rewritten using the AVIFile interface
by Joerg-Cyril.Hoehle＠t-systems.com 17 Nov '10

17 Nov '10

Hi, MSDN documents (and I verified) that the MCIAVI allows to access an open AVIFile object via the special name @NN...NN (decimal address). Conversely, open @-1024 type avivideo alias a crashes native at address ffffc000 -- except on w95 (KB140750). This makes it likely that MCIAVI internally uses the AVIFile API (it might also pull the MMIO file handle out of the AVIFile structure). Furthermore, other parameters that the MCI exports, e.g. MCI_ANIM_*_SPEED, map to what the AVIFile objects provide and is not present in MMIO handling, reinforcing the hypothesis that the MCIAVI uses the AVIFile API. Hence mciavi.c should be rewritten to use the AVIFile API. I hope that doing so will prevent a skew that I've observed with some apps, where sound and video rendering do not match after a few seconds. Any volunteers? Any excellent sample code using AVIFile to render both video and audio? Regards, Jörg Höhle

3 2

Re: msvcrt: Add implementation of _strncoll
by Piotr Caban 17 Nov '10

17 Nov '10

Hi, + char * nstr1 = HeapAlloc(GetProcessHeap(), 0, count + 1); + char * nstr2 = HeapAlloc(GetProcessHeap(), 0, count + 1); + + memcpy(nstr1, str1, count + 1); strncoll is used to compare at most count characters (you can't access data after nullbyte). You're not null terminating nstr1 and nstr2 strings. This function should be implemented without memory allocations. Cheers, Piotr

2 4

Re: msvcrt: Add implementation of _strncoll (try 2)
by Dmitry Timoshkov 17 Nov '10

17 Nov '10

Vitaly Perov <vitperov(a)etersoft.ru> wrote: > + result = strcoll(nstr1, nstr2); System strcoll() for strings in different encoding won't work properly. -- Dmitry.

1 0

Re: [PATCH 4/4] ddraw/tests: Fix some failure messages.
by Marvin 17 Nov '10

17 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7119 Your paranoid android. === W2KPROSP4 (32 bit visual) === visual.c:1376: Test failed: Got color 000a246a, expected 00000080 or near visual.c:1382: Test failed: Got color 006b8bbd, expected 000000ff or near visual.c:1388: Test failed: Got color 00ffffff, expected 00000080 or near visual.c:1394: Test failed: Got color 00ffffff, expected 000000ff or near

1 0

Icons for hh and winebrowser
by Damjan Jovanovic 17 Nov '10

17 Nov '10

Hi Could whoever draws icons for Wine please add icons for programs/hh and programs/winebrowser? I've made a patch (http://source.winehq.org/patches/data/68572) which generates icons for Wine applications in the file browser "Open with" list, and these applications are just getting a wineglass. Thank you Damjan Jovanovic

2 1

Re: [1/3] msxml3: Use the associated schema for domelem_get_dataType()
by Jacek Caban 17 Nov '10

17 Nov '10

Hi Adam, On 11/16/10 23:00, Adam Martinson wrote: > --- > dlls/msxml3/element.c | 95 +++++++++++++- > dlls/msxml3/msxml_private.h | 1 + > dlls/msxml3/node.c | 248 ++++++++++++++++++++++++++++++++++-- > dlls/msxml3/tests/domdoc.c | 301 > +++++++++++++++++++++++++++++++++++-------- > 4 files changed, 574 insertions(+), 71 deletions(-) + if(This->node->type == XML_ELEMENT_NODE) + { + XDR_DT dt = element_get_dt(This->node); + content = xmlNodeGetContent(This->node); + hres = VARIANT_from_DT(dt, content, typedValue); + xmlFree(content); + } + else if (This->node->type == XML_TEXT_NODE || + This->node->type == XML_ENTITY_REF_NODE) + { Please use inheritance for this. We're in process of getting rid of xmlnode_* functions. Such differences in implementation should be handled in node type-specific objects. Jacek

1 0

Re: [1/2] comctl32/treeview: Use a code set by dispinfo holder to convert data encoding after TVN_GETDISPINFO
by Alexandre Julliard 17 Nov '10

17 Nov '10

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > hTree = create_treeview_control(); > - fill_tree(hTree); > +// fill_tree(hTree); You probably don't want this. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH] [Kernel32,Server]: implemented GetConsoleProcessList
by Alexandre Julliard 17 Nov '10

17 Nov '10

Eric Pouech <eric.pouech(a)orange.fr> writes: > + if ((cpl.console = console_input_get( req->handle, FILE_READ_PROPERTIES ))) > + { > + data_size_t sz; > + > + reply->num_processes = sz = cpl.console->num_proc; > + > + if ((sz *= sizeof(process_id_t)) <= get_reply_max_size()) That's much harder to read than necessary. Please set sz in a more conventional manner. > +/* Get console's process list */ > +(a)REQ(get_console_process_list) > + obj_handle_t handle; /* handle to console input (0 for current process console) */ > +(a)REPLY > + int num_processes; /* number of processes attached to this console */ > + VARARG(pidlist,ints); /* process list */ Please add a proper tracing function for process ids, they would be hard to recognize as ints. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/3] msxml3: Use the associated schema for domelem_get_dataType()
by Alexandre Julliard 17 Nov '10

17 Nov '10

Adam Martinson <amartinson(a)codeweavers.com> writes: > + todo_wine ole_check(IXMLDOMNode_get_nodeTypedValue(node, &v)); > + /* TODO: which platforms return VT_UI8? */ > + todo_wine ok(V_VT(&v) == VT_NULL, "got variant type %i\n", V_VT(&v)); > + if (V_VT(&v) == VT_UI8) > + todo_wine ok(V_UI8(&v) == 0xFFFFFFFFFFFFFFFFULL, "got %016llx\n", V_UI8(&v)); Please avoid long long constants and printf formats. -- Alexandre Julliard julliard(a)winehq.org

1 0

mciseq should be rewritten using winmm's midiStreamOut interface
by Joerg-Cyril.Hoehle＠t-systems.com 17 Nov '10

17 Nov '10

Hi, midiOutShortMsg() is an incredibly bad API for SW synths. It's just good enough at the lowest level, to throw bytes to the serial hardware. It is antithetical to buffering. The machine is stressed to obey the event ASAP, which is travelling across several threads that hence need be set as time-critical each, until a note is eventually produced. No wonder there's stuttering with some apps. OTOH, analyzing several events in advance in a stream buffer, the SW synth would have a lot of time to produce excellent quality output. Consequently, Wine's MCISEQ should use WINMM's midiStream interface. Then, the individual audio drivers should implement MIDICAPS_STREAM. (Alas I don't know what MODM_ message corresponds to this.) WineOSS.drv could then make use of SEQ_DELTA_TIME() and throw a whole buffer of events at OSS' MIDI interface, instead of relying on SEQ_DUMPBUF() to immediately start processing a tiny one note "buffer". This implies that Wine must be able to mix several streams by event timestamp, duplicating what MacOS' CoreMIDI can. Perhaps this can be delegated to the OS? Unless it's easier to leave mixing in the file parser, which is what MIDI_mciFindNextEvent() currently does, generating one stream per file instead of one per track. Converting a .mid to streams of MIDIEVENT might be useful as well should Wine ever implement DirectMusic. It may also help implement MCI_SEQ_FORMAT_SONGPTR which is MCISEQ's default time format on native for all .mid files I tried, not milliseconds or bytes. Tests with MCI_SEEK show that the native MCI cannot seek exactly to arbitrary milliseconds, instead it steps in units of "song pointer". Any volunteers? What's the recommended place (what Wiki page?) to add this as Wine task so every potential taker looking for a job can see it? Regards, Jörg Höhle

1 0