November 2010 - Wine-devel - list.winehq.org

Re: [include] add new macro WINELIB_NAME_W for support in the unicode functions of msvcr* dlls
by Alexandre Julliard 23 Nov '10

23 Nov '10

Vijay Kiran Kamuju <infyquest(a)gmail.com> writes: > Changelog > --------------- > [include] add new macro WINELIB_NAME_W for support in the unicode functions > of msvcr* dlls > It helps functions like _RTC_error_fn and _CRT_RTC_INIT That's not really useful. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/2] msvcr90 - rename the stat64i32 functions
by Alexandre Julliard 23 Nov '10

23 Nov '10

Vijay Kiran Kamuju <infyquest(a)gmail.com> writes: > [PATCH 1/2] msvcr90 - rename the stat64i32 functions Why do you need this? -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Patch for bug 25063 - _pclose should wait for the command processor to terminate and return it's exit status
by Alexandre Julliard 23 Nov '10

23 Nov '10

Borut Razem <borut.razem(a)siol.net> writes: > +/* TODO: this shold be same as MSVCRT_MAX_FILES defined in file.c. > + The define should be moved to a common header file. Is msvcrt.h the right one? */ > +#define MSVCRT_MAX_FILES 2048 There's no reason to use this here. -- Alexandre Julliard julliard(a)winehq.org

1 0

wine git doesn't build on 10.6.5
by C.W.Betts 23 Nov '10

23 Nov '10

When I try to build wine git on Mac OS X 10.6.5, I get the following error (on clang. I get similar errors using GCC): clang -m32 -c -I../../../wine-git/./dlls/atl -I. -I../../../wine-git/./include -I../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wstrict-prototypes -Wtype-limits -Wwrite-strings -Wpointer-arith -I/sw/include -m32 -I/sw/include -m32 -o registrar.o ../../../wine-git/./dlls/atl/registrar.c ../../../wine-git/./dlls/atl/registrar.c:747:8: error: use of undeclared identifier 'CLSID_Registrar'; did you mean 'CLSID_ATLRegistrar'? if(IsEqualGUID(&CLSID_Registrar, clsid)) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../../wine-git/./dlls/atl/registrar.c:747:21: note: instantiated from: if(IsEqualGUID(&CLSID_Registrar, clsid)) ^~~~~~~~~~~~~~~ CLSID_ATLRegistrar In file included from ../../../wine-git/./dlls/atl/registrar.c:32: ./atliface.h:259:1: note: 'CLSID_ATLRegistrar' declared here DEFINE_GUID(... ^ ./atliface.h:259:13: note: instantiated from: DEFINE_GUID(CLSID_ATLRegistrar,... ^ ../../../wine-git/./dlls/atl/registrar.c:796:22: error: use of undeclared identifier 'CLSID_Registrar'; did you mean 'CLSID_RegistrarW'? StringFromGUID2(&CLSID_Registrar, clsid_str, ... ^~~~~~~~~~~~~~~ CLSID_RegistrarW ../../../wine-git/./dlls/atl/registrar.c:789:24: note: 'CLSID_RegistrarW' declared here static const WCHAR CLSID_RegistrarW[] = ^ ../../../wine-git/./dlls/atl/registrar.c:796:21: warning: incompatible pointer types passing 'WCHAR const (*)[16]' to parameter of type 'GUID const *' StringFromGUID2(&CLSID_Registrar, clsid_str, ... ^~~~~~~~~~~~~~~~

2 1

Re: [website 1/2] Add a Donation Page with more Options
by Jeremy White 22 Nov '10

22 Nov '10

Hi André, Several thoughts. I'm not aware of any source of revenue that comes to us via Amazon or CDNow. We might want to remove that. I'm also a bit concerned about the T-shirts; we should get a report on that, I don't know that we've gotten much. Also, we should track this; after we change, we should see how much donations are, and then see if we think it's better or worse than what it was before. It's hard, as donations are quite variable in timing and amount. Cheers, Jeremy

2 1

Re: ntdll/tests: add tests for NtQueryVolumeInformationFile with FileFsVolumeInformation class
by Marvin 22 Nov '10

22 Nov '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7222 Your paranoid android. === W98SE (32 bit file) === No test summary line found

1 0

Re: Alexandre Julliard : configure: Disable Fortify if it's enabled by default, it's too broken.
by Marcus Meissner 22 Nov '10

22 Nov '10

On Fri, Oct 22, 2010 at 12:30:48PM -0500, Alexandre Julliard wrote: > Module: wine > Branch: master > Commit: 105793bff75f6a869bd9ccfb390b2f88fa861235 > URL: http://source.winehq.org/git/wine.git/?a=commit;h=105793bff75f6a869bd9ccfb3… > > Author: Alexandre Julliard <julliard(a)winehq.org> > Date: Fri Oct 22 17:13:57 2010 +0200 > > configure: Disable Fortify if it's enabled by default, it's too broken. What is broken? I could leverage my connections with gcc :/ Ciao, Marcus

2 1

Re: ntdll/tests: add tests for NtQueryVolumeInformationFile with FileFsVolumeInformation class
by Paul Vriens 22 Nov '10

22 Nov '10

On 11/22/2010 07:59 PM, Louis Lenders wrote: > + status = NtQueryVolumeInformationFile( dir,&io, buf, sizeof(buf), FileFsVolumeInformation ); You have to use the 'p' one here to please Win9x where this function is not exported. -- Cheers, Paul.

1 0

Re: [mscoree/tests 4/4] Fix test failures on W2K and earlier
by Vincent Povirk 22 Nov '10

22 Nov '10

I think this test can be removed. I wanted to verify that LoadLibraryShim would succeed for a dll that is absent from the .NET system directory but present in system32. I had heard of LoadLibraryShim succeeding for gdiplus, so I was very surprised when this failed. I was so surprised that I did the same test with gdi32, because I was sure that would never be duplicated. (And it looks like it isn't.) I think that the older versions must have gdiplus in the .NET system directory so that the System.Drawing libraries (which are a thin wrapper around gdiplus) can load it. I guess that .NET searches for libraries in the .NET system directory and the regular path, meaning this is not needed on later versions of Windows that have gdiplus in system32. Anyway, I think this shows that the success or failure is not important in this case, and we don't need the test. On Mon, Nov 22, 2010 at 1:37 PM, Paul Vriens <paul.vriens.wine(a)gmail.com> wrote: > Changelog > Fix test failures on W2K and earlier > > -- > Cheers, > > Paul. > > > > >

2 1

Re: [resend]: [dlls/dbgeng]: add initial stub dll implementation
by Paul Vriens 21 Nov '10

21 Nov '10

On 11/19/2010 03:50 PM, Volodymyr Shcherbyna wrote: > (I am re-sending this patch as gmail did extra formattings to previous > patches) Hi, +MODULE = dbgeng.dll +IMPORTLIB = dbgebg Typo? You also have to use your own wording for the comments, if needed at all, to the functions. You can't just copy-paste from MSDN. -- Cheers, Paul.

4 5