August 2011 - Wine-devel - list.winehq.org

mmdevapi: IsFormatSupported fills closest match iff it returns S_FALSE.
by Joerg-Cyril.Hoehle＠t-systems.com 24 Aug '11

24 Aug '11

Hi, what about this patch of mine? #77305 is about to fall off the queue. 3 weeks later, it's still ok AFAICT. >This will need another sweep in some future after somebody tests what happens >in EXCLUSIVE mode about which MSDN says the pointer is set to null. >I only tested SHARED mode with standard formats. I've 2 patches in my queue that depend on this one: - indeed, no format suggestion in exclusive mode; - if all else fails, suggest GetFormatMix in shared mode BTW, #77096 was superseded by something long committed. Regards, Jörg Höhle

1 0

Re: [PATCH] attrib: Move implementation from cmd.exe to the standalone command
by Frédéric Delanoy 24 Aug '11

24 Aug '11

On Wed, Aug 24, 2011 at 08:20, Christian Costa <titan.costa(a)wanadoo.fr> wrote: > -- > > I added a stub last year to make an installer work but didn't know the command existed as a builtin in cmd.exe until Frédéric Delanoy told me. So here is a patch that takes what's in cmd.exe and move it to the standalone command. Some few code was taken from xcopy. > --- > programs/attrib/Makefile.in | 4 + > programs/attrib/attrib.c | 190 +++++++++++++++++++++++++++++++++++++++++-- > programs/attrib/attrib.h | 28 ++++++ > programs/attrib/attrib.rc | 49 +++++++++++ > programs/cmd/builtins.c | 83 ------------------- > programs/cmd/cmd.rc | 2 > programs/cmd/wcmd.h | 94 ++++++++++----------- > programs/cmd/wcmdmain.c | 4 - > 8 files changed, 309 insertions(+), 145 deletions(-) > create mode 100644 programs/attrib/attrib.h > create mode 100644 programs/attrib/attrib.rc Most translatable strings (except those in dialogs) have been moved to/adapted for use in po files. You have to regenerate the po files using "make depend && make" in maintainer mode (./configure --enable-maintainer-mode). Frédéric

1 1

Re: André Hentschel : po: German translations added and updated.
by Francois Gouget 23 Aug '11

23 Aug '11

On Mon, 22 Aug 2011, Alexandre Julliard wrote: > Module: wine > Branch: master > Commit: aeb9f621292dec7a6366209106468da8d0371684 > URL: http://source.winehq.org/git/wine.git/?a=commit;h=aeb9f621292dec7a636620910… I think the string below should really be translated. It's displayed in winecfg -> Desktop Integration tab, in the 'Item' list more precisely. This is where one can decide what color or font to use for each of the GUI elements. And actually all the items around "Message Box Text" are translated. > msgid "Message Box Text" > -msgstr "" > +msgstr "Message Box Text" There's also another translation that I think is wrong: > #: wordpad.rc:88 > -#, fuzzy > msgid "&Pale yellow\tCtrl+2" > msgstr "&PostIt-Notiz\tStrg+2" This used to be 'PostThat Yellow' which was a word play on PostIt. However 'Pale Yellow' is much clearer and the German translation does not look like a color name at all currently. So I think it's best not to continue with the bad pun (besides otherwise you would probably need to change it to 'PostIt[tm]...' anyway). Everything else looks good (to a non-German speaking guy). -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Nouvelle version : les anciens bogues ont été remplacés par de nouveaux.

2 1

Summer is ending, you can't procrastinate any more, come to Wineconf!
by Jeremy White 23 Aug '11

23 Aug '11

So summer holidays are rapidly ending, and before you know it, Wineconf will be upon us - just 5 more weeks until Wineconf! The full details, including the hotel information, is available here: http://wiki.winehq.org/WineConf2011 For those of you that have asked for sponsorship, I'm trying to come to a 'final' set of requests so I can figure out how best to divvy up the funds we have available. I hope to have that info soon. If you're interested in coming, but can't afford it, please write to me privately to see if we can help. Hope to see you there! Cheers, Jeremy p.s. I promise to try to keep most discussion on the http://www.winehq.org/mailman/listinfo/wineconf mailing list, which you should join now if you're at all interested in Wineconf.

1 0

Re: [5/5] ddraw: Emulate a 24 bit depth format without stencil or padding
by Henri Verbeet 23 Aug '11

23 Aug '11

On 22 August 2011 21:16, Stefan Dösinger <stefandoesinger(a)gmx.at> wrote: > + {WINED3DFMT_D24_UNORM, 0x0, 0x0, 0x0, 0x0, 4, 24, 0}, > {WINED3DFMT_X8D24_UNORM, 0x0, 0x0, 0x0, 0x0, 4, 24, 0}, How is WINED3DFMT_D24_UNORM different from WINED3DFMT_X8D24_UNORM?

2 4

Re: [3/7] msi: Don't create a temporary copy of the package. (try 2)
by Octavian Voicu 23 Aug '11

23 Aug '11

On Tue, Aug 23, 2011 at 3:13 PM, Joris Huizer <joris_huizer(a)yahoo.com>wrote: > On 08/23/2011 11:45 AM, Hans Leidekker wrote: > >> + if (!strcmpiW( package, unsquashed )) >> > > I'm confused about the last part of the function. > I think if the comparison between 'package' and 'unsquashed' fails, you > want to return an error, > but the return value 'r' will be ERROR_SUCCESS at that point, and isn't > updated. > Hello, The function strcmpiW returns 0 when the strings are equal, and non-zero when they are different (< 0 if first is smaller, > 0 if first is larger, lexicographically speaking). The condition checks if the strings match, not if the function failed (string comparison cannot "fail"). Cheers, Octavian

1 0

Re: [3/7] msi: Don't create a temporary copy of the package. (try 2)
by Joris Huizer 23 Aug '11

23 Aug '11

Just an implementation detail I noticed: On 08/23/2011 11:45 AM, Hans Leidekker wrote: > + > +static UINT get_registered_local_package( const WCHAR *product, const WCHAR *package, WCHAR *localfile ) > +{ > + MSIINSTALLCONTEXT context; > + HKEY product_key, props_key; > + WCHAR *registered_package = NULL, unsquashed[GUID_SIZE]; > + UINT r = ERROR_FUNCTION_FAILED; > + > + r = msi_locate_product( product,&context ); > + if (r != ERROR_SUCCESS) > + return r; > + > + r = MSIREG_OpenProductKey( product, NULL, context,&product_key, FALSE ); > + if (r != ERROR_SUCCESS) > + return r; > + > + r = MSIREG_OpenInstallProps( product, context, NULL,&props_key, FALSE ); > + if (r != ERROR_SUCCESS) > + { > + RegCloseKey( product_key ); > + return r; > + } > + registered_package = msi_reg_get_val_str( product_key, INSTALLPROPERTY_PACKAGECODEW ); > + if (!registered_package) > + goto done; > + > + unsquash_guid( registered_package, unsquashed ); > + if (!strcmpiW( package, unsquashed )) > + { > + WCHAR *filename = msi_reg_get_val_str( props_key, INSTALLPROPERTY_LOCALPACKAGEW ); > + strcpyW( localfile, filename ); > + msi_free( filename ); > + r = ERROR_SUCCESS; > + } > +done: > + msi_free( registered_package ); > + RegCloseKey( props_key ); > + RegCloseKey( product_key ); > + return r; > +} > + > I'm confused about the last part of the function. I think if the comparison between 'package' and 'unsquashed' fails, you want to return an error, but the return value 'r' will be ERROR_SUCCESS at that point, and isn't updated. HTH, Joris

1 0

Re: [7/7] msi/tests: Clean up local packages.
by Marvin 23 Aug '11

23 Aug '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13580 Your paranoid android. === WNT4WSSP6 (32 bit install) === install.c:5997: Test failed: Per-user icon file isn't where it's expected (C:\WINNT\Profiles\Default User\Application Data\Microsoft\Installer\{7DF88A49-996F-4EC8-A022-BF956F9B2CBB}\testicon)

1 0

Re: [6/7] msi: Remove icons when the product is uninstalled.
by Marvin 23 Aug '11

23 Aug '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=13579 Your paranoid android. === WNT4WSSP6 (32 bit install) === install.c:5979: Test failed: Per-user icon file isn't where it's expected (C:\WINNT\Profiles\Default User\Application Data\Microsoft\Installer\{7DF88A49-996F-4EC8-A022-BF956F9B2CBB}\testicon)

1 0

Re: tools/winegcc: support a trailing / in paths to winebuild
by Alexandre Julliard 23 Aug '11

23 Aug '11

Bernhard Loos <bernhardloos(a)googlemail.com> writes: > diff --git a/tools/winegcc/winegcc.c b/tools/winegcc/winegcc.c > index 284223e..3a7e93a 100644 > --- a/tools/winegcc/winegcc.c > +++ b/tools/winegcc/winegcc.c > @@ -1326,6 +1326,7 @@ int main(int argc, char **argv) > { > case 'B': > str = strdup(option_arg); > + if (strendswith(str, "/")) str[strlen(str) - 1] = 0; Why would you want to append a slash to winebuild? -- Alexandre Julliard julliard(a)winehq.org

4 5