January 2024 - Wine-gitlab - list.winehq.org

Re: [PATCH v6 0/2] MR4748: Don't test function directly when reporting GetLastError() - approved
by Alexandre Julliard (＠julliard) 05 Jan '24

05 Jan '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4748

1 0

Re: [PATCH v7 0/2] MR4774: msvcrt: Compare environmental variable names case insensitively - approved
by Alexandre Julliard (＠julliard) 05 Jan '24

05 Jan '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4774

1 0

Re: [PATCH v3 0/1] MR4780: wined3d: Set fixed_function_usage_map to 0 for an sm4 draw without a PS. - approved
by Alexandre Julliard (＠julliard) 05 Jan '24

05 Jan '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4780

1 0

[PATCH 0/1] MR4784: dlls/gdiplus: Clean up GdipCloneImageAttributes
by David Kahurani (＠kahurani) 05 Jan '24

05 Jan '24

Not sure this is an improvement but it does look like one to me. Signed-off-by: David Kahurani k.kahurani(a)gmail.com -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4784

3 7

[PATCH v7 0/3] MR514: tests: Use the vulkan runner to run SM1 compilation tests.
by Francisco Casas (＠fcasas) 05 Jan '24

05 Jan '24

Recap: My previous proposals to extend the shader_runner to SM1 were focusing on separating compilation tests ([shader] directives) from execution tests ([test] directives), and let the generic shader_runner.c:compile_shader() in charge of the former. However, Henri was more inclined to aim for making the parser agnostic to the language of the tests so we can potentially extend the shader_runner tests to other languages such as d3d-asm. This means, removing the burden of compilation from the parser altogether, and moving it to the runners, probably through a runner->compile function pointer (even if most of them end up doing the same thing, compiling with vkd3d-shader or the native compiler, depending on availability). Agreeing with going in this general direction, this MR contains patches to do SM1 compilation calling run_shader_tests() for SM1 profiles from the Vulkan runner (skipping execution for now), and some improvements to the qualifiers syntax. Despite this, there are parallel discussions on: - Whether to name the shader models individually in the [require] directives or expressing the range of shader models where the test should pass. In the latter case, whether to run for all shader models, only the lowest one in the SM1, SM4, and SM6 groups, or to allow the runner to select a shader model within the range (I feel strongly against this now, I think the runner should just retrieve a boolean in runner->check_requirements). - Where to do the iteration across different shader models, if in run_shader_tests() or expect each runner to call run_shader_tests() several times as we do now. But there is no need to settle on something for these yet. --- Now, what may be the most noisy part of this MR is that even though we are calling run_shader_tests() through the Vulkan runner, this will result in calling shader_runner.c:compile_shader() instead of shader_runner_vulkan.c:compile_shader(), but if we follow the "making the parser agnostic" plan, we eventually should get rid of shader_runner.c:compile_shader() and introduce the runner->compile pointer instead. -- v7: tests: Use the vulkan runner to run SM1 compilation tests. tests/shader-runner: Call each runner only once. tests/shader-runner: Support reading multiple model range args for qualifiers. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/514

4 12

[PATCH v5 0/2] MR4748: Don't test function directly when reporting GetLastError()
by André Zwing 05 Jan '24

05 Jan '24

-- v5: ntoskrnl/tests: Use RtlNtStatusToDosErrorNoTeb() for stateless conversion mscoree/tests: Don't test function directly when reporting GetLastError() https://gitlab.winehq.org/wine/wine/-/merge_requests/4748

2 3

[PATCH v6 0/2] MR4774: msvcrt: Compare environmental variable names case insensitively
by Zsolt Vadász 05 Jan '24

05 Jan '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56134 -- v6: msvcrt/tests: Test case insensitivity of getenv() and _wgetenv() msvcrt: Compare environmental variable names case insensitively https://gitlab.winehq.org/wine/wine/-/merge_requests/4774

4 5

[PATCH v2 0/1] MR536: vkd3d-shader/ir: Revert "Do not merge signature elements which have different interpolation modes."
by Conor McCarthy (＠cmccarthy) 05 Jan '24

05 Jan '24

-- v2: vkd3d-shader/ir: Revert "Do not merge signature elements which have different interpolation modes." https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/536

4 5

Re: [PATCH v4 0/5] MR464: vkd3d-shader/spirv: Declare I/O registers from the signature.
by Giovanni Mascellani (＠giomasce) 05 Jan '24

05 Jan '24

I discovered a similar instance in `test_shader_eval_attribute()`: ``` VUID-RuntimeSpirv-OpTypeVector-06816(ERROR / SPEC): msgNum: 79036675 - Validation Error: [ VUID-RuntimeSpirv-OpTypeVector-06816 ] Object 0: handle = 0x240000000024, type = VK_OBJECT_TYPE_SHADER_MODULE; Object 1: handle = 0x250000000025, type = VK_OBJECT_TYPE_SHADER_MODULE; | MessageID = 0x4b60103 | vkCreateGraphicsPipelines(): pCreateInfos[0] starting at Location 1 Component 0 the Output (VK_SHADER_STAGE_VERTEX_BIT) has a Vec4 while Input (VK_SHADER_STAGE_FRAGMENT_BIT) as a Vec2. Enable VK_KHR_maintenance4 device extension to allow relaxed interface matching between input and output vectors. The Vulkan spec states: Any OpTypeVector output interface variables must not have a higher Component Count than a matching OpTypeVector input interface variable (https://www.khronos.org/registry/vulkan/specs/1.2/html/vkspec.html#VUID-Run…) ``` Here again two different semantics are merged in the VS but not in the PS, which trigger a similar error. And again this seems to cause a failure in MoltenVK. The difference is that this doesn't seem to be related to 66cb2815f0662713c3255113255cfd7cf5e406fb, it also happened before. But maybe it's useful to know anyway. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/464#note_56768

1 0

[PATCH v9 0/4] MR519: vkd3d-shader/dxil: Support minimum precision.
by Conor McCarthy (＠cmccarthy) 05 Jan '24

05 Jan '24

-- v9: vkd3d-shader/dxil: Support 16-bit types. vkd3d-shader/spirv: Introduce HALF and UINT16 types for minimum precision. vkd3d-shader/spirv: Introduce a data_type_is_floating_point() helper function. tests/shader-runner: Add tests for minimum-precision constants. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/519

2 4