March 2024 - Wine-gitlab - list.winehq.org

Re: [PATCH v2 0/1] MR5326: urlmon: Add stub for 414 function. - approved
by Jacek Caban (＠jacek) 19 Mar '24

19 Mar '24

This merge request was approved by Jacek Caban. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5326

1 0

[PATCH 0/1] MR5354: ntdll/tests: Don't import kernel32.RtlPcToFileHeader.
by Jinoh Kang (＠iamahuman) 19 Mar '24

19 Mar '24

kernel32.RtlPcToFileHeader is an export forwarder to ntdll.RtlPcToFileHeader and does not exist on Windows 8 or earlier. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56458 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5354

2 1

[PATCH v3 0/8] MR5319: winemac.drv keyboard layout/dead key fixes
by Marc-Aurel Zent (＠mzent) 19 Mar '24

19 Mar '24

This is a series of commits tackling dead key state handling and scan code to vkey mapping improvements (especially for French and German keyboards). * https://gitlab.winehq.org/mzent/wine/-/commit/6c5c90b746cc341049eec216e3bb9…: Simplifies the logic a bit there and also correctly null-terminates dead keys in ToUnicodeEx * https://gitlab.winehq.org/mzent/wine/-/commit/a05e2fc5068a22cae94bc800b4972…: Windows does not do it and some applications misbehave with this, fully fixed later in https://gitlab.winehq.org/mzent/wine/-/commit/7cf1f6a00f17b0626126448f77a1c… * https://gitlab.winehq.org/mzent/wine/-/commit/4bd96932139a22f2c3b1311e44c43…: MSDN states single keys are always uppercased there. * https://gitlab.winehq.org/mzent/wine/-/commit/bac8e97d7e6a7494672d76f5fc586…: There is a bug in `CFStringCompare` with the flags used there currently, resulting in the comparison of the identical buffers "ß" and "ß" to be false. In any case `UCCompareText` behaves correctly and is much faster there. * https://gitlab.winehq.org/mzent/wine/-/commit/bac5f485a09fbddd39efb8f2c0d87…: I think this was an accidental mistake there, going through all modifiers first per symbol almost always results in the wrong match being made. The logic is adjusted there now to be similar to the other iterations involving `char_matches_string`. * https://gitlab.winehq.org/mzent/wine/-/commit/ffde55df4ae3f6d53198839c58356… https://gitlab.winehq.org/mzent/wine/-/commit/a453d0d4c89c59c3e1ba6c24d2d0f…: Adds additional symbol vkey mappings (now completely maps a German Macintosh and PC keyboard correctly). There are still some minor defects with the French layout (around the ú region), however changing the symbol mapping there will cause issues with other layouts I think, since the wrong match happens very early there in the priority in these cases. With this change at least the number row is now behaving correctly. Additionally the French Macintosh keyboard layout is further complicated by the "=" key being next to right shift, which is in conflict with pretty much any other keyboard layout. To fix this properly would require a partial rewrite of the heuristic being used or a new approach, but most likely more of a long term project. * https://gitlab.winehq.org/mzent/wine/-/commit/7cf1f6a00f17b0626126448f77a1c…: Gives dead keys friendly names in `GetKeyNameFriendlyText`, just like Windows does. I tried to be as exhaustive as possible, but if there are any missing the mapping can be easily extended. All in all the incorrect scan code to vkey mapping is usually not that tragic, since an application would need to be aware of the layout and have its own mapping of scan codes of each (FFXIV does this though). The French layout corrections are now "good enough" to behave correctly for all the hotbar slots being assigned there with these changes now though. -- v3: winemac.drv: Give dead keys a friendly name in GetKeyNameText. winemac.drv: Add additional French symbol vkeys. winemac.drv: Add additional German symbol vkeys. winemac.drv: Resolve symbol vkeys first without modifiers. winemac.drv: Use UCCompareText in char_matches_string. winemac.drv: Uppercase single keys in GetKeyNameText. https://gitlab.winehq.org/wine/wine/-/merge_requests/5319

2 9

[PATCH v4 0/3] MR5324: d3d9/tests: define enums outside of struct
by David Heidelberg (＠dh) 19 Mar '24

19 Mar '24

These two commits shouldn't change anything functional wise, but with minimal changes on wine side, they allow easy integration of d3d9/tests/visual.c into GoogleTest native runner. visual.c code is C++ compatible, except the `enums`. Second change is done, because we had to redefine `ok()` macro, so without proper braces around conditions it cannot be expanded to multiple lines. Here is [MR how we import](https://github.com/axeldavy/Xnine/pull/12) the `visual.c` Third commit just correct my name in the `.mailmap` My main goal here is bring code which run in Mesa3D CI workflow as closer to the original wine d3d9 tests, so we can easily update from wine and eventually provide also fixes and improvements back. If you find this MR suitable, we could try figure out a way, to incorporate data about [nine_todo](https://github.com/axeldavy/Xnine/commit/7ac97c8350ea5b2bfd7307c…, of course only if you find some use of these extra information. /cc @zfigura -- v4: mailmap: Add a mailmap entry for myself with the proper name d3d9/tests: replace LPDWORD cast with float_to_int function d3d9/tests: define enums outside of struct https://gitlab.winehq.org/wine/wine/-/merge_requests/5324

4 5

[PATCH v3 0/2] MR728: vkd3d-shader/dxil: Implement DX intrinsics Dot2, Dot3 and Dot4.
by Conor McCarthy (＠cmccarthy) 19 Mar '24

19 Mar '24

-- v3: vkd3d-shader/dxil: Implement DX intrinsics Dot2, Dot3 and Dot4. vkd3d-shader/dxil: Emit an error if a constant code is unhandled. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/728

3 4

[PATCH 0/2] MR5345: gdiplus: Calculate region bounding box without generating HRGN.
by Esme Povirk (＠madewokherd) 19 Mar '24

19 Mar '24

I wrote a test intending to find exactly how points are quantized when figuring the region bounding box, so I can make sure I don't break it. Surprisingly, I'm able to just pass in fractional values and get them back. Clearly this isn't based on any quantization. MSDN says "The rectangle returned by Region::GetBounds is not always the smallest possible rectangle." MSDN also says that the world and page transformations of the Graphics object are used, which doesn't seem to be the case, but I choose to selectively believe it when tests agree. So the rectangle we return must enclose the region, but it may be larger than necessary to enclose the region. This is conveniently exactly the same as the get_region_bounding_box function I wrote earlier. (While there may be implementation differences, I think we can worry about that if/when it becomes a problem. We already got by on something very different from native for a long time.) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5345

3 4

[PATCH v2 0/2] MR725: vkd3d-shader/dxil: Implement DX intrinsic MakeDouble.
by Conor McCarthy (＠cmccarthy) 19 Mar '24

19 Mar '24

-- v2: vkd3d-shader/dxil: Implement DX intrinsic MakeDouble. tests/hlsl: Add tests for asdouble(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/725

3 3

[PATCH v2 0/2] MR5269: Add NtQueryInformationProcess(ProcessQuotaLimits) stub
by Gijs Vermeulen (＠gverm) 19 Mar '24

19 Mar '24

Based on a patch by Qian Hong. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=44812 -- v2: ntdll: Add NtQueryInformationProcess(ProcessQuotaLimits) tests. ntdll: Add NtQueryInformationProcess(ProcessQuotaLimits) stub. https://gitlab.winehq.org/wine/wine/-/merge_requests/5269

4 5

[PATCH 0/2] MR5269: Add NtQueryInformationProcess(ProcessQuotaLimits) stub
by Gijs Vermeulen (＠gverm) 19 Mar '24

19 Mar '24

Based on a patch by Qian Hong. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=44812 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5269

4 7

[PATCH 0/1] MR5350: ntdll/tests: Load NtMakeTemporaryObject() dynamically.
by Hans Leidekker (＠hans) 19 Mar '24

19 Mar '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5350

2 1