- Wine-gitlab - list.winehq.org

[PATCH 0/1] MR422: riched20: Ensure MEPF_COMPLEX is unset when in password input mode. (#53335)
by Jinoh Kang (＠iamahuman) 12 Jul '22

12 Jul '22

This is required to keep `riched20:richole test_clipboard()` from crashing once `ITextDocument::Undo` is implemented. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/422

3 3

[PATCH 0/4] MR431: Support secpkg attr key info
by Hans Leidekker (＠hans) 12 Jul '22

12 Jul '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/431

2 4

[PATCH 0/1] MR429: dlls/ddraw/tests: fix missing bits from long type conversion
by eric pouech (＠epo) 12 Jul '22

12 Jul '22

(still wondering how this got unnoticed) Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/429

2 3

[PATCH 0/7] MR430: dbghelp improvements
by eric pouech (＠epo) 12 Jul '22

12 Jul '22

This series: - cleanups some code (using bitfield instead of hardcoded constants) - silences some FIXMEs in SymGetTypeInfo - fixes a couple of erroneous lexical relationship among dbghelp objects (mainly attaching - as native does - some objects to SymTagExe object) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/430

2 7

Re: [PATCH v2 0/4] MR47: kernel32/tests: Add tests for CancelSynchronousIo.
by Daniel Lehman (＠dlehman25) 11 Jul '22

11 Jul '22

On Mon Jul 11 15:14:43 2022 +0000, Jinoh Kang wrote: > How about the following race-free approach? > ```suggestion:-0+0 > /* wait for I/O to start, which transitions the pipe handle from > signaled to nonsignaled state. */ > while ((wait_status = WaitForSingleObject(pipe, 0)) == > WAIT_OBJECT_0) Sleep(1); > ok(wait_status == WAIT_TIMEOUT, "WaitForSingleObject returned %lu > (error %lu)\n", wait_status, GetLastError()); > ``` > Ditto for other places. i had copied the `Sleep(100)` from one of the sync.c tests, i think. but if it makes the test less flaky, i'll take it. thanks! -- https://gitlab.winehq.org/wine/wine/-/merge_requests/47#note_3919

1 0

[PATCH v2 0/4] MR428: wineusb.sys: PE conversion
by Zebediah Figura (＠zfigura) 11 Jul '22

11 Jul '22

-- v2: wineusb.sys: Move the event queue and device list to the Unix library. https://gitlab.winehq.org/wine/wine/-/merge_requests/428

2 4

Re: [PATCH v2 0/4] MR47: kernel32/tests: Add tests for CancelSynchronousIo.
by Daniel Lehman (＠dlehman25) 11 Jul '22

11 Jul '22

On Mon Jul 11 15:14:45 2022 +0000, Jinoh Kang wrote: > Per Wine code style, you should omit the second space in `&io ) )`. > ```suggestion:-0+0 > return set_ntstatus( NtCancelSynchronousIoFile( thread, NULL, &io )); > ``` the file has a mix of styles. it does look from a skim like most are without the space, but i think i copied from CancelIo and CancelIoEx right above it, and they both have the space. never quite sure what to do in those cases, but i can remove it -- https://gitlab.winehq.org/wine/wine/-/merge_requests/47#note_3917

1 0

Re: [PATCH v2 0/4] MR47: kernel32/tests: Add tests for CancelSynchronousIo.
by Daniel Lehman (＠dlehman25) 11 Jul '22

11 Jul '22

> Wait, what's partial about it? i don't handle the 2nd argument, but it doesn't seem to be used for what i need, though. i can implement the higher level kernel32 call without it what about something like this, copied from NtUnlockFile: ` TRACE( "(%p %p %p)\n", handle, io, io_status ); if (io) FIXME("Unimplemented yet parameter\n"); ` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/47#note_3914

2 1

Re: [PATCH v2 0/4] MR47: kernel32/tests: Add tests for CancelSynchronousIo.
by Daniel Lehman (＠dlehman25) 11 Jul '22

11 Jul '22

On Mon Jul 11 15:14:44 2022 +0000, Jinoh Kang wrote: > Maybe you forgot to remove the extraneous parentheses? you mean the parentheses around `(async->thread == thread)`? i can remove those -- https://gitlab.winehq.org/wine/wine/-/merge_requests/47#note_3913

1 0

[PATCH 0/4] MR428: wineusb.sys: PE conversion
by Zebediah Figura (＠zfigura) 11 Jul '22

11 Jul '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/428

2 4