- Wine-gitlab - list.winehq.org

[PATCH 0/2] MR1039: Schannel test
by Hans Leidekker (＠hans) 12 Oct '22

12 Oct '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1039

2 2

Re: [PATCH v2 0/2] MR1037: win32u: Add font link for MS UI Gothic.
by Huw Davies (＠huw) 12 Oct '22

12 Oct '22

Could you split the first commit further? Just make the code change with the commit msg something like "win32u: Add mechanism for font specific system links", but don't add the MS UI Gothic entries. A second commit would add the Gothic entries, and a third the additional Tahoma ones. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1037#note_10391

1 0

[PATCH v4 0/5] MR944: win32u: Make desktop resize logic asynchronous.
by Rémi Bernon 12 Oct '22

12 Oct '22

To avoid direct callbacks from display drivers to win32u while changing display settings. -- v4: winemac.drv: Resize desktop window on WM_DISPLAYCHANGE message. winex11.drv: Resize desktop window on WM_DISPLAYCHANGE message. win32u: Send WM_DISPLAYCHANGE message to the desktop window. winex11.drv: Send WM_X11DRV_CLIP_CURSOR_REQUEST message from the deskop. winex11.drv: Sync window positions in a WM_X11DRV_DESKTOP_RESIZED message. https://gitlab.winehq.org/wine/wine/-/merge_requests/944

2 9

[PATCH v2 0/1] MR962: wined3d: Use a Wine debug channel for vkd3d debug output.
by Alexandre Julliard (＠julliard) 12 Oct '22

12 Oct '22

-- v2: wined3d: Use a Wine debug channel for vkd3d debug output. https://gitlab.winehq.org/wine/wine/-/merge_requests/962

5 8

[PATCH v3 0/5] MR25: vkd3d-shader/hlsl: Implement asuint() and completely move init_node() to hlsl.c.
by Zebediah Figura (＠zfigura) 12 Oct '22

12 Oct '22

-- v3: vkd3d-shader/hlsl: Pass a location pointer to init_node(). vkd3d-shader/hlsl: Introduce a hlsl_new_expr() helper. vkd3d-shader/hlsl: Write SM4 reinterpret instructions. vkd3d-shader/hlsl: Parse the asuint() intrinsic. tests: Add a test for asuint(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/25

4 7

[PATCH 0/7] MR1034: msvcp140: Do not import from msvcp120.
by Paul Gofman (＠gofman) 12 Oct '22

12 Oct '22

The practical aspect of this (besides that msvcp140 just should not probably load msvcp120) is that for an app using VC runtime 140 mspcp140.__ExceptionPtrCurrentException gets the thread data from msvcp120.dll while vcruntime140_1 sets those thread data from ucrtbase.dll which are different data. So the application calling mspcp140.__ExceptionPtrCurrentException in catch block gets NULL exception while it was technically set by vcruntime140_1 before calling the app's catch block handler. After this patchset all the current exception data should end up in ucrtbase for VC runtime 140. There is a bit more to it (not covered by this patchset) when there is a mix of native and builtin VC runtime 140 dlls. From the app behaviour and some tests it looks like with native DLLs msvcp140 and vcruntime140_1 handle current exception data through vcruntime140.dll and vcruntime140.dll does not forward that to ucrtbase. I am not sure if the latter (not forwarding vcruntime140->ucrtbase) is practically important but to avoid the similar problem when mixing native and builtin VC runtime DLLs we should also probably link msvcp140 and vcruntime140_1 to vcruntime140. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1034

4 9

[PATCH 0/2] MR1038: Sapi datakey
by Alistair Leslie-Hughes (＠alesliehughes) 12 Oct '22

12 Oct '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1038

3 3

[PATCH 0/1] MR1015: wpcap: use UNIX 98/BSD 4.4 sockaddr header
by Marc-Aurel Zent (＠marzent) 12 Oct '22

12 Oct '22

Interpreting the fist two bytes of the `sockaddr` struct as `sa_family` produces incorrect behaviour on macOS and (presumbly) BSD. This change is however still backwards compatible with Linux since `sa_family` is of effective type `uint8_t` and `sa_len` is currently disregarded. For reference https://www.ibm.com/docs/en/i/7.3?topic=family-af-inet-address and this is from the <sys/socket.h> on macOS ``` /* * [XSI] Structure used by kernel to store most addresses. */ struct sockaddr { __uint8_t sa_len; /* total length */ sa_family_t sa_family; /* [XSI] address family */ char sa_data[14]; /* [XSI] addr value (actually larger) */ }; ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1015

5 12

Re: [PATCH 0/1] MR74: ntdll: Prevent double free (Coverity)
by Sven Baars (＠sbaars) 12 Oct '22

12 Oct '22

Sven Baars (@sbaars) commented about dlls/ntdll/unix/file.c: > if (size > 0x10000) size = 0x10000; > if ((tmpbuf = malloc( size ))) > { > + if (needs_close) close( fd ); > if (!server_get_unix_fd( handle, FILE_READ_DATA, &fd, &needs_close, NULL, NULL )) > { > int res = recv( fd, tmpbuf, size, MSG_PEEK ); > info->MessagesAvailable = (res > 0); > info->NextMessageSize = (res >= 0) ? res : MAILSLOT_NO_MESSAGE; > if (needs_close) close( fd ); I think you want to remove this one as well. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/74#note_10372

1 0

[PATCH 0/5] MR1001: winebuild: Reimplement dlltool for import lib and delay import lib generation.
by Rémi Bernon 12 Oct '22

12 Oct '22

This is slightly different from dlltool but I think it should be compatible. The transition is done by first replacing dlltool with its bugs, and fixing them in separate changes. I based the ARM / AARCH64 implementation on the existing code around, but I have no idea if it is correct, and dlltool also doesn't include any delay load implementation for ARM. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1001

2 7