- Wine-gitlab - list.winehq.org

Re: [PATCH v2 0/3] MR415: ddraw/tests: Build without -DWINE_NO_LONG_TYPES. - approved
by Alexandre Julliard (＠julliard) 11 Jul '22

11 Jul '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/415

1 0

[PATCH v3 0/1] MR423: ieframe fix
by David Kahurani (＠kahurani) 11 Jul '22

11 Jul '22

Signed-off-by: David Kahurani <k.kahurani(a)gmail.com> -- v3: ieframe: Fix memory leak in open_dde_url https://gitlab.winehq.org/wine/wine/-/merge_requests/423

3 2

[PATCH 0/1] MR424: ntdll: Add ".globl" for asm labels referenced from C.
by Brendan Shanks (＠bshanks) 11 Jul '22

11 Jul '22

Fixes syscall faults on 32-bit macOS. Spotted by Stefan D��singer. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/424

2 1

[PATCH v2 0/1] MR423: ieframe fix
by David Kahurani (＠kahurani) 11 Jul '22

11 Jul '22

Signed-off-by: David Kahurani <k.kahurani(a)gmail.com> -- v2: ieframe: Fix memory leak and possible reference leak https://gitlab.winehq.org/wine/wine/-/merge_requests/423

4 4

[PATCH 0/1] MR423: ieframe fix
by David Kahurani (＠kahurani) 11 Jul '22

11 Jul '22

Signed-off-by: David Kahurani <k.kahurani(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/423

3 2

Re: [PATCH v2 0/4] MR47: kernel32/tests: Add tests for CancelSynchronousIo.
by Jinoh Kang (＠iamahuman) 11 Jul '22

11 Jul '22

Jinoh Kang (@iamahuman) commented about dlls/kernelbase/file.c: > */ > BOOL WINAPI DECLSPEC_HOTPATCH CancelSynchronousIo( HANDLE thread ) > { > - FIXME( "(%p): stub\n", thread ); > - SetLastError( ERROR_CALL_NOT_IMPLEMENTED ); > - return FALSE; > + IO_STATUS_BLOCK io; > + > + return set_ntstatus( NtCancelSynchronousIoFile( thread, NULL, &io ) ); Per Wine code style, you should omit the second space in `&io ) )`. ```suggestion:-0+0 return set_ntstatus( NtCancelSynchronousIoFile( thread, NULL, &io )); ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/47#note_3876

1 0

Re: [PATCH v2 0/4] MR47: kernel32/tests: Add tests for CancelSynchronousIo.
by Jinoh Kang (＠iamahuman) 11 Jul '22

11 Jul '22

Jinoh Kang (@iamahuman) commented about server/async.c: > return woken; > } > > +static int cancel_blocking( struct process *process, struct thread *thread, client_ptr_t iosb ) > +{ > + struct async *async; > + int woken = 0; > + > +restart: > + LIST_FOR_EACH_ENTRY( async, &process->asyncs, struct async, process_entry ) > + { > + if (async->terminated || async->canceled) continue; > + if (async->blocking && (async->thread == thread) && Maybe you forgot to remove the extraneous parentheses? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/47#note_3875

1 0

Re: [PATCH v2 0/4] MR47: kernel32/tests: Add tests for CancelSynchronousIo.
by Jinoh Kang (＠iamahuman) 11 Jul '22

11 Jul '22

Jinoh Kang (@iamahuman) commented about dlls/kernel32/tests/pipe.c: > + > + SetLastError(0xdeadbeef); > + res = pCancelSynchronousIo(GetCurrentThread()); > + ok(!res, "CancelSynchronousIo succeeded unexpectedly\n"); > + todo_wine > + ok(GetLastError() == ERROR_NOT_FOUND, > + "In CancelSynchronousIo failure, expected ERROR_NOT_FOUND, got %ld\n", GetLastError()); > + > + /* synchronous i/o */ > + pipe = CreateNamedPipeA(PIPENAME, PIPE_ACCESS_DUPLEX, > + PIPE_TYPE_MESSAGE | PIPE_READMODE_MESSAGE | PIPE_WAIT, > + 1, 1024, 1024, NMPWAIT_USE_DEFAULT_WAIT, NULL); > + ok(pipe != INVALID_HANDLE_VALUE, "CreateNamedPipe failed with %lu\n", GetLastError()); > + thread = CreateThread(NULL, 0, synchronousIoThreadMain, pipe, 0, NULL); > + /* wait for thread to start listening */ > + Sleep(100); How about the following race-free approach? ```suggestion:-0+0 /* wait for I/O to start, which transitions the pipe handle from signaled to nonsignaled state. */ while ((wait_status = WaitForSingleObject(pipe, 0)) == WAIT_OBJECT_0) Sleep(1); ok(wait_status == WAIT_TIMEOUT, "WaitForSingleObject returned %lu (error %lu)\n", wait_status, GetLastError()); ``` Ditto for other places. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/47#note_3874

1 0

Re: [PATCH v2 0/4] MR47: kernel32/tests: Add tests for CancelSynchronousIo.
by Jinoh Kang (＠iamahuman) 11 Jul '22

11 Jul '22

> the test would hang on wine before the implementation is in place. Thanks! I missed that the current test cannot verify the Windows behaviour before the commit that introduces the Wine implementation. > the CloseHandle before the WaitForSingleObject is a workaround to get the thread to exit I'm afraid that closing a handle in use is racy by nature; it's effectively pulling the rug out from underneath. A better approach would be to use `CancelIoEx` on the `OVERLAPPED` structure, or `NtCancelIoFileEx` on the `IO_STATUS_BLOCK` structure to cancel the pending operation. > > moving the CloseHandle was meant to show that workaround is no longer needed and that it now performs like windows > > i can remove that if preferred -- https://gitlab.winehq.org/wine/wine/-/merge_requests/47#note_3873

1 0

[PATCH v3 0/2] MR360: Draft: winepulse.drv: add support for containerId property from sysfs path
by Claire (＠ClearlyClaire) 11 Jul '22

11 Jul '22

Some games with support for the haptic feedback and speaker features of the Sony DualSense controller select the controller's audio output by filtering on the ContainerId IMMDevice property to find one that matches the controller's HID's. This MR, together with !359, adds support for exposing such a ContainerId to applications. I marked this MR as a draft because I understand that the way the ��guid�� is generated is far from ideal. Furthermore, I will need to map from sysfs to container Id in other components as well (`winebus` for the HID device, and possibly `winealsa` and other audio drivers), so moving that part elsewhere would make sense. However, I think I will need help with those tasks. -- v3: winepulse: Add support for containerId property from sysfs path winepulse: Store PulseAudio device's sysfs path when available https://gitlab.winehq.org/wine/wine/-/merge_requests/360

2 2