January 2018 - Wine-Bugs - list.winehq.org

[Bug 44365] New: armel build fails: selected processor does not support `strd r4,[sp]' in ARM mode

by wine-bugs＠winehq.org

https://bugs.winehq.org/show_bug.cgi?id=44365 Bug ID: 44365 Summary: armel build fails: selected processor does not support `strd r4,[sp]' in ARM mode Product: Wine Version: 3.0-rc2 Hardware: x86 URL: https://buildd.debian.org/status/fetch.php?pkg=wine-de velopment&arch=armel&ver=3.0%7Erc3-1&stamp=1516136421& raw=0 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: ntdll Assignee: wine-bugs(a)winehq.org Reporter: jre.winesim(a)gmail.com Distribution: Debian Beginning with 3.0-rc2 Wine started to fail to build on armel in Debian again: gcc -c -o relay.o relay.c -I. -I../../include -D__WINESRC__ -D_NTSYSTEM_ -D_REENTRANT -fPIC -Wall \ -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wempty-body -Wignored-qualifiers \ -Wno-packed-not-aligned -Wshift-overflow=2 -Wstrict-prototypes -Wtype-limits \ -Wunused-but-set-parameter -Wvla -Wwrite-strings -Wpointer-arith -Wlogical-op -gdwarf-2 \ -gstrict-dwarf -Werror -Wdate-time -g -O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -specs=/usr/share/dpkg/no-pie-compile.specs -fstack-protector-strong -Wformat -Werror=format-security -march=armv5t -Wno-error -marm -mfloat-abi=soft [...] {standard input}: Assembler messages: {standard input}:51: Error: selected processor does not support `strd r4,[sp]' in ARM mode Makefile:521: recipe for target 'relay.o' failed make[2]: *** [relay.o] Error 1 make[2]: Leaving directory '/<<PKGBUILDDIR>>/dlls/ntdll' Makefile:13147: recipe for target 'dlls/ntdll' failed make[1]: *** [dlls/ntdll] Error 2 I put the link to the complete buildlog in the URL field. For now I only tested rc2 and rc3, but will do the rest the next days. Looking at the changes in dlls/ntdll/ I don't expect any existing fixes, so I guess it's better to report as soon as possible. I didn't bisect the issue but assume it's in these commits: 5e3534ee411a8c5baea5022705eac0e3c7f3cc70 8a07ee48fa96e12474cb6f7c1d365858aaebcdff f492efdb3c77f015247f6b73d98110a0353035b3 d147c4c3239a367381ac5dbccbc1cab40699fedb btw, Wine 3.0-rc1 built fine again on armel in Debian. Thanks for taking care of #44010! Greets jre -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

Jan. 16, 2018

[Bug 43847] Just Cause 2 and 3 require WINED3D_RS_MULTISAMPLEMASK 0xffff

by wine-bugs＠winehq.org

https://bugs.winehq.org/show_bug.cgi?id=43847 --- Comment #3 from Matteo Bruni <matteo.mystral(a)gmail.com> --- (In reply to BieHDC from comment #2) > Since both of those games have other remaining graphical issues, i cant tell > if this one exactly produces a visual difference. That's my point. It seems more useful to me to have a bug concerning some specific graphical issue and work from there rather than picking some fixme from the Wine log and claim that it is an actual issue for the game. Now WRT this bug, if some developer (e.g. Józef, most likely :P) thinks that having a bug for the sample mask is useful then, of course, he can just reopen it. But they knew that already. > Other masks are already implemented. This one is maybe not so often used > which is why it has not been added yet? I think it's just that it's new to d3d10+ and nobody has yet had the need / time to implement it in wined3d. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

Jan. 16, 2018

[Bug 11846] tablet pressure sensitivity not working in Sai and many other key graphic applications

by wine-bugs＠winehq.org

https://bugs.winehq.org/show_bug.cgi?id=11846 Fabian Maurer <dark.shadow4(a)web.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|xixsimplicityxix(a)gmail.com |wine-bugs(a)winehq.org --- Comment #78 from Fabian Maurer <dark.shadow4(a)web.de> --- > Latest SAI won't even launch on wine 3.0rc6-1 (no change since my last > report basically Common issue, needs win98. Since it's been ten years assigned without fix, I'll reset the assignee. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

Jan. 16, 2018

[Bug 31278] The Longest Journey: "eye-mouth-hand" dialog not displaying correctly

by wine-bugs＠winehq.org

https://bugs.winehq.org/show_bug.cgi?id=31278 ru.martinez(a)gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ru.martinez(a)gmail.com --- Comment #6 from ru.martinez(a)gmail.com --- Confimed bug still present, rendering the game unplayable. Using The Longest Journey from GOG.com. Runtime: CrossOver 17.0.0.31291 (which includes wine 2.8 in theory) System: MacOS 10.13.2 (17C88) Kernel Version: Darwin 17.3.0 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

Jan. 16, 2018

[Bug 43252] IcmpSendEcho doesn't work with a ReplySize<56

by wine-bugs＠winehq.org

https://bugs.winehq.org/show_bug.cgi?id=43252 --- Comment #4 from Mark Mankins <Mark.Mankins(a)ngc.com> --- Created attachment 60273 --> https://bugs.winehq.org/attachment.cgi?id=60273 Test driver for IcmpSendEcho This program sends an icmp echo request to localhost and outputs the data returned to the caller. This program expects a single argument, the number of bytes to send in the icmp echo request payload. For the current version of wine (3.0rc6), for small values of the payload, wine fails to recognize the icmp echo response. For larger values of the payload, wine recognizes the response but doesn't return the complete payload to the caller. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

Jan. 16, 2018

[Bug 43252] IcmpSendEcho doesn't work with a ReplySize<56

by wine-bugs＠winehq.org

https://bugs.winehq.org/show_bug.cgi?id=43252 --- Comment #3 from Mark Mankins <Mark.Mankins(a)ngc.com> --- Ok...I'm happy to report that I think my analysis is basically correct. My test program proves that for small values of RequestSize passed to IcmpSendEcho, wine incorrectly ignores the icmp echo response. For large values passed to IcmpSendEcho, wine will handle the icmp echo response, but it will not pass back the complete payload to the caller. If the caller attempts to validate that the echo response matches the echo request (for any value of RequestSize), the validation will fail. I will attach my test program to this issue. Here is what I am seeing. Unpatched (unmodified source tree): osboxes(a)osboxes:~/wine64-build$ ./wine /mnt/hgfs/Shared/EchoTest/EchoTest.exe 55 Pinging localhost with 55 bytes of data... Address: 127.0.0.1 DataSize: 35 Echo data mismatch, byte 35 RoundTripTime: 0 Status: 0 osboxes(a)osboxes:~/wine64-build$ ./wine /mnt/hgfs/Shared/EchoTest/EchoTest.exe 20 Pinging localhost with 20 bytes of data... Address: 127.0.0.1 DataSize: 0 Echo data mismatch, byte 0 RoundTripTime: 0 Status: 0 osboxes(a)osboxes:~/wine64-build$ ./wine /mnt/hgfs/Shared/EchoTest/EchoTest.exe 17 Pinging localhost with 17 bytes of data... Unexpected result: 0 Patched with my patch in an earlier comment: osboxes(a)osboxes:~/wine64-build$ ./wine /mnt/hgfs/Shared/EchoTest/EchoTest.exe 55 Pinging localhost with 55 bytes of data... Address: 127.0.0.1 DataSize: 55 RoundTripTime: 0 Status: 0 osboxes(a)osboxes:~/wine64-build$ ./wine /mnt/hgfs/Shared/EchoTest/EchoTest.exe 20 Pinging localhost with 20 bytes of data... Address: 127.0.0.1 DataSize: 20 RoundTripTime: 0 Status: 0 osboxes(a)osboxes:~/wine64-build$ ./wine /mnt/hgfs/Shared/EchoTest/EchoTest.exe 17 Pinging localhost with 17 bytes of data... Address: 127.0.0.1 DataSize: 17 RoundTripTime: 0 Status: 0 -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

Jan. 16, 2018

[Bug 33660] Keyboard's numbers didn' t respond on call votes and switching weapons or casting spells

by wine-bugs＠winehq.org

https://bugs.winehq.org/show_bug.cgi?id=33660 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|directx-d3d |winex11.drv -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

Jan. 16, 2018

[Bug 33660] Keyboard's numbers didn' t respond on call votes and switching weapons or casting spells

by wine-bugs＠winehq.org

https://bugs.winehq.org/show_bug.cgi?id=33660 gulain(a)gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gulain(a)gmail.com --- Comment #8 from gulain(a)gmail.com --- I've got the issue with Vampire the Masquerade: Bloodlines. Reverting 43984f355a2905e16075a9df3d7fbe463761e853 fixes it. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

Jan. 16, 2018

[Bug 43252] IcmpSendEcho doesn't work with a ReplySize<56

by wine-bugs＠winehq.org

https://bugs.winehq.org/show_bug.cgi?id=43252 --- Comment #2 from Mark Mankins <Mark.Mankins(a)ngc.com> --- Upon further review, my analysis is not quite correct... stand by for a correction. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

Jan. 16, 2018

[Bug 43252] IcmpSendEcho doesn't work with a ReplySize<56

by wine-bugs＠winehq.org

https://bugs.winehq.org/show_bug.cgi?id=43252 Mark Mankins <Mark.Mankins(a)ngc.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Mark.Mankins(a)ngc.com --- Comment #1 from Mark Mankins <Mark.Mankins(a)ngc.com> --- This bug affects IDA Pro (Floating License) v 7.0. When IDA Pro is run for the first time, it sends an icmp echo request to the floating license server. The icmp payload is set to a length of 17 bytes. IcmpSendEcho() incorrectly calculates the expected size of the icmp echo reply. Here's the pertinent code: ip_header=(struct ip *) ((char *) ReplyBuffer+sizeof(ICMP_ECHO_REPLY)); endbuf=(char *) ReplyBuffer+ReplySize; maxlen=ReplySize-sizeof(ICMP_ECHO_REPLY); [snip] res=recvfrom(icp->sid, (char*)ip_header, maxlen, 0, (struct sockaddr*)&addr,&addrlen); TRACE("received %d bytes from %s\n",res, inet_ntoa(addr.sin_addr)); ip_header is set to be a pointer ICMP_ECHO_REPLY characters past the start of ReplyBuffer. This appears to be incorrect and a contributor to the issue. The calculation of endbuf seems to be correct. This the end of the buffer that receives the echo reply packet. In my initial example, maxlen will be set to 25 bytes. The actual size of the icmp echo reply packet is 45 bytes. 20 bytes for the ip header, 8 bytes for the icmp header, and 17 bytes for the icmp data. maxlen should be 45 bytes to fully read the entire reply packet. Since only 25 bytes is read, the entire icmp header will not be read, and wine will incorrectly drop the icmp echo reply packet. I believe this diff corrects the issue: diff --git a/dlls/iphlpapi/icmp.c b/dlls/iphlpapi/icmp.c index ebc2f2b..8bfdf25 100644 --- a/dlls/iphlpapi/icmp.c +++ b/dlls/iphlpapi/icmp.c @@ -367,9 +367,9 @@ DWORD WINAPI IcmpSendEcho( fdr.events = POLLIN; addrlen=sizeof(addr); ier=ReplyBuffer; - ip_header=(struct ip *) ((char *) ReplyBuffer+sizeof(ICMP_ECHO_REPLY)); + ip_header=(struct ip *) ((char *) ReplyBuffer); endbuf=(char *) ReplyBuffer+ReplySize; - maxlen=ReplySize-sizeof(ICMP_ECHO_REPLY); + maxlen=ReplySize; /* Send the packet */ TRACE("Sending %d bytes (RequestSize=%d) to %s\n", reqsize, RequestSize, inet_ntoa(addr.sin_addr)); ip_header should be set to be the start of the ReplyBuffer. This is the start of the buffer recvfrom should write to. It should be large enough to hold the ip header, the icmp header, and the icmp payload. With this diff applied, IDA Pro runs as expected. I will attempt to create a simple console application that replicates this bug. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

Jan. 16, 2018