June 2018 - Wine-Bugs - list.winehq.org

[Bug 35533] Make it possible to see the sent patch files inline without extra download step

by wine-bugs＠winehq.org

https://bugs.winehq.org/show_bug.cgi?id=35533 --- Comment #5 from François Gouget <fgouget(a)codeweavers.com> --- On the JobDetails page one can download two types of files: * Patches * The resulting Windows executables (or those uploaded by the developer). GetFile.pl used to indiscriminately return application/octet-stream. Now it sets the MIME type to test/plain for patches so the browser typically offers opening them in a text editor (at least that's what happens in Firefox). It's maybe not quite as nice as viewing the patch inline but it's still better than the previous situation. commit 6dde8de8257a1333a8951a0e6cd11f5f41e01d80 Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Tue Jun 26 13:40:47 2018 +0200 testbot/web: Adjust the GetFile MIME type based on Step->FileType. This lets the browser offer to open the patches in a text editor instead of systematically suggesting to save them to disk. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

June 26, 2018

[Bug 40694] Invalid behavior of "C: && echo haha" or "C: & echo haha"

by wine-bugs＠winehq.org

https://bugs.winehq.org/show_bug.cgi?id=40694 Jason Edmeades <us(a)edmeades.me.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |us(a)edmeades.me.uk --- Comment #9 from Jason Edmeades <us(a)edmeades.me.uk> --- That patch is wrong - you need to keep spaces, otherwise something simple like "echo abc >a.a" gives different output (it should keep the spaces). I think it needs to be handled elsewhere, will take a look (In addition the patch should be WCHAR *tend = command + *commandLen - 1; (not +1) otherwise nothing works) I'll try to take a look -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

June 26, 2018

[Bug 45025] Multi-dll patches vs patches website

by wine-bugs＠winehq.org

https://bugs.winehq.org/show_bug.cgi?id=45025 François Gouget <fgouget(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #1 from François Gouget <fgouget(a)codeweavers.com> --- This is done. This is the result of a long patch series that reworked the Build.pl script to rely more on the Wine makefiles, and on the move of the patch parser to the new PatchUtils.pm module so that Build.pl can know which tests to rebuild. The list below has the most important patches (some may be missing). commit 6fbd57b4f50c5a39e394dfbf0f97662e8a15a226 Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Wed Jun 13 10:23:42 2018 +0200 testbot: Create a single Job per patch even for multiple modules. So far a build task could only provide the 32 and 64 bit test executables for a single dll or program. Also, because of the lack of proper dependency support between steps it was impossible to have multiple build steps. So the TestBot used to create one job per module. However the patch status site can only keep track of one job per patch. This means some failures could be missed if they did not happen in the one job tracked by the patch status site. Now that Build.pl rebuilds all the impacted test executables the Testbot systematically creates a single job and a single build task and retrieves all the test executables in one go. This also has the advantage of reducing the number of VM reverts. Another side-effect of this change is that if the patch modifies the tests of multiple modules and the compilation of one them fails, no test will be run. Before only the tests impacted by the failed compilation would have been skipped. However a compilation error is grounds for resubmitting the patch, at which time the tests will be rerun anyway. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> commit fb84879ce70a0ad379bc779a5c9c1c1483443874 Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Wed Jun 13 10:23:28 2018 +0200 testbot: Remove the unneeded Build.pl parameters. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> commit 15ab1a7995221e0b93bdf9c3fc4dccb8bf461109 Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Tue Jun 12 11:52:13 2018 +0200 testbot/build: Always rebuild all the impacted test executables. This means Build.pl no longer needs the PatchType and BaseName parameters. But still keep support for them for compatibility with WineRunBuild.pl. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> commit 6521df329b7b38d55f3d84ad7783097ee97ef382 Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Thu May 31 10:06:10 2018 +0200 testbot: Fix handling of test unit additions/removals in patch series. The TestBot used to only analyse the last patch in the series to determine whether it impacts the tests or not. However patches to resource files and helper dlls require having an up-to-date list of the test units, and that list may be impacted by previous patches in the series. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> commit f9501a1f91a5e2a5da2649d1e74ca678c950d375 Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Wed May 30 08:05:35 2018 +0200 testbot/build: Fix handling of directory addition / removal. When a directory is added or removed we must re-run make_makefiles. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> commit aa2a4355b05cdcbbc5f0a1184859f0eeaa6c83c1 Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Wed May 30 08:05:15 2018 +0200 testbot/build: Always rebuild the native tools. It does not take long and it is actually hard to really know when to rebuild them if taking into account their libs/ and include/ dependencies. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> commit 4bf681b11dfafa2dd7f9f769e957d0fa5b6b43ec Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Tue May 29 00:42:49 2018 +0200 testbot: Fix handling of test unit deletion + helper dll patch. Take into account deleted test units when getting the full test unit list. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> commit 6641ea6dea6368169786b3018525abb9f23775fa Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Tue May 29 00:42:30 2018 +0200 testbot/build: Simplify Build.pl by reusing the patch analyser. Also better identify patches that require rebuilding the native tools. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> commit 603027bebc8d118f767e5cf83eb17246258bf9e9 Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Mon May 28 15:09:15 2018 +0200 testbot/build: Rely on Wine's makefiles and simplify Build.pl. Assume the dependencies in Wine's makefiles work and let them decide whether to re-run configure, update include files or rebuild some dlls before the test executable, etc. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> commit 569b5f5b47fdfc0d37f9e8139d3ad4e31be60412 Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Mon May 28 15:06:14 2018 +0200 testbot/build: Add support for test helper dlls and make the patch parser reusable. Don't mistake the helper dlls C source files for test units. Also correctly handle patches that add or remove (i.e. rename) a resource file or helper dll. And move the patch parser to its own module so it can be reused, including by processes that don't use / have access to the database. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

June 26, 2018

[Bug 40706] FolderMerger cmd not valued, xcopy needs /k support

by wine-bugs＠winehq.org

https://bugs.winehq.org/show_bug.cgi?id=40706 Jason Edmeades <us(a)edmeades.me.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|FolderMerger cmd not |FolderMerger cmd not |valued, xcopy problem in |valued, xcopy needs /k |batch |support CC| |us(a)edmeades.me.uk -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

June 26, 2018

[Bug 44708] Keep past logs if a test is rerun

by wine-bugs＠winehq.org

https://bugs.winehq.org/show_bug.cgi?id=44708 François Gouget <fgouget(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #1 from François Gouget <fgouget(a)codeweavers.com> --- This is done: commit 4a5427158020506ae6de2b05134ee5f33cbbf734 Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Tue May 15 09:08:24 2018 +0200 testbot: Keep the old logs around. This helps figure out why the test was rerun: was it because it timed out the first time around? Because there was a network glitch? Or because the TestBot script got stuck or died unexpectedly? The error message in the old logs will make it clear. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

June 26, 2018

[Bug 43234] Allow users to show all full logs

by wine-bugs＠winehq.org

https://bugs.winehq.org/show_bug.cgi?id=43234 François Gouget <fgouget(a)codeweavers.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #2 from François Gouget <fgouget(a)codeweavers.com> --- It's now possible to expand more than one log or screenshot at a time. Expanding / contracting a log or screenshot still requires a reload. This will have to wait for another time. commit b0e2d37d418a7fdb038f4f0f7c6fc0fc168a00a7 Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Wed Jun 20 02:46:51 2018 +0200 testbot/web: Allow showing multiple job screenshots and logs. It's now possible to have the job details page show multiple screenshots and multiple logs. Once a screenshot / log is shown, the link can be clicked again to hide it. The code can also more easily be extended to handle more log files. The code inserting the links is simpler too. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

June 26, 2018

[Bug 42931] CMD START: invalid argument

by wine-bugs＠winehq.org

https://bugs.winehq.org/show_bug.cgi?id=42931 Jason Edmeades <us(a)edmeades.me.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |us(a)edmeades.me.uk Status|UNCONFIRMED |RESOLVED --- Comment #2 from Jason Edmeades <us(a)edmeades.me.uk> --- I think this is already fixed. I tested this with: wine cmd start "" notepad.exe This starts notepad fine Z:\wine\programs\cmd>START "" notepad 0057:fixme:exec:SHELL_execute flags ignored: 0x00000100 Z:\wine\programs\cmd>START "" c:\windows\system32\notepad.exe 005b:fixme:exec:SHELL_execute flags ignored: 0x00000100 At a guess (and I havent put it in the fixed by field as I am not certain) its resolved by 9baceabb88e2aeb90a32bb5f6923107904ed58ea Resolving as fixed, but please reopen if the problem persists. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

June 26, 2018

[Bug 30713] Microsoft Visual C++ 64-bit redistributables get incorrectly installed into SysWOW64 (system directory for 32-bit files) when run under 64-bit Wine

by wine-bugs＠winehq.org

https://bugs.winehq.org/show_bug.cgi?id=30713 Michael Stefaniuc <mstefani(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |3.0.x -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

June 26, 2018

[Bug 44976] ConEmu-Maximus5 Windows console emulator causes crash of builtin ' wineconsole.exe' (division by zero)

by wine-bugs＠winehq.org

https://bugs.winehq.org/show_bug.cgi?id=44976 Michael Stefaniuc <mstefani(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |3.0.x -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

June 26, 2018

[Bug 43607] Akiba' s Trip Undead & Undressed requires MFStartup to return S_OK.

by wine-bugs＠winehq.org

https://bugs.winehq.org/show_bug.cgi?id=43607 Michael Stefaniuc <mstefani(a)winehq.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |3.0.x -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

June 26, 2018