August 2018 - Wine-Bugs - list.winehq.org

[Bug 14078] Rewrite typelib marshaller on top of NDR functions

by wine-bugs＠winehq.org

https://bugs.winehq.org/show_bug.cgi?id=14078 Zebediah Figura <z.figura12(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |z.figura12(a)gmail.com Assignee|wine-bugs(a)winehq.org |z.figura12(a)gmail.com --- Comment #10 from Zebediah Figura <z.figura12(a)gmail.com> --- Created attachment 62098 --> https://bugs.winehq.org/attachment.cgi?id=62098 eponymous rewrite I've attached a set of patches, in a hopefully reviewable state, that perform this task. These patches pass all of the currently existing tests in oleaut32. I haven't yet done exhaustive testing with real-world programs, partly because I don't know any real-world programs to test with. If anyone does, please let me know. Currently there are two problems with these patches: (1) Patch 0010 embeds an automatically generated type format string into the file itself. This is suboptimal: we'd like that string to be automatically generated, but it's not clear how to do that. Adding a dummy IDL and accessing its exported variables from ndr_typelib.c doesn't give us all that we need (in particular, we can get the address of the type format string itself, and the offsets of the Automation types, but we have no way of getting the string's length). Including the generated .c file inside of ndr_typelib.c won't work because it'll result in multiple definitions. (2) shell32:shelldispatch fails. It fails because the implementation given here (in particular patch 0012) always delegates proxy methods to parents if they aren't IUnknown, and that runs into bug 45673 when we call IWebBrowser2_get_Application() [line 1128]. I don't know how to solve bug 45673, so I'd really appreciate advice there. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

Aug. 19, 2018

[Bug 45673] New: Calling delegated proxy methods returns 0x800706b5 ( RPC_S_UNKNOWN_IF), "err:rpc: RpcAssoc_BindConnection syntax {xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx}, 0.0 not supported"

by wine-bugs＠winehq.org

https://bugs.winehq.org/show_bug.cgi?id=45673 Bug ID: 45673 Summary: Calling delegated proxy methods returns 0x800706b5 (RPC_S_UNKNOWN_IF), "err:rpc:RpcAssoc_BindConnection syntax {xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx}, 0.0 not supported" Product: Wine Version: 3.14 Hardware: x86 OS: Linux Status: NEW Severity: normal Priority: P2 Component: ole32 Assignee: wine-bugs(a)winehq.org Reporter: z.figura12(a)gmail.com Distribution: --- Created attachment 62097 --> https://bugs.winehq.org/attachment.cgi?id=62097 test program The test program demonstrates the problem fairly clearly. In Wine, IShellBrowser delegates proxy methods to its parent IOleWindow. If you obtain a proxy to an IShellBrowser (e.g. via ShellWindows) you can call IShellBrowser methods without difficulty, but the RPC runtime will throw up RPC_S_UNKNOWN_IF if you try to call IOleWindow methods: 0009:err:rpc:RpcAssoc_BindConnection syntax {00000114-0000-0000-c000-000000000046}, 0.0 not supported 0009:fixme:ole:NdrClearOutParameters (0x61fc7c,0x7ebc63c6,0x61fdb0): stub got 0x800706b5 (N.b. 00000144-etc. is the IID of IOleWindow.) However, after you query for IOleWindow, calling IOleWindow methods on the original IShellBrowser interface will succeed. The underlying problem is this: When an interface is marshalled by ole32, it creates a stub on the server side and then registers that stub with rpcrt4. The interface ID that is used in RpcServerRegisterIf() is the IID of the interface itself, in this case IID_IShellBrowser. The stub creation functions live in rpcrt4 and end up delegating some methods to the stub of IOleWindow, which is different (e.g. it lives in ole32 instead of actxprxy). However, this stub never is registered with rpcrt4. When the program calls proxy methods, the proxy goes through ndr_client_call() -> NdrProxyGetBuffer() -> ClientRpcChannelBuffer_GetBuffer() [in ole32/rpc.c] -> I_RpcGetBuffer(). NdrProxyGetBuffer() passes the IID of the proxied interface to IRpcChannelBuffer_GetBuffer(), and that interface is eventually used by rpcrt4 as the ifid for the transaction. When that interface is IID_IShellBrowser, the server will recognize it, and the transaction works fine. However, when the program calls IOleWindow proxy methods, the proxy object is 'swapped out' (by the assembly thunks in fill_delegated_proxy_table()) and so the IID that NdrProxyGetBuffer() passes is the IID of the *parent* interface. Since this interface was never registered with RPC on the server side, the server refuses connection ("syntax not supported") and the proxy call fails. As a corollary, if you query that parent interface—even if you then throw away the resulting proxy—it will have been registered on the server side, and so calls to the delegated methods on the original object will miraculously start to succeed. I don't know what the correct way is to solve this problem. As far as I understand it's not something that can be tested—all of this is quite deep inside of OLE/RPC implementation details. It doesn't seem like there's any appropriate place to tell OLE about the delegated stub, at least not given the current infrastructure, and I'm not sure how RPC could appropriately inform OLE about the stub location. On the other hand I'd guess that maybe the child IID (i.e. IID_IShellBrowser) should be passed somewhere along the line on the client side; i.e. the standard proxy implementation should store the original IID inside the delegated proxy, and that original IID should be used by NdrProxyGetBuffer(). -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

Aug. 19, 2018

[Bug 44592] Arx Fatalis does not run (steam only)

by wine-bugs＠winehq.org

https://bugs.winehq.org/show_bug.cgi?id=44592 --- Comment #1 from Wylda <wylda(a)volny.cz> --- Still present in wine-3.14. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

Aug. 19, 2018

[Bug 27679] Arx Fatalis does not play intro movie (video: indeo 5.0)

by wine-bugs＠winehq.org

https://bugs.winehq.org/show_bug.cgi?id=27679 --- Comment #9 from Wylda <wylda(a)volny.cz> --- Still present in wine-3.14. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

Aug. 19, 2018

[Bug 21161] Still Life 2 Demo: Black and broken textures

by wine-bugs＠winehq.org

https://bugs.winehq.org/show_bug.cgi?id=21161 --- Comment #39 from Wylda <wylda(a)volny.cz> --- Still present in wine-3.14. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

Aug. 19, 2018

[Bug 26445] URLDownloadToFileW does not support FTP URLs

by wine-bugs＠winehq.org

https://bugs.winehq.org/show_bug.cgi?id=26445 --- Comment #10 from André H. <nerv(a)dawncrow.de> --- (In reply to Austin English from comment #9) > @Andre, might reviewing your patch and resubmitting? luckily ftp is less common meanwhile :) the test executable doesn't work anymore because of mozilla has shut down its ftp server for example. This means you can't do much with autohotkey here i guess. So we'd need a file on our ftp server with spaces in its name (IIRC that was the problem) to add a testcase. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

Aug. 19, 2018

[Bug 45672] New: FileOpenAssociations\Enable should be disabled by default

by wine-bugs＠winehq.org

https://bugs.winehq.org/show_bug.cgi?id=45672 Bug ID: 45672 Summary: FileOpenAssociations\Enable should be disabled by default Product: Wine Version: 3.14 Hardware: x86 OS: Linux Status: NEW Severity: normal Priority: P2 Component: programs Assignee: wine-bugs(a)winehq.org Reporter: dimesio(a)earthlink.net Distribution: --- Wine-3.14 introduced a new checkbox in winecfg to easily disable managing of filetype associations (bug 19182). However, having the value enabled by default means that when a user runs winecfg for the first time in a wineprefix in order to disable it, winemenubuilder will create filetype associations for Wine's builtin programs, and users will have to manually remove them. The default setting should be disabled. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

Aug. 19, 2018

[Bug 42795] LEGO City Undercover crashes on startup without native d3dcompiler_46.dll (Steam, DX11, purist)

by wine-bugs＠winehq.org

https://bugs.winehq.org/show_bug.cgi?id=42795 --- Comment #3 from Wylda <wylda(a)volny.cz> --- Still present in wine-3.14. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

Aug. 19, 2018

[Bug 45663] winetricks dotnet40 hangs with 0040:err:msiexec: custom_action_server Failed to create custom action server pipe: 231

by wine-bugs＠winehq.org

https://bugs.winehq.org/show_bug.cgi?id=45663 --- Comment #5 from farmboy0+winehq(a)googlemail.com --- I can confirm that installation of dotnet40 proceeds and succeeds with this patch. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

Aug. 19, 2018

[Bug 43188] Native comctl32 v5 dll causes applications to crash on unimplemented function comctl32.dll.HIMAGELIST_QueryInterface in File Open dialog (unsupported config)

by wine-bugs＠winehq.org

https://bugs.winehq.org/show_bug.cgi?id=43188 Anastasius Focht <focht(a)gmx.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|GeneDoc crashes in File |Native comctl32 v5 dll |Open dialog when using |causes applications to |native comctl32 v5 dll |crash on unimplemented |(unsupported config) |function | |comctl32.dll.HIMAGELIST_Que | |ryInterface in File Open | |dialog (unsupported config) --- Comment #14 from Anastasius Focht <focht(a)gmx.net> --- Hello folks, refining the ticket summary to collect more dupes here and improve search quality. Regards -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

Aug. 19, 2018