October 2022 - Wine-Bugs - list.winehq.org

[Bug 53766] vbscript fails to handle SAFEARRAY assignment, access, UBounds, LBounds

by WineHQ Bugzilla

https://bugs.winehq.org/show_bug.cgi?id=53766 --- Comment #1 from Jason Millard <jsm174(a)gmail.com> --- btw, all the code for this project is at: https://github.com/jsm174/vpvr/tree/feature/standalone/inc/wine It can be compiled and debugged under VSCode on mac with CMaketools (and hopefully soon linux). brew install sdl2 sdl2_ttf freeimage bison git clone -b feature/standalone https://github.com/jsm174/vpvr cd vpvr cp cmake/CMakeLists_osx-x64.txt CMakeLists.txt cmake -B build cmake --build build cd build ./VPinballX_GL -play ../res/exampleTable.vpx -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

Oct. 8, 2022

[Bug 53767] vbscript fails to handle ReDim when variable is not yet created

by WineHQ Bugzilla

https://bugs.winehq.org/show_bug.cgi?id=53767 Nikolay Sivov <bunglehead(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Ever confirmed|0 |1 Status|UNCONFIRMED |NEW --- Comment #1 from Nikolay Sivov <bunglehead(a)gmail.com> --- Confirming. It should be easy to fix in interp_redim(). lookup_identifier() never fails apparently, missing symbol in case of redim() will result in REF_NONE type, when that happens we could probably create a new array variable on a spot. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

Oct. 8, 2022

[Bug 53767] New: vbscript fails to handle ReDim when variable is not yet created

by WineHQ Bugzilla

https://bugs.winehq.org/show_bug.cgi?id=53767 Bug ID: 53767 Summary: vbscript fails to handle ReDim when variable is not yet created Product: Wine Version: 7.16 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: vbscript Assignee: wine-bugs(a)winehq.org Reporter: jsm174(a)gmail.com Distribution: --- While working on leveraging the vbscript engine of Wine for a macos/linux port of Visual Pinball, I finally have the example table working and am starting to work through the runtime errors. Since the table scripts are often copies of copies of copied code, sometimes bad practices make their way in. Take the following code: Const tnob = 5 ' total number of balls ReDim rolling(tnob) This works in real vbscript, but fails here. As a work around, I've updated the script to: Const tnob = 5 ' total number of balls Dim rolling() ReDim rolling(tnob) According to the rules I've found: It's possible to create a new dynamic array within a procedure using the ReDim statement if the array to which it refers doesn't already exist at either module or level. Typically, this results from an error of omission; the programmer forgets to explicitly define the array using Dim, Public, or Private. Since this method of creating an array can cause conflicts if a variable or array of the same name is subsequently defined explicitly, ReDim should be used only to redimension an existing array, not to define a new one. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

Oct. 8, 2022

[Bug 53766] vbscript fails to handle SAFEARRAY assignment, access, UBounds, LBounds

by WineHQ Bugzilla

https://bugs.winehq.org/show_bug.cgi?id=53766 Jason Millard <jsm174(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jsm174(a)gmail.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

Oct. 8, 2022

[Bug 53766] New: vbscript fails to handle SAFEARRAY assignment, access, UBounds, LBounds

by WineHQ Bugzilla

https://bugs.winehq.org/show_bug.cgi?id=53766 Bug ID: 53766 Summary: vbscript fails to handle SAFEARRAY assignment, access, UBounds, LBounds Product: Wine Version: 7.16 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: vbscript Assignee: wine-bugs(a)winehq.org Reporter: jsm174(a)gmail.com Distribution: --- While working on leveraging the vbscript engine of Wine for a macos/linux port of Visual Pinball, I finally have the example table working and am starting to work through the runtime errors. The table script requests an array of balls on the table and uses that array to drop ball shadows and generate rolling sounds. Take the following code: Const tnob = 5 Dim rolling() ReDim rolling(tnob) Sub RollingTimer_Timer() Dim BOT, b BOT = GetBalls For b = 0 to UBound(BOT) If BOT(b).z < 30 Then rolling(b) = True End If Next End Sub GetBalls is in the application code and returns a SAFEARRAY of IDispatch pointers: STDMETHODIMP ScriptGlobalTable::GetBalls(LPSAFEARRAY *pVal) Currently this will fail at BOT assign_value because VariantCopyInd calls VariantCopy which calls VARIANT_ValidateType which then returns DISP_E_BADVARTYPE I believe I have this now working but I'm not sure if it would impact anything else for an official patch: inc/wine/dlls/oleaut32/variant.c: HRESULT WINAPI VariantCopy(VARIANTARG* pvargDest, const VARIANTARG* pvargSrc) { HRESULT hres = S_OK; TRACE("(%s,%s)\n", debugstr_variant(pvargDest), debugstr_variant(pvargSrc)); #ifndef __SAFEARRAYFIX__ if (V_TYPE(pvargSrc) == VT_CLSID || /* VT_CLSID is a special case */ FAILED(VARIANT_ValidateType(V_VT(pvargSrc)))) return DISP_E_BADVARTYPE; #else if (V_TYPE(pvargSrc) != VT_SAFEARRAY && (V_TYPE(pvargSrc) == VT_CLSID || /* VT_CLSID is a special case */ FAILED(VARIANT_ValidateType(V_VT(pvargSrc))))) return DISP_E_BADVARTYPE; #endif if (pvargSrc != pvargDest && SUCCEEDED(hres = VariantClear(pvargDest))) { *pvargDest = *pvargSrc; /* Shallow copy the value */ if (!V_ISBYREF(pvargSrc)) { switch (V_VT(pvargSrc)) { case VT_BSTR: V_BSTR(pvargDest) = SysAllocStringByteLen((char*)V_BSTR(pvargSrc), SysStringByteLen(V_BSTR(pvargSrc))); if (!V_BSTR(pvargDest)) hres = E_OUTOFMEMORY; break; case VT_RECORD: hres = VARIANT_CopyIRecordInfo(pvargDest, pvargSrc); break; case VT_DISPATCH: case VT_UNKNOWN: V_UNKNOWN(pvargDest) = V_UNKNOWN(pvargSrc); if (V_UNKNOWN(pvargSrc)) IUnknown_AddRef(V_UNKNOWN(pvargSrc)); break; #ifdef __SAFEARRAYFIX__ case VT_SAFEARRAY: hres = SafeArrayCopy(V_ARRAY(pvargSrc), &V_ARRAY(pvargDest)); break; #endif default: if (V_ISARRAY(pvargSrc)) hres = SafeArrayCopy(V_ARRAY(pvargSrc), &V_ARRAY(pvargDest)); } } } return hres; } inc/wine/dlls/vbscript/interp.c: static HRESULT variant_call(exec_ctx_t *ctx, VARIANT *v, unsigned arg_cnt, VARIANT *res) { SAFEARRAY *array = NULL; DISPPARAMS dp; HRESULT hres; TRACE("%s\n", debugstr_variant(v)); if(V_VT(v) == (VT_VARIANT|VT_BYREF)) v = V_VARIANTREF(v); switch(V_VT(v)) { case VT_ARRAY|VT_BYREF|VT_VARIANT: array = *V_ARRAYREF(v); break; case VT_ARRAY|VT_VARIANT: array = V_ARRAY(v); break; #ifdef __SAFEARRAYFIX__ case VT_SAFEARRAY: array = V_ARRAY(v); break; #endif case VT_DISPATCH: vbstack_to_dp(ctx, arg_cnt, FALSE, &dp); hres = disp_call(ctx->script, V_DISPATCH(v), DISPID_VALUE, &dp, res); break; default: FIXME("unsupported on %s\n", debugstr_variant(v)); return E_NOTIMPL; } if(array) { if(!res) { FIXME("no res\n"); return E_NOTIMPL; } vbstack_to_dp(ctx, arg_cnt, FALSE, &dp); hres = array_access(ctx, array, &dp, &v); if(FAILED(hres)) return hres; V_VT(res) = VT_BYREF|VT_VARIANT; V_BYREF(res) = v; } stack_popn(ctx, arg_cnt); return S_OK; } inc/wine/dlls/vbscript/global.c: static HRESULT Global_UBound(BuiltinDisp *This, VARIANT *arg, unsigned args_cnt, VARIANT *res) { SAFEARRAY *sa; HRESULT hres; LONG ubound; int dim; assert(args_cnt == 1 || args_cnt == 2); TRACE("%s %s\n", debugstr_variant(arg), args_cnt == 2 ? debugstr_variant(arg + 1) : "1"); switch(V_VT(arg)) { case VT_VARIANT|VT_ARRAY: sa = V_ARRAY(arg); break; case VT_VARIANT|VT_ARRAY|VT_BYREF: sa = *V_ARRAYREF(arg); break; #ifdef __SAFEARRAYFIX__ case VT_SAFEARRAY: sa = V_ARRAY(arg); break; #endif default: FIXME("arg %s not supported\n", debugstr_variant(arg)); return E_NOTIMPL; } static HRESULT Global_LBound(BuiltinDisp *This, VARIANT *arg, unsigned args_cnt, VARIANT *res) { SAFEARRAY *sa; HRESULT hres; LONG ubound; int dim; assert(args_cnt == 1 || args_cnt == 2); TRACE("%s %s\n", debugstr_variant(arg), args_cnt == 2 ? debugstr_variant(arg + 1) : "1"); switch(V_VT(arg)) { case VT_VARIANT|VT_ARRAY: sa = V_ARRAY(arg); break; case VT_VARIANT|VT_ARRAY|VT_BYREF: sa = *V_ARRAYREF(arg); break; #ifdef __SAFEARRAYFIX__ case VT_SAFEARRAY: sa = V_ARRAY(arg); break; #endif default: FIXME("arg %s not supported\n", debugstr_variant(arg)); return E_NOTIMPL; } -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

Oct. 8, 2022

[Bug 53765] Overwatch2 simply crashes

by WineHQ Bugzilla

https://bugs.winehq.org/show_bug.cgi?id=53765 --- Comment #1 from Ker noa <blue-t(a)web.de> --- Created attachment 73250 --> https://bugs.winehq.org/attachment.cgi?id=73250 Log -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

Oct. 8, 2022

[Bug 53765] New: Overwatch2 simply crashes

by WineHQ Bugzilla

https://bugs.winehq.org/show_bug.cgi?id=53765 Bug ID: 53765 Summary: Overwatch2 simply crashes Product: Wine Version: 7.18 Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown Assignee: wine-bugs(a)winehq.org Reporter: blue-t(a)web.de Distribution: --- Since the update from Overwatch1 to Overwatch2 , this game doesn't run with wine 7.18-staging. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

Oct. 8, 2022

[Bug 46822] Edit control in ADL search dialog gets initially not drawn in DC++ 0.868, regression

by WineHQ Bugzilla

https://bugs.winehq.org/show_bug.cgi?id=46822 --- Comment #5 from Nikolay Sivov <bunglehead(a)gmail.com> --- This appears to be fixed now, with https://source.winehq.org/git/wine.git/commit/a336b43a93ce7e0db813a6dac329b…. Please retest with current Wine, it works for me for both themed and unthemed cases. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

Oct. 8, 2022

[Bug 53739] Text does not show in QQ UI, possible issue with Fonts/Replacements

by WineHQ Bugzilla

https://bugs.winehq.org/show_bug.cgi?id=53739 --- Comment #16 from 399989567(a)qq.com --- (In reply to Nikolay Sivov from comment #14) > I don't see the plus sign button, and QR code button hangs the application > for me. We'll need someone else, familiar with this application to try to > reproduce. (use plus sign button to find this problem is the quickest way,it will not cause app hangs) It is precisely because the font does not appear that the program responds slowly (hangs), so I came to ask for your help. If you don't see the plus sign button, try moving your mouse over the circular penguin icon, which might show the plus sign. Or I think you can enter the account password at will, and click to log in (note that this will also cause a long period of hangs), and then QQ will prompt you that the account password is wrong, but the text in this prompt also cannot be show in wine. Hint picture：https://imgse.com/i/xGmQds moving your mouse over the circular penguin icon:https://imgse.com/i/xGm3iq I look forward to hearing from you. Yours: SvenL -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

Oct. 8, 2022

[Bug 53739] Text does not show in QQ UI, possible issue with Fonts/Replacements

by WineHQ Bugzilla

https://bugs.winehq.org/show_bug.cgi?id=53739 --- Comment #15 from 399989567(a)qq.com --- (In reply to Nikolay Sivov from comment #14) > I don't see the plus sign button, and QR code button hangs the application > for me. We'll need someone else, familiar with this application to try to > reproduce. The QR code hangs the program (I have encountered this and I am sure the hang problem is caused by dwrite(because When I use my way to let text show in QQ,the hang problem is disappear))，I think you just need to wait a while because the font does not display properly and the program is hang(I don't know why cause caton),so you just need click the QR code and wait for a while,QQ will automatically load a QR code and there is no font display below the QR code,where should have some text. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

Oct. 8, 2022