January 2023 - Wine-Bugs - list.winehq.org

[Bug 35126] AirBuccaneers hangs on exit

by WineHQ Bugzilla

https://bugs.winehq.org/show_bug.cgi?id=35126 Béla Gyebrószki <gyebro69(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Fixed by SHA1| |dfdfba263809b358d7b3738e125 | |ee69fcd996ace Component|-unknown |winsock Resolution|--- |FIXED --- Comment #5 from Béla Gyebrószki <gyebro69(a)gmail.com> --- I tested again in Wine-8.0-rc2 and the game quits properly now. This was fixed by https://source.winehq.org/git/wine.git/commit/dfdfba263809b358d7b3738e125ee… -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

Jan. 1, 2023

[Bug 54223] [Wine 8.0-rc2] [Severe Performance Regression] [Unigine Heaven Benchmark 4.0] Wine DirectX11 to OpenGL Severely Low FPS

by WineHQ Bugzilla

https://bugs.winehq.org/show_bug.cgi?id=54223 --- Comment #8 from CHECK_1234 <CHECK_1234543212345(a)protonmail.com> --- Update 4: Custom compiled with performance regression fixed I changed dlls/wined3d/device.c I changed the code from: ------------------------------------------------------------------------------- static bool use_buffer_chunk_suballocation(struct wined3d_device_gl *device_gl, const struct wined3d_gl_info *gl_info, GLenum binding) { switch (binding) { case GL_ARRAY_BUFFER: case GL_ATOMIC_COUNTER_BUFFER: case GL_DRAW_INDIRECT_BUFFER: case GL_PIXEL_UNPACK_BUFFER: case GL_UNIFORM_BUFFER: return true; case GL_ELEMENT_ARRAY_BUFFER: /* There is no way to specify an element array buffer offset for * indirect draws in OpenGL. */ return device_gl->d.wined3d->flags & WINED3D_NO_DRAW_INDIRECT || !gl_info->supported[ARB_DRAW_INDIRECT]; case GL_TEXTURE_BUFFER: return gl_info->supported[ARB_TEXTURE_BUFFER_RANGE]; default: return false; } } ------------------------------------------------------------------------------- to ------------------------------------------------------------------------------- static bool use_buffer_chunk_suballocation(struct wined3d_device_gl *device_gl, const struct wined3d_gl_info *gl_info, GLenum binding) { switch (binding) { case GL_ARRAY_BUFFER: case GL_ATOMIC_COUNTER_BUFFER: case GL_DRAW_INDIRECT_BUFFER: case GL_PIXEL_UNPACK_BUFFER: case GL_UNIFORM_BUFFER: return false; case GL_ELEMENT_ARRAY_BUFFER: /* There is no way to specify an element array buffer offset for * indirect draws in OpenGL. */ return false; case GL_TEXTURE_BUFFER: return false; default: return false; } } ------------------------------------------------------------------------------- I had to use grep -r 'case GL_UNIFORM_BUFFER:' to find "case GL_UNIFORM_BUFFER:" which was the main one causing the performance regression because I did not find "case GL_UNIFORM_BUFFER:" at "dlls/wined3d/context_gl.c" according to the git bisect. I recompiled and Wine DirectX11 to OpenGL performance regression gets fixed, but there there might be another performance regression with DirectX11 to OpenGL because scene 3's FPS is lower compared to Wine Staging 6.0. ⬤ Settings: RX580 locked to 300Mhz core clock and 300Mhz memory clock Quality: Low Resolution: 1280x720 Fullscreen: Unchecked MAX CPU CLOCK SPEED: 2.5Ghz at 0.768V ⬤ Unigine Heaven Custom Wine 8.0-rc2 DX11 to OpenGL vs Wine Staging 6.0 DX11 to OpenGL -------------------- Performance Regression Fixed Custom Wine 8.0-rc2 DX11 to OpenGL Scene 2: Up to 100 FPS Scene 3: 67 FPS Performance Regression Fixed Custom Custom Wine 8.0-rc2 DX9 to OpenGL Scene 2: Up to 100 FPS Scene 3: 82 FPS -------------------- Wine Staging 6.0 DX11 to OpenGL Scene 2: 92 FPS Scene 3: 78 FPS Wine Staging 6.0 DX9 to OpenGL Scene 2: 92 FPS Scene 3: 80 FPS -------------------- ⬤ Conclusion The "Performance Regression Fixed Custom Wine 8.0-rc2" DX11 to OpenGL might still have another performance regression because the FPS at scene 3 seems to lower than Wine Staging 6.0. Hopefully this DirectX11 to OpenGL performance regression can be fully fixed by Wine 8.0 Stable. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

Jan. 1, 2023

[Bug 54243] Warcraft 2 BNE: Fails CD check in wine versions >6.0.X

by WineHQ Bugzilla

https://bugs.winehq.org/show_bug.cgi?id=54243 Austin English <austinenglish(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

Jan. 1, 2023

[Bug 54223] [Wine 8.0-rc2] [Severe Performance Regression] [Unigine Heaven Benchmark 4.0] Wine DirectX11 to OpenGL Severely Low FPS

by WineHQ Bugzilla

https://bugs.winehq.org/show_bug.cgi?id=54223 --- Comment #7 from CHECK_1234 <CHECK_1234543212345(a)protonmail.com> --- Update 3: Accidentally linked to wrong commit The commit that was causing this performance regression was 86f0ae8efb17ce688986971d24c3e25840a2beef located at https://gitlab.winehq.org/wine/wine/-/commit/86f0ae8efb17ce688986971d24c3e2… -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

Jan. 1, 2023

[Bug 54223] [Wine 8.0-rc2] [Severe Performance Regression] [Unigine Heaven Benchmark 4.0] Wine DirectX11 to OpenGL Severely Low FPS

by WineHQ Bugzilla

https://bugs.winehq.org/show_bug.cgi?id=54223 CHECK_1234 <CHECK_1234543212345(a)protonmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Regression SHA1| |86f0ae8efb17ce688986971d24c | |3e25840a2beef CC| |z.figura12(a)gmail.com -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

Jan. 1, 2023

[Bug 54223] [Wine 8.0-rc2] [Severe Performance Regression] [Unigine Heaven Benchmark 4.0] Wine DirectX11 to OpenGL Severely Low FPS

by WineHQ Bugzilla

https://bugs.winehq.org/show_bug.cgi?id=54223 --- Comment #6 from CHECK_1234 <CHECK_1234543212345(a)protonmail.com> --- (In reply to Béla Gyebrószki from comment #5) > Could you please perform a regression test to find out which commit is to > blame? > https://wiki.winehq.org/Regression_Testing > > I can reproduce the performance drop between 7.0 and 8.0-rc2 on Nvidia > drivers 525.47.04. > Using the method described in comment #0 I'm experiencing ~35% drop in FPS > in Unigine Heaven when comparing Wine-7.0 to 8.0-rc2 (Quality: Low, > Resolution: 1280x720,Fullscreen: Unchecked). > > OS: Arch Linux > Kernel: linux-zen 6.1.1.zen1-1 > CPU: Ryzen 5 5600X > GPU: GTX 1660S 6 GB > GPU driver: NVIDIA 525.47.04 > Window Manager: XFCE 4.18 > Compositor: disabled > > In my case the performance drop is due to > commit 7c844cd3c9c465bdeaf3d98d6da5f2f5e460e650 > Also mentioned in bug #53408. > > I also noticed that the performance penalty in recent Wine occurs when cpu > frequency-scaling is enabled in the OS. > When the cpu is set to a constant frequency, instead of dynamically > changing, then current Wine 8.0-rc2 scores better in Unigine Heaven than 7.0 > does. Update 2:(In reply to Béla Gyebrószki from comment #5) > Could you please perform a regression test to find out which commit is to > blame? > https://wiki.winehq.org/Regression_Testing > > I can reproduce the performance drop between 7.0 and 8.0-rc2 on Nvidia > drivers 525.47.04. > Using the method described in comment #0 I'm experiencing ~35% drop in FPS > in Unigine Heaven when comparing Wine-7.0 to 8.0-rc2 (Quality: Low, > Resolution: 1280x720,Fullscreen: Unchecked). > > OS: Arch Linux > Kernel: linux-zen 6.1.1.zen1-1 > CPU: Ryzen 5 5600X > GPU: GTX 1660S 6 GB > GPU driver: NVIDIA 525.47.04 > Window Manager: XFCE 4.18 > Compositor: disabled > > In my case the performance drop is due to > commit 7c844cd3c9c465bdeaf3d98d6da5f2f5e460e650 > Also mentioned in bug #53408. > > I also noticed that the performance penalty in recent Wine occurs when cpu > frequency-scaling is enabled in the OS. > When the cpu is set to a constant frequency, instead of dynamically > changing, then current Wine 8.0-rc2 scores better in Unigine Heaven than 7.0 > does. Update 2: commit 86f0ae8efb17ce688986971d24c3e25840a2beef ( https://gitlab.winehq.org/wine/wine/-/commit/7c844cd3c9c465bdeaf3d98d6da5f2… ) caused this performance regression according to git bisect ⬤ System Information: OS: Ubuntu 22.10 Kernel: 6.1.0 CPU: Ryzen 7 1700 GPU: XFX RX580 4GB Window Manager: OpenBox Compositor: No Compositor, Xorg TearFree Disabled ⬤ Commit that caused this performance regression found! I decided to do the git bisect and compile wine following that "Regression Testing - WineHQ Wiki" guide. I noticed that when I stopped doing ./configure in between "git bisect good" or "git bisect good", wine compiled faster. When it finished bisecting, this commit caused this severe performance regression ------------------------------------------------------------------- commit 86f0ae8efb17ce688986971d24c3e25840a2beef (refs/bisect/bad) Author: Zebediah Figura <zfigura(a)codeweavers.com> Date: Tue Feb 8 20:34:03 2022 -0600 wined3d: Use the chunk allocator for GL uniform buffers. Signed-off-by: Zebediah Figura <zfigura(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> ------------------------------------------------------------------- Wow, you were right about commit 86f0ae8efb17ce688986971d24c3e25840a2beef ( https://gitlab.winehq.org/wine/wine/-/commit/7c844cd3c9c465bdeaf3d98d6da5f2… ) causing this severe performance regression! Thanks for helping to solve this problem! ⬤ Conclusion Hopefully someone can fix this severe performance regression caused by commit 86f0ae8efb17ce688986971d24c3e25840a2beef ( https://gitlab.winehq.org/wine/wine/-/commit/7c844cd3c9c465bdeaf3d98d6da5f2… ) If this problem is not fixed by the time Wine 8.0 stable gets released and proton updates to Wine 8.0. anyone using "PROTON_USE_WINED3D=1" on a DirectX11 Steam game might have this severe performance regression. Hopefully this can get fixed quickly before Wine 8.0 stable gets released. -- Do not reply to this email, post in Bugzilla using the above URL to reply. You are receiving this mail because: You are watching all bug changes.

Jan. 1, 2023