- Wine-Devel - list.winehq.org

[PATCH v2 0/5] MR266: iphlpapi/tests: Add win98+ API tests
by Jinoh Kang (＠iamahuman) June 21, 2022

June 21, 2022

Signed-off-by: Jinoh Kang <jinoh.kang.kr(a)gmail.com> -- v2: iphlpapi/tests: Add more tests for interface identifier conversion failure. iphlpapi/tests: Factor out interface identifier conversion with invalid parameters. iphlpapi/tests: Add tests for GetBestInterfaceEx. iphlpapi/tests: Add tests for GetBestRoute. iphlpapi/tests: Add tests for GetBestInterface. https://gitlab.winehq.org/wine/wine/-/merge_requests/266

4 8

Re: [PATCH v2 0/1] MR295: uiautomationcore: Initialize VARIANT in UIAutomation test. - approved
by Alexandre Julliard (＠julliard) June 21, 2022

June 21, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/295

1 0

[PATCH v3 0/3] MR286: nsiproxy.sys: Add static ARP entries which are always present on Windows.
by Paul Gofman (＠gofman) June 21, 2022

June 21, 2022

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53175 Commit 910d58520a6d75cada82d992757ca013099d9345 (iphlpapi: Return ERROR_NO_DATA from GetIpNetTable() if no entries are found.) introduced a regression in Roon application. It looks like the app doesn't tolerate an error return from GetIpNetTable() if there are active interfaces found. The blamed patch still looks correct to me per se, that is, if number of entries ends up being zero Windows returns ERROR_NO_DATA. However, number of entries is never zero on Windows if there is any network adapter. There are two things why Windows always has some arp entries and we do not: 1. We currently parse /proc/net/arp line on Linux a bit wrong and end up getting no entries from there (patch 1 fixes that); 2. With the patch patch 1 there Roon seems happy (at least as far as I could test it right at start), at least as long we have an entry in /proc/sys/net (which might not be necessarily the case if there is, e. g., no actual network connection). But that breaks SCP: Secret Laboratory again the same way as before 910d58520a6d75cada82d992757ca013099d9345. It turns out the latter game depends on GetIpNetTable() returning at least 4 entries when returning success (for some reason, I am not sure why but I think I saw that quite clearly). And both apps can actually work reliably on Windows as there are always at least 4 static arp entries if there is any network adaptere configured at all. There are "224.0.0.22" and "239.255.255.250" static arp multicast entries which are always there for any interface on Windows, including loopback (starting from Win10; earlier versions might be missing "239.255.255.250" but have "224.0.0.22"). So adding those like on Windows should hopefully fix all those cases. -- v3: iphlpapi: Sort by adapter index first in GetIpNetTable(). iphlpapi: Correctly index dynamic data array. nsiproxy.sys: Strip trailing end of line for iface name on Linux. https://gitlab.winehq.org/wine/wine/-/merge_requests/286

3 4

Re: [PATCH v3 0/6] MR294: win32u: menu and def window proc conversion - approved
by Alexandre Julliard (＠julliard) June 21, 2022

June 21, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/294

1 0

Re: [PATCH v3 0/2] MR291: secur32: Implement SECPKG_ATTR_CIPHER_INFO. - approved
by Alexandre Julliard (＠julliard) June 21, 2022

June 21, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/291

1 0

Re: [PATCH v3 0/2] MR292: nsiproxy: Small improvements - approved
by Alexandre Julliard (＠julliard) June 21, 2022

June 21, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/292

1 0

Re: [PATCH v2 0/1] MR290: iphlpapi/tests: Allow the route's age to differ by one second. - approved
by Alexandre Julliard (＠julliard) June 21, 2022

June 21, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/290

1 0

[PATCH v2 0/3] MR288: comctl32/toolbar: Add support for TBCDRF_NOBACKGROUND.
by Zhiyi Zhang (＠zhiyi) June 21, 2022

June 21, 2022

Tested manually on XP, Win 7 and Win 10. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53049 Signed-off-by: Zhiyi Zhang <zzhang(a)codeweavers.com> -- v2: comctl32/toolbar: Don't use pattern brushes to draw checked background. comctl32/tests: Test that themed toolbar buttons don't use pattern brushes to draw checked background. comctl32/toolbar: Add support for TBCDRF_NOBACKGROUND. https://gitlab.winehq.org/wine/wine/-/merge_requests/288

3 4

Re: [PATCH v2 0/5] MR287: uxtheme: Support parsing more button parts and states. - approved
by Alexandre Julliard (＠julliard) June 21, 2022

June 21, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/287

1 0

Re: [PATCH v3 0/1] MR273: ntdll/tests: Add more tests for \Device\NamedPipe\ root directory. - approved
by Alexandre Julliard (＠julliard) June 21, 2022

June 21, 2022

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/273

1 0