August 2022 - Wine-GitLab - list.winehq.org

[PATCH v4 0/1] MR723: winepulse.drv: Check state after connect
by Alistair Leslie-Hughes (＠alesliehughes) Aug. 31, 2022

Aug. 31, 2022

-- v4: winepulse: Use the predicate to terminate the connect cond_wait loop. https://gitlab.winehq.org/wine/wine/-/merge_requests/723

3 3

[PATCH 0/1] MR739: win32u/hook: Fix a leak on earlier return (Coverity).
by Nikolay Sivov (＠nsivov) Aug. 31, 2022

Aug. 31, 2022

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/739

3 2

[PATCH 0/1] MR738: mshtml/tests: Fix a typo in test message (Coverity).
by Nikolay Sivov (＠nsivov) Aug. 31, 2022

Aug. 31, 2022

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/738

3 2

Re: [PATCH v12 0/2] MR672: comdlg32: Common item dialog fixes
by Ben Cottrell (＠bgc) Aug. 31, 2022

Aug. 31, 2022

I'll do another commit, and will use the interface IKnownFolders and GetFolderByName, or SHParseDisplayName for paths to translate to a PIDL to pass to IExplorerBrowser_BrowseToIDList. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/672#note_7303

1 0

[PATCH v3 0/1] MR723: winepulse.drv: Check state after connect
by Alistair Leslie-Hughes (＠alesliehughes) Aug. 31, 2022

Aug. 31, 2022

-- v3: winepulse: Use the predicate to terminate the connect cond_wait loop. https://gitlab.winehq.org/wine/wine/-/merge_requests/723

3 2

[PATCH 0/1] MR735: bcrypt/tests: Use CRT allocation functions.
by Nikolay Sivov (＠nsivov) Aug. 31, 2022

Aug. 31, 2022

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/735

3 2

[PATCH 0/1] MR740: bcrypt: Force symmetric key reset if necessary.
by Hans Leidekker (＠hans) Aug. 31, 2022

Aug. 31, 2022

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52457 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/740

2 1

[PATCH v2 0/1] MR723: winepulse.drv: Check state after connect
by Alistair Leslie-Hughes (＠alesliehughes) Aug. 31, 2022

Aug. 31, 2022

-- v2: winepulse.drv: Check state after connect https://gitlab.winehq.org/wine/wine/-/merge_requests/723

3 2

[PATCH 0/1] MR736: mfsrcsnk/wave: Initialize buffer pointer in ProcessSample() (Coverity).
by Nikolay Sivov (＠nsivov) Aug. 31, 2022

Aug. 31, 2022

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/736

2 1

Re: [PATCH v2 0/1] MR727: evr/filter: Implement pin's connect/disconnect.
by Nikolay Sivov (＠nsivov) Aug. 31, 2022

Aug. 31, 2022

On Tue Aug 30 17:26:10 2022 +0000, **** wrote: > Zebediah Figura replied on the mailing list: > ``` > On 8/30/22 06:24, Nikolay Sivov wrote: > > +static HRESULT evr_connect(struct strmbase_renderer *iface, const > AM_MEDIA_TYPE *mt) > > +{ > > + struct evr *filter = impl_from_strmbase_renderer(iface); > > + IMFMediaType *media_type; > > + HRESULT hr; > > + > > + if (SUCCEEDED(hr = evr_test_input_type(filter, mt, &media_type))) > It's perhaps worth noting that strmbase IPin::ReceiveConnection() [which > calls this function] already calls query_accept(). Granted, > evr_test_input_type() is also doing some other initialization, but > arguably it could be named more appropriately in that case. > ``` Yes, I'll have to review this again. One thing is that query_accept() currently does init-test-release, and does not check if we are already initialized, e.g. in connect(). I'll have to try to see how it works. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/727#note_7283

1 0