October 2023 - Wine-GitLab - list.winehq.org

[PATCH 0/1] MR4132: configure: Only build Wayland if linux/input.h is present.
by Brendan Shanks (＠bshanks) Oct. 20, 2023

Oct. 20, 2023

This fixes a build error on FreeBSD, where Wayland libraries/tools might be present but `linux/input.h` is not unless the `evdev-proto` package is installed and `CPPFLAGS=-I/usr/local/include` is set. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4132

3 2

[PATCH 0/3] MR4099: wined3d: Do not track dirty ranges for buffers without WINED3D_BUFFER_USE_BO.
by Zebediah Figura (＠zfigura) Oct. 20, 2023

Oct. 20, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4099

3 4

[PATCH 0/1] MR4123: win32u: Use debugstr_fourcc instead of debugstr_an.
by Alex Henrie (＠alexhenrie) Oct. 20, 2023

Oct. 20, 2023

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4123

3 2

[PATCH v3 0/10] MR413: Draft: ci: Run the crosstests on Windows.
by Giovanni Mascellani (＠giomasce) Oct. 20, 2023

Oct. 20, 2023

This depends on !412, and might need some finishing touches before being ready. -- v3: ci: Run the HLSL compiler tests on Windows. ci: Run the HLSL preprocessor tests on Windows. ci: Run cross tests on Windows. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/413

2 10

[PATCH v2 0/5] MR3975: Improve module's debug information.
by eric pouech (＠epo) Oct. 20, 2023

Oct. 20, 2023

This series: - fixes a couple of issues in mach-o modules support (getting information from system modules in wow setups, machine information...) - stops hiding information in some fields between dbghelp and winedbg (using an extensible solution, where more information can be shared in the future) - display elf/mach-o in winedbg (previously mach-o was reported as elf) - display PE native vs builtin module information in winedbg -- v2: dbghelp: Remove unneeded parameter to pe_map_file. dbghelp: Simplified module_find_by_addr(). dbghelp: Set the machine type for mach-O modules. dbghelp: Use is_host_64bit for handling bitness of mach-o libs. dbghelp: Rename internal field (system -> host). https://gitlab.winehq.org/wine/wine/-/merge_requests/3975

3 9

[PATCH v3 0/4] MR3729: crypt32: Avoid truncating unicode chars.
by Dmitry Timoshkov (＠dmitry) Oct. 20, 2023

Oct. 20, 2023

-- v3: cryptui: Use CertNameToStr(CERT_NAME_STR_NO_QUOTING_FLAG) to disable quoting. crypt32: Add support for CERT_NAME_STR_NO_QUOTING_FLAG to CertNameToStr(). crypt32/tests: Add some tests for quoted RDN values. crypt32: Avoid truncating unicode chars. https://gitlab.winehq.org/wine/wine/-/merge_requests/3729

2 5

[PATCH v4 0/5] MR408: vkd3d-shader/dxil: Implement constant buffer loads.
by Conor McCarthy (＠cmccarthy) Oct. 20, 2023

Oct. 20, 2023

-- v4: vkd3d-shader/dxil: Implement the DXIL EXTRACTVAL instruction. vkd3d-shader/spirv: Support scalar swizzle of vector SSA registers. vkd3d-shader/dxil: Implement DX instruction CBufferLoadLegacy. vkd3d-shader/dxil: Implement DX instruction CreateHandle. vkd3d-shader/dxil: Replace register_address_init() with register_index_address_init(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/408

2 6

Re: [PATCH v13 0/7] MR3938: winegstreamer: Implement CLSID_CMpegVideoCodec
by Alfred Agrell (＠Alcaro) Oct. 20, 2023

Oct. 20, 2023

On Mon Oct 16 23:45:47 2023 +0000, Zebediah Figura wrote: > This may be correct (although I'm curious if it actually matters here?) > but should be a separate patch. It does matter, gst_pad_push returns GST_FLOW_NOT_NEGOTIATED if I omit it. Separate commit, sure, if you say so. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3938#note_49357

1 0

Re: [PATCH v13 0/7] MR3938: winegstreamer: Implement CLSID_CMpegVideoCodec
by Alfred Agrell (＠Alcaro) Oct. 20, 2023

Oct. 20, 2023

On Fri Oct 20 01:24:23 2023 +0000, Zebediah Figura wrote: > Hi, really sorry about the very late review on this one (I was out for a > while, and then spent a lot of time catching up on review while I was > out, and then trying to get some more important Wine work done...) > 2/7, seeking parts aside, is broadly doing the right thing (from my > perspective) but I would like to see it arranged differently. What I > would like to see is something like the following, in a series of > individual patches: > * Introduce a wg_parser_create option to use the encoded format; this > should end up being translated to "chain_decodebins" basically as you > have it. I would also rename that to something like "output_compressed" > (with inverted meaning). > Note that in this case autoplug-continue already does what we want, > you shouldn't need to set the "caps" property on top of that. > * Use this property, plus WG_PARSER_DECODEBIN, in the existing frontend > instead of WG_PARSER_MPEGAUDIOPARSE. Delete WG_PARSER_MPEGAUDIOPARSE. > * Ideally patch 1/7 should be moved from the beginning of the series to here. > * Add MPEG-1 system stream support to the quartz frontend. Yes, IRL stuff is always in the way (from us internet folks' perspective), and code review isn't the most exciting task. I don't understand the point of that autoplug-continue handler. It looks like it says "yep, I want this" for certain formats, then it turns around and says "no, I don't want this after all, decode it again" in the pad-added signal. I'm sure that complexity exists for some reason, otherwise someone would've deleted it long ago, but... But I don't need to understand it, as long as someone does. This took me longer to implement than I expected, didn't expect you to be this thorough. Sure helps to have a pair of fresh eyes on it. Worth the wait (though it would've helped to have known how long it'd take). I think I fixed everything (except those with follow-up questions), but some changes are pretty big and/or not exactly what you were thinking of, so I suspect you'll have another set of remarks. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3938#note_49356

1 0

Re: [PATCH v13 0/7] MR3938: winegstreamer: Implement CLSID_CMpegVideoCodec
by Alfred Agrell (＠Alcaro) Oct. 20, 2023

Oct. 20, 2023

On Mon Oct 16 23:46:02 2023 +0000, Zebediah Figura wrote: > Can you please also check (at least the return value of) > IMediaSample::GetMediaType()? I'm rather curious if it's updated or not. It just returns S_FALSE every frame (which means unchanged since previous sample). Sure, let's test it, no reason not to. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3938#note_49355

1 0