October 2023 - Wine-GitLab - list.winehq.org

Re: [PATCH v13 0/7] MR3938: winegstreamer: Implement CLSID_CMpegVideoCodec
by Alfred Agrell (＠Alcaro) Oct. 19, 2023

Oct. 19, 2023

On Mon Oct 16 23:45:45 2023 +0000, Zebediah Figura wrote: > This is correct, I think, but also orthogonal to the purpose of this > patch. Can you please split this out into a separate patch? I hope it doesn't mess with the decodebin chaining thing. But the mpegsplit and mpegvideo tests pass, so probably no big deal. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3938#note_49344

1 0

Re: [PATCH v13 0/7] MR3938: winegstreamer: Implement CLSID_CMpegVideoCodec
by Alfred Agrell (＠Alcaro) Oct. 19, 2023

Oct. 19, 2023

On Mon Oct 16 23:45:45 2023 +0000, Zebediah Figura wrote: > This is overestimation because we can't do any better, right? In that > case it probably deserves a comment just to clarify that's what's happening. Yeah, that entire function is confusing. It's supposed to return the max size of a compressed frame, but I don't think there is any real upper bound for that, you can cram in as many optional extensions as you want. So yes, it's guessing decompressed size as an upper bound. It'll break for 1x1 videos (can't fit the MPEG headers in three bytes), and videos crammed full of junk data, but let's just not care about those. But comments, sure, can do. And the Cinepak branch's comment is suspicious at best - what does biSizeImage have to do with compressed size? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3938#note_49343

1 0

Re: [PATCH v2 0/1] MR4144: mfmediaengine: Mask some source flags returned from GetResourceCharacteristics(). - approved
by Alexandre Julliard (＠julliard) Oct. 19, 2023

Oct. 19, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4144

1 0

Re: [PATCH v3 0/1] MR4137: commdlg: Set lCustData the same in GetSaveFileName as GetOpenFileName. - approved
by Alexandre Julliard (＠julliard) Oct. 19, 2023

Oct. 19, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4137

1 0

Re: [PATCH v2 0/1] MR4124: wined3d: Use debugstr_fourcc instead of debugstr_an. - approved
by Alexandre Julliard (＠julliard) Oct. 19, 2023

Oct. 19, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4124

1 0

Re: [PATCH v2 0/1] MR420: vkd3d-utils: Implement D3DStripShader(). - approved
by Alexandre Julliard (＠julliard) Oct. 19, 2023

Oct. 19, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/420

1 0

Re: [PATCH v14 0/4] MR401: vkd3d-shader/dxil: Read CBV info. - approved
by Alexandre Julliard (＠julliard) Oct. 19, 2023

Oct. 19, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/401

1 0

Re: [PATCH v2 0/4] MR419: vkd3d-shader/hlsl: Add support for RWTexture1DArray and RWTexture2DArray. - approved
by Alexandre Julliard (＠julliard) Oct. 19, 2023

Oct. 19, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/419

1 0

Re: [PATCH v8 0/2] MR381: vkd3d-shader/tpf: Convert some of the semantic names to system values names when in compatibility mode. - approved
by Alexandre Julliard (＠julliard) Oct. 19, 2023

Oct. 19, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/381

1 0

[PATCH 0/1] MR420: vkd3d-utils: Implement D3DStripShader().
by Henri Verbeet (＠hverbeet) Oct. 19, 2023

Oct. 19, 2023

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/420

4 4