October 2023 - Wine-GitLab - list.winehq.org

[PATCH v6 0/1] MR384: vkd3d: Replace the descriptor object cache with a thread-local implementation.
by Conor McCarthy (＠cmccarthy) Oct. 19, 2023

Oct. 19, 2023

The PE build uses FlsAlloc(), which for our purposes makes no difference vs TlsAlloc(), and allows the use of a destruction callback. -- v6: vkd3d: Replace the descriptor object cache with a thread-local implementation. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/384

2 1

Re: [PATCH v3 0/8] MR417: vkd3d-shader/hlsl: Add ceil() function.
by Francisco Casas (＠fcasas) Oct. 19, 2023

Oct. 19, 2023

On Thu Oct 19 13:35:46 2023 +0000, Francisco Casas wrote: > I see. So the `probe` part may be deserving of a `todo(sm<4)`. > I made patches for that on the second part of !418, but I think that for > now it is okay to leave the requirement. Oh no, you are right, compiling with the native compiler and running on Windows we get those broken results, so it is not a problem of the compiler itself. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/417#note_49297

1 0

Re: [PATCH v3 0/8] MR417: vkd3d-shader/hlsl: Add ceil() function. - approved
by Francisco Casas (＠fcasas) Oct. 19, 2023

Oct. 19, 2023

This merge request was approved by Francisco Casas. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/417

1 0

Re: [PATCH v3 0/8] MR417: vkd3d-shader/hlsl: Add ceil() function.
by Francisco Casas (＠fcasas) Oct. 19, 2023

Oct. 19, 2023

On Thu Oct 19 09:51:46 2023 +0000, Nikolay Sivov wrote: > It does compile, but results are broken. That's what I get on Windows: > `shader_runner:683: Section [test], line 51: Test failed: Got > {8.40779079e-045, 9.80908925e-045, -1.#QNAN000e+000, 4.20389539e-045}, > expected {6.00000000e+000, 7.00000000e+000, -1.00000000e+000, > 3.00000000e+000} at (0, 0).` > That happens because of the lack of itof conversion on SM3. So ints we > set are returned as is, after ceil() is optimized away for integers. I see. So the `probe` part may be deserving of a `todo(sm<4)`. I made patches for that on the second part of !418, but I think that for now it is okay to leave the requirement. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/417#note_49293

1 0

Re: [PATCH v2 0/2] MR4108: Improve DMI tables under Linux.
by eric pouech (＠epo) Oct. 19, 2023

Oct. 19, 2023

because it's explicitly requested. man machine-id > ```plaintext > This ID uniquely identifies the host. It should be considered "confidential", and must not be exposed in untrusted environments, in particular on the network. If a stable unique identifier that is tied to the machine is needed for some application, the machine ID or any part of it must not be used directly. Instead the machine ID should be hashed with a cryptographic, keyed hash function, using a fixed, application-specific key. That way the ID will be properly unique, and derived in a constant way from the machine ID but there will be no way to retrieve the original machine ID from the application-specific one. The sd_id128_get_machine_app_specific(3) API provides an implementation of such an algorithm. > ``` (looks like /etc/machine-id should never have been user readable, and this is about reducing the exposure) for the second patch in the serie, the we need to craft missing info (because some DMI fields are only readble by root), do you also recommand to reuse directly machine-id? (it would be better to not tie the values to a given prefix, anticheat vendors will not like it), so the least worst choice is deriving from machine-id. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4108#note_49291

1 0

Re: [PATCH v2 0/1] MR4043: uxtheme: add some ordinals to spec file needed by Captvty
by Louis Lenders (＠xe) Oct. 19, 2023

Oct. 19, 2023

On Thu Oct 19 10:52:35 2023 +0000, Zhiyi Zhang wrote: > You can use something like e5536fa0de6b9e5dc151bfe3593ac6a72ddfc6f9 to > decide whether to skip tests. Hi Zhiyi, I opened a new merge request here https://gitlab.winehq.org/wine/wine/-/merge_requests/4143 as 'git push' didn't work and don't know how to resolve it -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4043#note_49289

1 0

[PATCH 0/5] MR4142: Cleanup passing info from dbghelp to WineDbg.
by eric pouech (＠epo) Oct. 19, 2023

Oct. 19, 2023

We used to have some hack for passing information (mainlyi module related ones) from dbghelp to WineDbg. This series: - reimplements properly the sharing, introducing a Wine entrypoint to dbghelp (sharing debug formats not handled by native, no longer decorating module names for sharing that module was in fact a host module...) - improves "info share" command in WineDbg with more accurate information (host module type...) - improves loading time on MacOs (some system libraries no longer have their images accessible directly on disk by standard file operation). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4142

2 5

Re: [PATCH v2 0/1] MR4043: uxtheme: add some ordinals to spec file needed by Captvty
by Zhiyi Zhang (＠zhiyi) Oct. 19, 2023

Oct. 19, 2023

On Thu Oct 19 10:52:35 2023 +0000, Louis Lenders wrote: > Hi Zhiyi, > Is that patch > https://testbot.winehq.org/GetFile.pl?JobKey=138698&StepKey=1 then ok to > add as merge request? You can use something like e5536fa0de6b9e5dc151bfe3593ac6a72ddfc6f9 to decide whether to skip tests. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4043#note_49277

1 0

[PATCH 0/1] MR4015: ntdll: Add WinSqmSetIfMaxDWORD stub
by Fabian Maurer (＠DarkShadow44) Oct. 19, 2023

Oct. 19, 2023

Needed by native uiribbon -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4015

3 3

Re: [PATCH v2 0/1] MR4043: uxtheme: add some ordinals to spec file needed by Captvty
by Louis Lenders (＠xe) Oct. 19, 2023

Oct. 19, 2023

Hi Zhiyi, Is that patch https://testbot.winehq.org/GetFile.pl?JobKey=138698&StepKey=1 then ok to add as merge request? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4043#note_49274

1 0