November 2023 - Wine-GitLab

[PATCH v4 0/1] MR2274: ntdll: Add source file and line to debug traces.
by Rémi Bernon Feb. 29, 2024

Feb. 29, 2024

-- v4: ntdll: Add source and return address information to debug traces. https://gitlab.winehq.org/wine/wine/-/merge_requests/2274

1 3

[PATCH v2 0/4] MR3199: winhttp: Handle SEC_I_RENEGOTIATE after DecryptMessage.
by Rémi Bernon Feb. 29, 2024

Feb. 29, 2024

This is some very old patch series, initially aimed at speeding up Gears of Wars online connection, but it wasn't clear if it was actually necessary. We now confirmed that it is also required for Gears 5 online mode, and without it, connection fails with an error message. I updated the last change to specifically handle TLS rehandshake vs empty input, to avoid breaking some tests. I think having empty input when renegotiating is a valid scenario, although I'm not sure how to write tests for that (it will require some server-side part to request a re-handshake to the client). In any case, this has nothing to do with client certificate as the returned ERROR_WINHTTP_CLIENT_AUTH_CERT_NEEDED error in the code seems to suggest. -- v2: secur32: Perform TLS re-handshake after SEC_I_RENEGOTIATE was returned. winhttp: Handle SEC_I_RENEGOTIATE after DecryptMessage. winhttp: Introduce new netconn_negotiate helper. winhttp: Move connect end checks out of the loop. https://gitlab.winehq.org/wine/wine/-/merge_requests/3199

3 8

[PATCH v6 0/5] MR2698: winex11: Avoid breaking XIM XFilterEvent / XmbLookupString sequence.
by Rémi Bernon Feb. 29, 2024

Feb. 29, 2024

-- v6: winex11: Avoid breaking XIM sequence when merging mouse motion events. winex11: Avoid breaking XIM sequence when merging ConfigureNotify events. winex11: Introduce new handle_delayed_event helper. winex11: Move call_event_handler function around. winex11: Remove unnecessary process_events helper. https://gitlab.winehq.org/wine/wine/-/merge_requests/2698

1 7

[PATCH 0/1] MR3558: Draft: gdiplus: Test linelimiting
by David Kahurani (＠kahurani) Feb. 27, 2024

Feb. 27, 2024

Just using the servers to test for now because this test seems to pass on Windows. This test seems to be passing for me on Windows 10. Signed-off-by: David Kahurani k.kahurani(a)gmail.com -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3558

3 6

[PATCH 0/1] MR427: tools: Add a lightboard script to get detailed info from individual HLSL tests.
by Francisco Casas (＠fcasas) Feb. 20, 2024

Feb. 20, 2024

After running 'make check', this script can be used to see which tests are not passing, showing the test line and a \[XP\], \[XF\], or \[F\] tag, for each backend. It can be used like this: ```plaintext python3 lightboard.py [-b] <vkd3d_build_path>/tests/hlsl ``` ![lightboard.png](/uploads/f97450e6d583ebcef4c90d622981571b/lightboard.png) So we can say "All lights green across the board" in a cinematic way. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/427

3 5

[PATCH v11 0/3] MR741: ntdll: Implement NtFlushProcessWriteBuffers.
by Torge Matthies (＠tmatthies) Feb. 16, 2024

Feb. 16, 2024

Based on [a patch](https://www.winehq.org/mailman3/hyperkitty/list/wine-devel(a)winehq.… by Jinoh Kang (@iamahuman) from February 2022. I removed the need for the event object and implemented fast paths for Linux. On macOS 10.14+ `thread_get_register_pointer_values` is called on every thread of the process. On Linux 4.14+ `membarrier(MEMBARRIER_CMD_GLOBAL_EXPEDITED, ...)` is used. On x86 Linux <= 4.13 and on other platforms `madvise(..., MADV_DONTNEED)` is used, which sends IPIs to all cores causing them to do a memory barrier. -- v11: ntdll: Add thread_get_register_pointer_values-based implementation of NtFlushProcessWriteBuffers. ntdll: Add sys_membarrier-based implementation of NtFlushProcessWriteBuffers. ntdll: Add MADV_DONTNEED-based implementation of NtFlushProcessWriteBuffers. https://gitlab.winehq.org/wine/wine/-/merge_requests/741

3 10

[PATCH 0/1] MR1425: ntdll: Return FILE_DEVICE_DISK for Unix FIFOs and sockets from get_device_info().
by Paul Gofman (＠gofman) Feb. 14, 2024

Feb. 14, 2024

Currently GetFileType() ends up returning the file type solely based on Unix fd type if it gets it from server. The problematic case is when our process gets a pipe or socket fd as a stdin or stderr from Unix. The server object which gets created through wine_server_fd_to_handle is a regular file regardless of the underlying Unix fd type. It probably can't be anything else, at least for pipes, as the pipe should have both ends but we have only one in this case. That causes problems, e. g., with libuv (used, e. g., by Vampire Survivors). It checks stdout handle type and if it is pipe it tries to do SetNamedPipeHandleState() on it and does not tolerate the failure. It looks more sensible to me to report all the pipes and sockets created through wine_server_fd_to_handle() as regular files as that matches the server objects we have for them. When that is not the case we should get the correct type from server fd type. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1425

4 4

[PATCH 0/1] MR305: Draft: vkd3d-shader/hlsl: Implement strings
by Petrichor Park (＠petrathekat) Feb. 11, 2024

Feb. 11, 2024

Strings are opaque objects in HLSL. This implements recognizing string literals and the `string` type. This should fix the bug marked below but I'm not sure how to get my hands on a copy of Lego Star Wars Saga to test it properly. This is a super-duper draft MR; I'm certain there's problems with it. I do at least have a passing test, though. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=50382 -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/305

5 24

[PATCH 0/4] MR3422: ddraw tests for Pick and GetPickRecords
by Jeffrey Smith (＠whydoubt) Feb. 8, 2024

Feb. 8, 2024

Basically, this is the tests from https://gitlab.winehq.org/wine/wine/-/merge_requests/3420 with fixes applied where they originate, rather than later in the series. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3422

4 6

[PATCH 0/6] MR4518: ntdll: Integrate with GDB using systemtap rtld probes.
by Rémi Bernon Feb. 3, 2024

Feb. 3, 2024

Effectively implementing the debugger interface as described in https://sourceware.org/git/?p=glibc.git;a=blob;f=elf/rtld-debugger-interfac… This is an actual attempt at having this upstream, split from https://gitlab.winehq.org/wine/wine/-/merge_requests/1074 which people have been finding useful for debugging Wine directly in GDB. This supports everything you would expect, from automatic symbol loading as well as cross-syscall backtraces with the new Python unwinder. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4518

2 10