November 2023 - Wine-GitLab

[PATCH 0/4] MR3422: ddraw tests for Pick and GetPickRecords
by Jeffrey Smith (＠whydoubt) Feb. 7, 2024

Feb. 7, 2024

Basically, this is the tests from https://gitlab.winehq.org/wine/wine/-/merge_requests/3420 with fixes applied where they originate, rather than later in the series. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3422

4 6

[PATCH 0/6] MR4518: ntdll: Integrate with GDB using systemtap rtld probes.
by Rémi Bernon Feb. 2, 2024

Feb. 2, 2024

Effectively implementing the debugger interface as described in https://sourceware.org/git/?p=glibc.git;a=blob;f=elf/rtld-debugger-interfac… This is an actual attempt at having this upstream, split from https://gitlab.winehq.org/wine/wine/-/merge_requests/1074 which people have been finding useful for debugging Wine directly in GDB. This supports everything you would expect, from automatic symbol loading as well as cross-syscall backtraces with the new Python unwinder. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4518

2 10

[PATCH 0/1] MR2902: winex11.drv: Expose GWL_STYLE and GWL_EXSTYLE as X11 properties.
by Joshua Ashton (＠joshua) Feb. 2, 2024

Feb. 2, 2024

As _WINE_HWND_STYLE and _WINE_HWND_EXSTYLE respectively. Gamescope parses these to make smarter decisions about what window to primary focus, or to treat as a dropdown/overlay. This was originally a Proton commit by Remi Bernon, however, it would definitely be nice to have support for Gamescope focusing correctly under upstream Wine as well. Fixes a bunch of games/launchers run with Wine under Gamescope. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2902

6 12

[PATCH v3 0/6] MR2298: winewinrt: Introduce new WinRT common module.
by Rémi Bernon Jan. 31, 2024

Jan. 31, 2024

The idea I have is to use this module to declare class stubs until there is a good reason to split them to dedicated modules. WinRT modules aren't usually loaded directly, and instead the registry is queried to figure which module to load for which class. This would help avoiding unnecessary proliferation of stub WinRT modules, while at the same time allowing to factor WinRT foundation code (such as vector / async, etc...) between the modules that seem to deserve to be implemented separately. The relevant classes could then be split out to dedicated modules on a as-needed basis, when they get fleshed out. -- v3: winewinrt: Factor IAsyncOperation<boolean> implementations. winewinrt: Factor IAsyncInfo implementations. winewinrt: Move Vector<HSTRING> from windows.media.speech. widl: Write C type names for function parameters. winewinrt: Factor Vector<IInspectable> implementations. winewinrt: Introduce new static library. https://gitlab.winehq.org/wine/wine/-/merge_requests/2298

4 12

[PATCH v7 0/4] MR306: vkd3d-shader: Fix UAV coherence.
by Conor McCarthy (＠cmccarthy) Jan. 29, 2024

Jan. 29, 2024

-- v7: vkd3d-shader/spirv: Handle thread group UAV barriers. vkd3d-shader/spirv: Include Uniform in the memory semantics for UAV barriers. vkd3d-shader/spirv: Handle globally coherent UAVs. vkd3d-shader: Introduce a UAV_GLOBALLY_COHERENT descriptor info flag. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/306

2 5

[PATCH v3 0/12] MR4102: Draft: winewayland.drv: Implement keyboard input support.
by Rémi Bernon Jan. 29, 2024

Jan. 29, 2024

@afrantzis Can't seem to be possible to add you as a reviewer, probably you need to request "Access" to the wine/wine project (near the top of the project page). What do you think of something like that? It is very different from the current winex11 code, but I believe it will match keyboard layouts in a much more accurate way, and it's also IMO much simpler. If that works well with Wayland, I think it could be a good hint that it might work as well in X11 and make a case for my other MR to use that approach there. I was a bit annoyed that it doesn't seem possible to retrieve the Xkb "layout:variant" string here, but only the layout description, so I had to use xkbregistry to match it back to the known layouts. It is mostly only there to provide a more accurate HKL value (which should match the layout langid), and scan to vk mapping table, and custom layouts should still work. The lang would be neutral then, and the scan to vk table is QWERTY by default, which is the most common case, and doesn't enforce any vkey -> unicode mapping anyway. So, if the xkbregistry dependency is an issue we could probably make it optional and dynamically loaded, and skip the langid and scan to vk specialized mappings. -- v3: winewayland.drv: Implement Xkb composition using ImeProcessKey. winewayland.drv: Translate Xkb keyboard layouts to KBDTABLES. win32u: Allow KBDTABLES conversion from CTLR + ALT to WCHAR. win32u: Force US layout in ToUnicode when CTRL is pressed. win32u: Introduce KbdLayerDescriptor user driver entry. win32u: Avoid accessing NULL key name string pointer. winewayland.drv: Enumerate Xkb layouts and create matching HKL. winewayland.drv: Handle and parse Xkb keymap events. win32u: Implement opt-in auto-repeat for WM_(SYS)KEYDOWN messages. winewayland.drv: Configure win32u keyboard repeat delay and speed. winewayland.drv: Basic handling of Wayland keyboard events. gitlab: Install libxkbcommon and libxkbregistry dependencies. https://gitlab.winehq.org/wine/wine/-/merge_requests/4102

5 37

[PATCH 0/1] MR4561: localspl: Fix a maybe-uninitialized warning in fill_builtin_form_info().
by Aida Jonikienė Jan. 26, 2024

Jan. 26, 2024

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4561

3 8

[PATCH 0/1] MR4509: include: Add windows.system.diagnostics.telemetry.idl file.
by Aida Jonikienė Jan. 26, 2024

Jan. 26, 2024

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4509

2 6

[PATCH 0/1] MR4513: opengl32: Add a FIXME when doing a mapped buffer copy.
by Aida Jonikienė Jan. 26, 2024

Jan. 26, 2024

I should've pushed this shortly after the workaround for the WineD3D WoW64 graphics corruption got upstreamed (which I discovered when messing around) but never got around to MR anything in Wine. The copies of mapped buffers introduce significant performance overhead (I'll add a FIXME so that people don't get surprised when their old games run like a slideshow like for example NFS Most Wanted). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4513

2 3

[PATCH v5 0/1] MR263: vkd3d-shader/spirv: Refactor the type system.
by Conor McCarthy (＠cmccarthy) Jan. 23, 2024

Jan. 23, 2024

Shader Model 6 introduces a 16-bit float (half) type, and 16-bit and 64-bit integer types. Storing extra info in the type enum simplifies checking if a type is any integer, floating point or numeric type, and the declaration of SPIR-V types. The benefits depend on using enum vkd3d_data_type in the backend instead of vkd3d_shader_component_type. Patch 2 is difficult to split because types typically flow through to vkd3d_spirv_get_type_id(), so partial changes would require new calls to conversion functions which would be deleted again later. -- v5: vkd3d-shader/spirv: Use enum vkd3d_data_type instead of vkd3d_shader_component_type. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/263

3 3