June 2023 - Wine-GitLab - list.winehq.org

[PATCH 0/1] MR667: win32u: Ignore SetWindowPos() if it is trying to change topmost state for child window.
by Paul Gofman (＠gofman) March 3, 2024

March 3, 2024

I think the behaviour of SetWindowPos() in this case is partially explained by the fact that topmost state is not strictly applicable to child windows and so Windows denies such requests. Child window can still end up with WS_EX_TOPMOST style if it was set at window creation (doesn't work this way in Wine now) or, e. g., like in the test added in the patch. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=20190 Also fixes game load dialog in Indiana Jones and the Infernal Machine. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/667

6 6

[PATCH v2 0/4] MR3199: winhttp: Handle SEC_I_RENEGOTIATE after DecryptMessage.
by Rémi Bernon Feb. 29, 2024

Feb. 29, 2024

This is some very old patch series, initially aimed at speeding up Gears of Wars online connection, but it wasn't clear if it was actually necessary. We now confirmed that it is also required for Gears 5 online mode, and without it, connection fails with an error message. I updated the last change to specifically handle TLS rehandshake vs empty input, to avoid breaking some tests. I think having empty input when renegotiating is a valid scenario, although I'm not sure how to write tests for that (it will require some server-side part to request a re-handshake to the client). In any case, this has nothing to do with client certificate as the returned ERROR_WINHTTP_CLIENT_AUTH_CERT_NEEDED error in the code seems to suggest. -- v2: secur32: Perform TLS re-handshake after SEC_I_RENEGOTIATE was returned. winhttp: Handle SEC_I_RENEGOTIATE after DecryptMessage. winhttp: Introduce new netconn_negotiate helper. winhttp: Move connect end checks out of the loop. https://gitlab.winehq.org/wine/wine/-/merge_requests/3199

3 8

[PATCH v6 0/5] MR2698: winex11: Avoid breaking XIM XFilterEvent / XmbLookupString sequence.
by Rémi Bernon Feb. 29, 2024

Feb. 29, 2024

-- v6: winex11: Avoid breaking XIM sequence when merging mouse motion events. winex11: Avoid breaking XIM sequence when merging ConfigureNotify events. winex11: Introduce new handle_delayed_event helper. winex11: Move call_event_handler function around. winex11: Remove unnecessary process_events helper. https://gitlab.winehq.org/wine/wine/-/merge_requests/2698

1 7

[PATCH v11 0/3] MR741: ntdll: Implement NtFlushProcessWriteBuffers.
by Torge Matthies (＠tmatthies) Feb. 16, 2024

Feb. 16, 2024

Based on [a patch](https://www.winehq.org/mailman3/hyperkitty/list/wine-devel(a)winehq.… by Jinoh Kang (@iamahuman) from February 2022. I removed the need for the event object and implemented fast paths for Linux. On macOS 10.14+ `thread_get_register_pointer_values` is called on every thread of the process. On Linux 4.14+ `membarrier(MEMBARRIER_CMD_GLOBAL_EXPEDITED, ...)` is used. On x86 Linux <= 4.13 and on other platforms `madvise(..., MADV_DONTNEED)` is used, which sends IPIs to all cores causing them to do a memory barrier. -- v11: ntdll: Add thread_get_register_pointer_values-based implementation of NtFlushProcessWriteBuffers. ntdll: Add sys_membarrier-based implementation of NtFlushProcessWriteBuffers. ntdll: Add MADV_DONTNEED-based implementation of NtFlushProcessWriteBuffers. https://gitlab.winehq.org/wine/wine/-/merge_requests/741

3 10

[PATCH 0/1] MR1425: ntdll: Return FILE_DEVICE_DISK for Unix FIFOs and sockets from get_device_info().
by Paul Gofman (＠gofman) Feb. 14, 2024

Feb. 14, 2024

Currently GetFileType() ends up returning the file type solely based on Unix fd type if it gets it from server. The problematic case is when our process gets a pipe or socket fd as a stdin or stderr from Unix. The server object which gets created through wine_server_fd_to_handle is a regular file regardless of the underlying Unix fd type. It probably can't be anything else, at least for pipes, as the pipe should have both ends but we have only one in this case. That causes problems, e. g., with libuv (used, e. g., by Vampire Survivors). It checks stdout handle type and if it is pipe it tries to do SetNamedPipeHandleState() on it and does not tolerate the failure. It looks more sensible to me to report all the pipes and sockets created through wine_server_fd_to_handle() as regular files as that matches the server objects we have for them. When that is not the case we should get the correct type from server fd type. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1425

4 4

[PATCH 0/1] MR2902: winex11.drv: Expose GWL_STYLE and GWL_EXSTYLE as X11 properties.
by Joshua Ashton (＠joshua) Feb. 2, 2024

Feb. 2, 2024

As _WINE_HWND_STYLE and _WINE_HWND_EXSTYLE respectively. Gamescope parses these to make smarter decisions about what window to primary focus, or to treat as a dropdown/overlay. This was originally a Proton commit by Remi Bernon, however, it would definitely be nice to have support for Gamescope focusing correctly under upstream Wine as well. Fixes a bunch of games/launchers run with Wine under Gamescope. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2902

6 12

[PATCH 0/8] MR3059: Don't redefine typedefs (needed for gcc 4.3)
by Fabian Maurer (＠DarkShadow44) Jan. 20, 2024

Jan. 20, 2024

Signed-off-by: Fabian Maurer <dark.shadow4(a)web.de> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3059

6 23

[PATCH v4 0/2] MR3061: libs/jxr: Compile with ansi flag to avoid typedef redefinitions (gcc 4.3)
by Fabian Maurer (＠DarkShadow44) Jan. 20, 2024

Jan. 20, 2024

Signed-off-by: Fabian Maurer <dark.shadow4(a)web.de> -- v4: libs/jxr: Compile with ansi flag to avoid typedef redefinitions (gcc 4.3) wmphoto: Define ansi flag for JXRGlue to avoid typedef redefinitions (gcc 4.3) https://gitlab.winehq.org/wine/wine/-/merge_requests/3061

4 7

[PATCH v2 0/4] MR2408: winex11: Detect Xkb layouts and create HKL registry keys.
by Rémi Bernon Jan. 18, 2024

Jan. 18, 2024

-- v2: winex11: Create registry keys for known Xkb layouts. winex11: Keep a list of every known Xkb layout. winex11: Read the _XKB_RULES_NAMES root window property. win32u: Init vsc2vk in NtUserGetKeyNameText only if necessary. https://gitlab.winehq.org/wine/wine/-/merge_requests/2408

2 8

[PATCH v2 0/4] MR3024: win32u: Introduce a new rawinput dedicated thread.
by Rémi Bernon Jan. 18, 2024

Jan. 18, 2024

Currently only used to keep rawinput devices updated without iterating the entire list on every change. This thread will then let us solve several problems: * Solve issues with input not being polled if/when applications aren't checking their messages. This removes the need for polling messages in DInput, which is known to confuse and break DOSBOX. * Solve some issues with ll-hook deadlocks between hooking threads and the thread that is currently polling for inputs. * Useful to process internal messages and implement some user driver mechanisms. It can for instance already process WM_WINE_CLIPCURSOR messages, instead of relying on the foreground thread. * Similarly, for cursor icon changes, wineserver can notify it on cursor window changes and request the cursor icon to be updated from the user driver, instead of having to check the window the cursor is located in to change its icon on every mouse move. * Ultimately make it possible to drop the __wine_send_input PE export, the thread can read HID reports from devices that a process has registered for, and send WM_INPUT messages accordingly. This has some drawbacks though, as reading NT devices currently involves much more wineserver roundtrips than `__wine_send_input`. There's evidence that Windows uses a similar thread to process hardware events (as described in https://devblogs.microsoft.com/oldnewthing/20140213-00/?p=1773) although it's probably a system-wide kernel thread. I considered reading X11 input from a per-prefix dedicated thread (for instance in explorer.exe) or dedicated process, but having one thread per-process has several advantages. The rawinput device registration state is done per-process and according to https://gitlab.winehq.org/wine/wine/-/merge_requests/2120 it also needs to post notifications that are process specific. It also keeps the guarantee that each process will read the inputs from the window it has created, and not from some other windows, although the message dispatch may decide to send the message to another process later, it avoids having to listen to input on other processes windows. It can then be seen as an intermediate step towards having a per-prefix thread, if that's something we end up needing. Moving from a per-process thread to a per-prefix thread should be easier. -- v2: win32u: Keep rawinput device list updated using WM_DEVICECHANGE. win32u: Register for device notifications in the rawinput thread. win32u: Introduce a dedicated thread for rawinput processing. ntdll/tests: Use combase instead of comctl32 as a test module. https://gitlab.winehq.org/wine/wine/-/merge_requests/3024

3 8