July 2023 - Wine-GitLab - list.winehq.org

[PATCH v5 0/9] MR209: vkd3d-shader/hlsl: Broaden resources support v2, part 3.
by Francisco Casas (＠fcasas) July 13, 2023

July 13, 2023

Mainly promoting single object components to variables for SM 5.0's RDEF block and lowering combined samplers to separate sampler+texture objects for SM 4. Following patches (including prepending uniform copies resource components within struct parameters) in: https://gitlab.winehq.org/fcasas/vkd3d/-/commits/master6c -- v5: vkd3d-shader/hlsl: Don't allocate all texture registers for synthetic separated samplers. vkd3d-shader/hlsl: Lower combined samplers to separate sampler and texture objects for SM4. vkd3d-shader/hlsl: Separate tracking of sampler_dim and usage for object components. vkd3d-shader/hlsl: Introduce hlsl_new_synthetic_var_named(). vkd3d-shader/hlsl: Check is_uniform instead of HLSL_STORAGE_UNIFORM when validating object refs. tests: Add lowering combined samplers tests. vkd3d-shader/hlsl: Handle resource components individually for SM 5.0. vkd3d-shader/tpf: Introduce struct extern_resource. vkd3d-shader/hlsl: Allow derefs to provide the data_type. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/209

4 13

[PATCH 0/6] MR278: vkd3d-shader/dxil: Emit the shader instructions.
by Conor McCarthy (＠cmccarthy) July 13, 2023

July 13, 2023

Sufficient for compiling a no-op pixel shader. This should probably be rebased on top of !263 because it introduces vkd3d_spirv_get_type_id_for_data_type(), which 263 renders unnecessary. !263 is not essential, but I think using two different type systems in the backend is not ideal. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/278

2 6

[PATCH v4 0/2] MR3301: Improve trace output
by Vitaly Lipatov (＠lav) July 12, 2023

July 12, 2023

-- v4: secur32: Print also text name for EXTENDED_NAME_FORMAT argument. advapi32: Print also text name for POLICY_INFORMATION_CLASS argument. https://gitlab.winehq.org/wine/wine/-/merge_requests/3301

2 2

Re: [PATCH v3 0/2] MR3301: Improve trace output
by Jeffrey Smith (＠whydoubt) July 12, 2023

July 12, 2023

Jeffrey Smith (@whydoubt) commented about dlls/secur32/secur32.c: > + "NameGivenName", > + "NameSurname" > +}; > + > +static LPCSTR debugstr_NameFormat(IN EXTENDED_NAME_FORMAT NameFormat) > +{ > + if (NameFormat >= sizeof(string_NameFormat)/sizeof(string_NameFormat[0])) > + return "(unknown)"; > + return string_NameFormat[NameFormat]; > +} > + > BOOLEAN WINAPI GetUserNameExW( > EXTENDED_NAME_FORMAT NameFormat, LPWSTR lpNameBuffer, PULONG nSize) > { > - TRACE("(%d %p %p)\n", NameFormat, lpNameBuffer, nSize); > + TRACE("(%d %s %p %p)\n", NameFormat, debugstr_NameFormat(NameFormat), lpNameBuffer, nSize); Written this way, it would make it appear that the function takes 4 parameters. I would suggest revising to make it clear that this is two representations of the same parameter. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3301#note_38855

1 0

Re: [PATCH v3 0/2] MR3301: Improve trace output
by Jeffrey Smith (＠whydoubt) July 12, 2023

July 12, 2023

Jeffrey Smith (@whydoubt) commented about dlls/advapi32/lsa.c: > + "PolicyAuditEventsInformation", > + "PolicyPrimaryDomainInformation", > + "PolicyPdAccountInformation", > + "PolicyAccountDomainInformation", > + "PolicyLsaServerRoleInformation", > + "PolicyReplicaSourceInformation", > + "PolicyDefaultQuotaInformation", > + "PolicyModificationInformation", > + "PolicyAuditFullSetInformation", > + "PolicyAuditFullQueryInformation", > + "PolicyDnsDomainInformation" > +}; > + > +static LPCSTR debugstr_InformationClass(IN POLICY_INFORMATION_CLASS InformationClass) > +{ > + if (InformationClass >= sizeof(string_InformationClass)/sizeof(string_InformationClass[0])) ```suggestion:-0+0 if (InformationClass >= ARRAY_SIZE(string_InformationClass)) ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3301#note_38854

1 0

Re: [PATCH v3 0/2] MR3301: Improve trace output
by Jeffrey Smith (＠whydoubt) July 12, 2023

July 12, 2023

Jeffrey Smith (@whydoubt) commented about dlls/secur32/secur32.c: > + "NameFullyQualifiedDN", > + "NameSamCompatible", > + "NameDisplay", > + "NameUniqueId", > + "NameCanonical", > + "NameUserPrincipal", > + "NameCanonicalEx", > + "NameServicePrincipal", > + "NameDnsDomain", > + "NameGivenName", > + "NameSurname" > +}; > + > +static LPCSTR debugstr_NameFormat(IN EXTENDED_NAME_FORMAT NameFormat) > +{ > + if (NameFormat >= sizeof(string_NameFormat)/sizeof(string_NameFormat[0])) ```suggestion:-0+0 if (NameFormat >= ARRAY_SIZE(string_NameFormat)) ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3301#note_38853

1 0

Re: [PATCH v3 0/2] MR3301: Improve trace output
by Jeffrey Smith (＠whydoubt) July 12, 2023

July 12, 2023

Jeffrey Smith (@whydoubt) commented about dlls/secur32/secur32.c: > } > > +static LPCSTR string_NameFormat[] = > +{ > + "NameUnknown", > + "NameFullyQualifiedDN", > + "NameSamCompatible", > + "NameDisplay", > + "NameUniqueId", > + "NameCanonical", > + "NameUserPrincipal", > + "NameCanonicalEx", > + "NameServicePrincipal", > + "NameDnsDomain", > + "NameGivenName", > + "NameSurname" The values in the EXTENDED_NAME_FORMAT enumeration are not contiguous, so you need to fill in some gaps. For instance, NameUniqueId is 6. If passed in, this method would return "NameUserPrincipal". -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3301#note_38852

1 0

Re: [PATCH v2 0/3] MR3318: include: Update Kerberos related headers - approved
by Alexandre Julliard (＠julliard) July 12, 2023

July 12, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3318

1 0

Re: [PATCH v6 0/8] MR3050: msvcrt: Switch to using snames for create_locinfo. - approved
by Alexandre Julliard (＠julliard) July 12, 2023

July 12, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3050

1 0

Re: [PATCH v2 0/1] MR3315: ntdll: Fix NtContinue from within exception context on ARM64 - approved
by Alexandre Julliard (＠julliard) July 12, 2023

July 12, 2023

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3315

1 0